From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 746F4C433E6 for ; Thu, 21 Jan 2021 10:28:07 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F3F082343E for ; Thu, 21 Jan 2021 10:28:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F3F082343E Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.71990.129348 (Exim 4.92) (envelope-from ) id 1l2XC1-0006rP-H7; Thu, 21 Jan 2021 10:27:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 71990.129348; Thu, 21 Jan 2021 10:27:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l2XC1-0006rI-EG; Thu, 21 Jan 2021 10:27:57 +0000 Received: by outflank-mailman (input) for mailman id 71990; Thu, 21 Jan 2021 10:27:55 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l2XBz-0006r9-I6 for xen-devel@lists.xenproject.org; Thu, 21 Jan 2021 10:27:55 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 63fd445c-96ea-4e34-b304-815f152f2b64; Thu, 21 Jan 2021 10:27:54 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 10CB5AB7A; Thu, 21 Jan 2021 10:27:54 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 63fd445c-96ea-4e34-b304-815f152f2b64 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1611224874; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ilr2Y3d9TXRrAqwdx00phSIblAZCT2Rd4+CVsRP5WJo=; b=ZyJOdpnqvq78jYIfH7JNroSAln3ujB2+goSAMERk4OPhHbjYt6stWGpcLjLQCsfkfMqH9W PLsLjwcTesy9fESEB7EiVm6LTcwelo1qsZjsHBZAporq48x9tkQRalqP5byyT6UpHTjS8b L+D0exPbxBSy4HoXRytfhWhkL62P3HE= Subject: Re: [PATCH V4 09/24] xen/ioreq: Make x86's IOREQ related dm-op handling common To: Oleksandr Cc: Julien Grall , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Paul Durrant , Daniel De Graaf , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org References: <1610488352-18494-1-git-send-email-olekstysh@gmail.com> <1610488352-18494-10-git-send-email-olekstysh@gmail.com> <016657f8-371f-eba6-60ce-29741f0823b7@suse.com> <832cbb2f-a3dd-c97d-b35a-951fed63ad2b@gmail.com> From: Jan Beulich Message-ID: Date: Thu, 21 Jan 2021 11:27:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <832cbb2f-a3dd-c97d-b35a-951fed63ad2b@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 21.01.2021 11:23, Oleksandr wrote: > I would like to clarify regarding do_dm_op() which is identical for both > arches and could *probably* be moved to the common code (we can return > common dm.c back to put it there) and make dm_op() global. > Would you/Paul be happy with that change? Or there are some reasons > (which we are not aware of yet) for not doing it this way? Probably reasonable to do; the only reason not to that I could see is that then dm_op() has to become non-static. Jan