From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EE74C67871 for ; Thu, 27 Oct 2022 08:36:08 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 69CED42BB2; Thu, 27 Oct 2022 10:36:07 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2056.outbound.protection.outlook.com [40.107.220.56]) by mails.dpdk.org (Postfix) with ESMTP id EEC834280C; Thu, 27 Oct 2022 10:36:05 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NNzpd4fNCy1hHJGY8ROewgWe10i/A8d43ircXTUJI3Bi0BDgSOQXhzTkXclYI77gTyPVT9+RxwXCiPRnK7gYmMbt8YczNXXXBP1bsdIcXuyzT7Sw7fUq+dnUBLF0QZqLkL5iwhbWe3euS8Lru2VXetaoC8nWruxNTn461b7+5IoLBcPLK3Hp+tAVkfZ/Ej6wHcu8n/PpRkcafaZ71vi5P55AorfGSbdTe8nGicinqKhYdtqs8AnLsxQyVYyp9Odm8d1ewNiCvkfPe91SnARgKOeK6dnHaeNmBgWTGZorbobPliI0110YnDeC872XIH6ZvrHLVAQv399tgNPszN5SUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GHjmTGAM/DcG8sJ/GdLIoz4iWr43fcY1KDfbEz0mVzI=; b=jGjLr14CbpcMYQBLJa0vZzCeIGo34sH7n5h+H3Hd8cfdbGrzb+hkNSpixlBvyXf7ktovNCtDV6zOQCU0xfOjeXK9n3wwI1s9q6MZVa6fmagritLLEZrBgyXplx1RHOD9EWeJtGroG+g1j4qwKEaoUMlzGMMaJHd7Iw+fS+l0ZhDozq2+7vjf56czzCLyaYMl0V69LEhmtht9p6Y/CCsdeQVXuKPmdIrjbyvl80wZZblUFfNbcQ3uWDrd7cprKFXo014ZpBWlTRQNvrO94crPGuYk+Q2A07cjZGAo609PoeOx9KVja4Vse3SXji3VR3NO0fQkMSqoc+Y0OJ6THHeKHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GHjmTGAM/DcG8sJ/GdLIoz4iWr43fcY1KDfbEz0mVzI=; b=N8gfoNKhYxquA5/vKspBlyutJjwzo2yNWrcE1XUgkmIpxGdkYczphayEtB5wn3SDu7RVtZE9kyKGMIG0o9ru/rs5R7rpL6RLeZhNDrtefmKfpSXhjJQIOrXuHEjZ11DzZ8pjVEtU2LXsfnOObK7V3eQmeWM2Uyfum7kHfFldRzY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) by PH7PR12MB6441.namprd12.prod.outlook.com (2603:10b6:510:1fb::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Thu, 27 Oct 2022 08:36:03 +0000 Received: from MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::7900:1b25:bc:104c]) by MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::7900:1b25:bc:104c%8]) with mapi id 15.20.5746.028; Thu, 27 Oct 2022 08:36:03 +0000 Message-ID: Date: Thu, 27 Oct 2022 09:35:59 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH] bus/vdev: automatically add eth alias for net drivers Content-Language: en-US To: David Marchand Cc: Bruce Richardson , Thomas Monjalon , dev@dpdk.org, techboard@dpdk.org References: <20220921133451.4164506-1-ferruh.yigit@amd.com> <20221019131118.32394-1-bruce.richardson@intel.com> <5565666.Sgy9Pd6rRy@thomas> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0133.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:193::12) To MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR12MB4301:EE_|PH7PR12MB6441:EE_ X-MS-Office365-Filtering-Correlation-Id: 7f55492a-5e61-447f-5f53-08dab7f64894 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: q35eT5/+JLjkhVZK5b3f365lMpBQCHa1bihn2ibzY5LJUt+gRz0S6QtRVVI/HYQmTQ8fbVSL5m/htb50ycnXt5NToEO5mjmsvqHhhQ/s2HTVc/pGTlwPEktFbowIzjnUCEQZe38aKAuijU+rj89ioxyloMaFrx0h570UWZcfRCpKQzrCKbfkKo6n2Nl+iYsM7QdM1pSYHQc4SxBaK4P5bnDe3Aw8If+6aTmOoIdHH1qOwoa5s4tJrOhvt4po+Y7INmJQ6yDfnNh8JhNVoiFhjPVQM4HjpNZaBg3ojXGpLGN+HyQHS/57mUT280N/KnY+mpi9nPL3+tITWFNgGxuHfuLUvV7TTX3TzOHoC16d6DbuFVWUEcCMmHV6oSzkwxw7JEZaNP2cmIlfV55XVPLqnx4ux/vL3dH82SPx22FcU0G0nCcWE/OSYGHp1RYInkVbwbwhwBiHAtNCjFNBYBQj8pntO3uUX0kk9b2rtm8uHPkQ0EcedYYXP6A3xsA+N+2xZFlVZKHZ0EJQljcuZSlx0clmSXEHAfG0+L1IdmqLZpu/5ng/RXTcBzfSxYWGYa1IsMIbHYuU8IN+ulUbr5Oi09s91GZYGrSLpIDOjHj8ZJA+a6dXFqPvJnaTILEgeGMv/N+VLsAd7VKlEDf/elPYvYg0cLsLJeALSKF9v9dmmyIzFCX+O7JjGIFYUMRWQQDjzJH+l4GGj/LsHjYNHJa4Yt32H9XhzxnXGBqE5UpgdsJC6tf3NQS7gVdv8MTlXglhfM3qOzjnEWWFy82hQHBCJzDystmmiFugf7VmkXVkx7o= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB4301.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(366004)(376002)(136003)(396003)(346002)(39860400002)(451199015)(31686004)(8936002)(5660300002)(2906002)(44832011)(41300700001)(38100700002)(83380400001)(6916009)(54906003)(6506007)(53546011)(478600001)(66556008)(36756003)(31696002)(66476007)(66946007)(186003)(4326008)(8676002)(86362001)(316002)(6666004)(6512007)(6486002)(2616005)(26005)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZFJSS29lLzFOTXlMby9qaHFuN0ZRQlZneFdLSTEwaVNpNGU4aXdxakVtT1NZ?= =?utf-8?B?eUNMWHEzT1llNjFXTWYxMklXMFJ2K1d0T0tEcmxXMWFCZTNEOXZBMWZZM0l1?= =?utf-8?B?eXRCSXpzaVVBTk9nRm4ya2gvN3dhWkFhNHFVcE03WUkzRnF6b3piUG01Q0RZ?= =?utf-8?B?SWpxYzRuZkVNeDlpQ2RHSGF1M09jN3hKbzlDaGlUQ3JQU3ZCR0o2UkE0T21Y?= =?utf-8?B?YytFRHlyOW13bjJBRTZSdS9TVHNaQkY4ejkxWTdha09jTml1REwxMGE0WnRI?= =?utf-8?B?dmRYWE9HbFRLckNPTVdOOVpGWFIxQ2crQkE4azNPYkFBdVd0NC9BcncrcHZP?= =?utf-8?B?Z2pteXk2QUtZZ1ZLcXVnMnpuL1dreGVyanhxOFpyNlN0Y25VZlJHcVFFczZP?= =?utf-8?B?OVFROTZhZzZMc0JzanFkTjF2R3hZZTJxOHRuTmg3bE81MXJtd2t5Rnd3cE9B?= =?utf-8?B?ZGdWQWp5MytiMUtwQWtvOFZZcW9WOEhzbG5YKzVZeFBGdlQvWWNyZ0wvNGVy?= =?utf-8?B?ZlpEZGVob25OSG5tTis1SzBsMUlsQzh6QWEzT1JFanhqem9NbWNFem9GRmJp?= =?utf-8?B?d0tMVnZRWlNidG5TVlZ2UURmb0l5NW1NUDAxTWkyblU3eDAwakJ1Vm1CU0pC?= =?utf-8?B?RXd4Q05zNElNSndOM0llclZLU0Vsc1Vva21kQWFmWjdUZ2c5U1lFaFZicGZv?= =?utf-8?B?MUV0RHVNK2ZPQ0d4bkxIa0UrT0NtbG9yd05xd0M3YXpTY2tkTTVFUC96VnRx?= =?utf-8?B?azlycXZBMmRGSVVDV3dBeWRzMWJQUzFJMGNMeHZqeTRiSStwWlM1cUVwdmNo?= =?utf-8?B?VjdMbVNzQitKTWM5Tk5FcnRIR1c1VDNVaGZ1MU9tbkg4MElRRnNQZGUybzlH?= =?utf-8?B?bkpPTDhWMzF6UktBUldXK01Ud2M1SDk4ZXlNai92Y3NiTjh5TGIxOGNoRDJ4?= =?utf-8?B?Y1J2K3RkYVpPWFBEU3lLVDMraE9HRmtNQ2xZcFpkUTdPTVVRdC9TTkpnMHJr?= =?utf-8?B?MUlVUFFXUGIrRUlaSURNeHdJelVET2VFM2xPK0trOG8xV1pqUlgwNnFiamF3?= =?utf-8?B?Y0hNdFBxa0wralBVTGJlU1A4ZStsRWNxZUxBcXhuVUEyOVg0YkZ3TGpTS0xI?= =?utf-8?B?dE1LRTU1MUpUbG8wMDFER1Q0RmJzZDhhcFlHcTAyRFFoc2tELytYT0ZDSjds?= =?utf-8?B?UVM4eUFtYkNNY2JTWTVSV2ZOOXV2TFkzcG5iMlQ3azVORXgveUJ3NjRuSEQ1?= =?utf-8?B?bURqTE00a1hzWXFUUjVzOEZzWHl6aFFZN1p1cGx6a3JHMUJHRGliWDhuVU1w?= =?utf-8?B?TmgzME40Q3pHcHhPcDExWkJ1czA1MUtWQTVRbFB4K0cvbzB6a3JldzZpeXhZ?= =?utf-8?B?NngxQmJwTlhmdDdwbE5sU29MVStRTWFmK0xrSUg0Rk5Sd0lNT0VFS3l4RUdP?= =?utf-8?B?bUwxZ3NmSjFNSUJqUXdTLzMwdkNlRWptQVVvTzJMa0pGa0F5VmQ4eEozNTFu?= =?utf-8?B?Z3N0WmR6djlKYzNPZ1B1YWV1UCtSamJkSXZXMGYvMGFacGhJbndCaHU3UUJZ?= =?utf-8?B?QlpRQzhwZy9YM0RSV0E5M2RSNHMra3pQYUxOd2ZhVXBJcDZ3YkVSeDJ5ay84?= =?utf-8?B?b3dvK3doNnlDWHRONmx0MEJPdTg0VHVleFZHSDZGY3ZlVUlkZDYwV3lsVVh5?= =?utf-8?B?N0p5bU90OVNxUS9ITU95b3V6d2d6Z203dUJwK1E4TXAyeXk1L3FOUW1pZzBZ?= =?utf-8?B?bzZDYkhvdzhsOGJRSzBEQXB5ZjFaNWtZYVNGK2RQREpvL1pLV2I3VWZ1NnVx?= =?utf-8?B?SFMzOFNLQjE0N2sxZXRydld2Zk9QandlQ3JUci93M01DTnBybXE1cVl3R2M3?= =?utf-8?B?eHYyaHQ0LytBZUlKeFRHUjZMeU5tWHBjam44WjNmRTMrTGpFNUVOczRLeGxO?= =?utf-8?B?QVdDNzB4b3NONHNSeWRTZnNoNFR2RXZEWUZOTFFUV2xiOFhTdGx4enl1dW1p?= =?utf-8?B?Y1hXRDBZOEVvT0xtdW91TTBYRnovd0t1ekh4OVRCa2lNdGdhWXBsanphS2xo?= =?utf-8?B?eHhTd2FEckVHRyttRXlMRGJrZjhxWlVJNEZWL1l5Wk1YMEgrcWw3SWgzY09O?= =?utf-8?Q?T8aWI9DukN6bbnS9nsOc4Z4aR?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7f55492a-5e61-447f-5f53-08dab7f64894 X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4301.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2022 08:36:03.6210 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NTvYLzpjusdjxMCS8ze5a7cS8WktAlvci0OydrlYdVGVpboJzth2/NXxIJX0ArVp X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6441 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/27/2022 8:58 AM, David Marchand wrote: > On Thu, Oct 20, 2022 at 1:52 PM Ferruh Yigit wrote: >>>> Honestly I think the status quo is OK: >>>> We have some aliases in some PMD for some historical reason >>>> and everybody looks OK with that. Isn't it? >>>> >>> >>> Well, the inconsistency bugs me a little, but if others feel the status quo >>> is ok, I'm ok with that. >> >> In my perspective this is for cleanup, and new PMDs keep adding alias >> because they are copying from existing drivers. >> Except from above there is no harm to have alias. > > Do we have a "valid" case of adding new aliases? > I don't think it is the case, so we can warn of new aliases > introduction in checkpatches.sh. > I commented a few of them to drop alias. checkpatch can be an option, but my intention was to drop old code to reduce noise, not to add more :) OK to keep the alias if removing it will cause more trouble. > At worse, if a valid case is identified later, checkpatches.sh is only > a warning in patchwork and maintainers will manually review this > warning. > >