From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Simon Arlott" Subject: Re: [PATCH] leds: bcm6328: Handle default-state of LEDs correctly Date: Mon, 26 Oct 2015 12:36:20 -0000 Message-ID: References: <562BB799.7000708@simon.arlott.org.uk> <562DE832.6070903@samsung.com> Mime-Version: 1.0 Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from proxima.lp0.eu ([81.2.80.65]:59600 "EHLO proxima.lp0.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753692AbbJZMgl (ORCPT ); Mon, 26 Oct 2015 08:36:41 -0400 In-Reply-To: <562DE832.6070903@samsung.com> Sender: linux-leds-owner@vger.kernel.org List-Id: linux-leds@vger.kernel.org To: Jacek Anaszewski Cc: Richard Purdie , linux-leds@vger.kernel.org, Linux Kernel Mailing List , =?utf-8?B?IsOBbHZhcm8gRmVybsOhbmRleiBSb2phcyI=?= , Jonas Gorski On Mon, October 26, 2015 08:45, Jacek Anaszewski wrote: > Hi Simon, > > Thanks for the patch. There are conflicts when applying > it to the LED tree: > > git://git.kernel.org/pub/scm/linux/kernel/git/j.anaszewski/linux-leds.git > > Please use it as a code base for your LED development. This has already been fixed in the devel branch by d19e6b6a0062c86a75365f0715fd079245f6aab9, although I think bcm6328_led() should adjust its use of the spinlock to only cover reading the register and call bcm6328_led_set() instead of copying the code from it. -- Simon Arlott