From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4A64C33CB1 for ; Wed, 15 Jan 2020 13:24:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6E83C20728 for ; Wed, 15 Jan 2020 13:24:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=amazon.co.uk header.i=@amazon.co.uk header.b="PBQCYFAC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E83C20728 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=amazon.co.uk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54050 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1irifJ-00067h-M1 for qemu-devel@archiver.kernel.org; Wed, 15 Jan 2020 08:24:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46605) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ire70-0006IR-Tj for qemu-devel@nongnu.org; Wed, 15 Jan 2020 03:33:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ire6v-0007SI-Sd for qemu-devel@nongnu.org; Wed, 15 Jan 2020 03:33:14 -0500 Received: from smtp-fw-4101.amazon.com ([72.21.198.25]:62446) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ire6v-0007RC-OB for qemu-devel@nongnu.org; Wed, 15 Jan 2020 03:33:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.co.uk; i=@amazon.co.uk; q=dns/txt; s=amazon201209; t=1579077190; x=1610613190; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ocWGvKzT9rHeLGLw56o19WY9tgHhZErb9cLkoBLDMQs=; b=PBQCYFACm6nZ37+pre+YvqPOXwl8fE2N0cTo1bPapwFTlzBafIjlLxra 2sovSGMxyfWv/33DdrrP1s0UsJoDfw6S/CyfYPxQRvGFPEfjgH5eNRYoF Zylju2IelxxOQBKB/QgbH1uM4P9kK+JnMWzQNc4qT3te8+vB0Ale/ndLX s=; IronPort-SDR: wvOOn/x2BXteConQ492U+xceQNdCh5lUsbwyrpFZL4Y3+BfSDXeps520clpjxzNWVPkesNhQqb oX1fkcFm18RQ== X-IronPort-AV: E=Sophos;i="5.70,322,1574121600"; d="scan'208";a="12455655" Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-1e-a70de69e.us-east-1.amazon.com) ([10.43.8.6]) by smtp-border-fw-out-4101.iad4.amazon.com with ESMTP; 15 Jan 2020 08:33:07 +0000 Received: from EX13MTAUEA002.ant.amazon.com (iad55-ws-svc-p15-lb9-vlan2.iad.amazon.com [10.40.159.162]) by email-inbound-relay-1e-a70de69e.us-east-1.amazon.com (Postfix) with ESMTPS id AECA2A1DEB; Wed, 15 Jan 2020 08:33:04 +0000 (UTC) Received: from EX13D32EUC002.ant.amazon.com (10.43.164.94) by EX13MTAUEA002.ant.amazon.com (10.43.61.77) with Microsoft SMTP Server (TLS) id 15.0.1236.3; Wed, 15 Jan 2020 08:33:04 +0000 Received: from EX13D32EUC003.ant.amazon.com (10.43.164.24) by EX13D32EUC002.ant.amazon.com (10.43.164.94) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 15 Jan 2020 08:33:03 +0000 Received: from EX13D32EUC003.ant.amazon.com ([10.43.164.24]) by EX13D32EUC003.ant.amazon.com ([10.43.164.24]) with mapi id 15.00.1367.000; Wed, 15 Jan 2020 08:33:02 +0000 From: "Durrant, Paul" To: =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Jason Andryuk CC: Andrew Cooper , Stefano Stabellini , "marmarek@invisiblethingslab.com" , "qemu-devel@nongnu.org" , Simon Gaiser , Anthony Perard , "xen-devel@lists.xenproject.org" Subject: RE: [Xen-devel] [PATCH 6/6] xen-pt: Round pci regions sizes to XEN_PAGE_SIZE Thread-Topic: [Xen-devel] [PATCH 6/6] xen-pt: Round pci regions sizes to XEN_PAGE_SIZE Thread-Index: AQHVykQofKTNIgpPpkmSOKKDUKIMmKfp72EAgABNlACAADjFgIAA8bAw Date: Wed, 15 Jan 2020 08:33:02 +0000 Message-ID: References: <57dc1083d20a469785f05a2e5250a820@AMSPEX02CL02.citrite.net> <20190322030936.fkiajz5ifgaejkd4@MacBook-Air-de-Roger.local> <20200114100406.GF11756@Air-de-Roger> <20200114180457.GG11756@Air-de-Roger> In-Reply-To: <20200114180457.GG11756@Air-de-Roger> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.43.165.165] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Precedence: Bulk X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 72.21.198.25 X-Mailman-Approved-At: Wed, 15 Jan 2020 08:23:46 -0500 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" > -----Original Message----- >=20 > > Linux PCI subsytem has an option resource_alignment that can be > > applied to either a single device or all devices. Booting with > > pci=3Dresource_aligment=3D4096 will align each device to a page. Do yo= u > > think pciback should force resource_alignment=3D4096 for dom0? > That sounds like a good idea. =20 > Ideally Xen should keep track of the BARs position and size and refuse > to passthrough devices that have BARs sharing a page with other > devices BARs. >=20 > > Are > > there other MMIO ranges to be concerned about adjacent to BARs? >=20 > IIRC you can have two BARs of different devices in the same 4K page, > BARs are only aligned to it's size, so BARs smaller than 4K are not > required to be page aligned. If we had a notion of assignment groups for this, as well as devices sharin= g requester id, then Xen would not need to refuse pass-through, it would ju= st require that all devices sharing the page were passed through as a unit. Paul From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.5 required=3.0 tests=DKIM_ADSP_ALL,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B13D9C33CB1 for ; Wed, 15 Jan 2020 08:33:36 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 80B812187F for ; Wed, 15 Jan 2020 08:33:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=amazon.co.uk header.i=@amazon.co.uk header.b="cDeGoeDk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 80B812187F Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=amazon.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ire6v-0001Ku-G6; Wed, 15 Jan 2020 08:33:09 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ire6u-0001Kp-9Q for xen-devel@lists.xenproject.org; Wed, 15 Jan 2020 08:33:08 +0000 X-Inumbo-ID: a819e0dc-3771-11ea-a985-bc764e2007e4 Received: from smtp-fw-4101.amazon.com (unknown [72.21.198.25]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a819e0dc-3771-11ea-a985-bc764e2007e4; Wed, 15 Jan 2020 08:33:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.co.uk; i=@amazon.co.uk; q=dns/txt; s=amazon201209; t=1579077188; x=1610613188; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ocWGvKzT9rHeLGLw56o19WY9tgHhZErb9cLkoBLDMQs=; b=cDeGoeDkeJ4/X5LWWcF+I9+w2M9Fr8MVeW/LOID9eWQ8X3yPnSAVAF0o hAG4uj94FhQJJ0IMLu8JfycZK9ZmrgHcvJ3egAVWDY5uy/2hjldPTzDFO MOlPz3lSpxRYS0ZPl5C5eEmvU6MHdQOx4+0YOJddGyzwHxwzyhxFqZFjT Q=; IronPort-SDR: wvOOn/x2BXteConQ492U+xceQNdCh5lUsbwyrpFZL4Y3+BfSDXeps520clpjxzNWVPkesNhQqb oX1fkcFm18RQ== X-IronPort-AV: E=Sophos;i="5.70,322,1574121600"; d="scan'208";a="12455655" Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-1e-a70de69e.us-east-1.amazon.com) ([10.43.8.6]) by smtp-border-fw-out-4101.iad4.amazon.com with ESMTP; 15 Jan 2020 08:33:07 +0000 Received: from EX13MTAUEA002.ant.amazon.com (iad55-ws-svc-p15-lb9-vlan2.iad.amazon.com [10.40.159.162]) by email-inbound-relay-1e-a70de69e.us-east-1.amazon.com (Postfix) with ESMTPS id AECA2A1DEB; Wed, 15 Jan 2020 08:33:04 +0000 (UTC) Received: from EX13D32EUC002.ant.amazon.com (10.43.164.94) by EX13MTAUEA002.ant.amazon.com (10.43.61.77) with Microsoft SMTP Server (TLS) id 15.0.1236.3; Wed, 15 Jan 2020 08:33:04 +0000 Received: from EX13D32EUC003.ant.amazon.com (10.43.164.24) by EX13D32EUC002.ant.amazon.com (10.43.164.94) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 15 Jan 2020 08:33:03 +0000 Received: from EX13D32EUC003.ant.amazon.com ([10.43.164.24]) by EX13D32EUC003.ant.amazon.com ([10.43.164.24]) with mapi id 15.00.1367.000; Wed, 15 Jan 2020 08:33:02 +0000 From: "Durrant, Paul" To: =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Jason Andryuk Thread-Topic: [Xen-devel] [PATCH 6/6] xen-pt: Round pci regions sizes to XEN_PAGE_SIZE Thread-Index: AQHVykQofKTNIgpPpkmSOKKDUKIMmKfp72EAgABNlACAADjFgIAA8bAw Date: Wed, 15 Jan 2020 08:33:02 +0000 Message-ID: References: <57dc1083d20a469785f05a2e5250a820@AMSPEX02CL02.citrite.net> <20190322030936.fkiajz5ifgaejkd4@MacBook-Air-de-Roger.local> <20200114100406.GF11756@Air-de-Roger> <20200114180457.GG11756@Air-de-Roger> In-Reply-To: <20200114180457.GG11756@Air-de-Roger> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.43.165.165] MIME-Version: 1.0 Precedence: Bulk Subject: Re: [Xen-devel] [PATCH 6/6] xen-pt: Round pci regions sizes to XEN_PAGE_SIZE X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Andrew Cooper , "marmarek@invisiblethingslab.com" , "qemu-devel@nongnu.org" , Simon Gaiser , Anthony Perard , "xen-devel@lists.xenproject.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+IAo+ID4gTGludXggUENJIHN1YnN5dGVtIGhh cyBhbiBvcHRpb24gcmVzb3VyY2VfYWxpZ25tZW50IHRoYXQgY2FuIGJlCj4gPiBhcHBsaWVkIHRv IGVpdGhlciBhIHNpbmdsZSBkZXZpY2Ugb3IgYWxsIGRldmljZXMuICBCb290aW5nIHdpdGgKPiA+ IHBjaT1yZXNvdXJjZV9hbGlnbWVudD00MDk2IHdpbGwgYWxpZ24gZWFjaCBkZXZpY2UgdG8gYSBw YWdlLiAgRG8geW91Cj4gPiB0aGluayBwY2liYWNrIHNob3VsZCBmb3JjZSByZXNvdXJjZV9hbGln bm1lbnQ9NDA5NiBmb3IgZG9tMD8KPgoKVGhhdCBzb3VuZHMgbGlrZSBhIGdvb2QgaWRlYS4KIAo+ IElkZWFsbHkgWGVuIHNob3VsZCBrZWVwIHRyYWNrIG9mIHRoZSBCQVJzIHBvc2l0aW9uIGFuZCBz aXplIGFuZCByZWZ1c2UKPiB0byBwYXNzdGhyb3VnaCBkZXZpY2VzIHRoYXQgaGF2ZSBCQVJzIHNo YXJpbmcgYSBwYWdlIHdpdGggb3RoZXIKPiBkZXZpY2VzIEJBUnMuCj4gCj4gPiBBcmUKPiA+IHRo ZXJlIG90aGVyIE1NSU8gcmFuZ2VzIHRvIGJlIGNvbmNlcm5lZCBhYm91dCBhZGphY2VudCB0byBC QVJzPwo+IAo+IElJUkMgeW91IGNhbiBoYXZlIHR3byBCQVJzIG9mIGRpZmZlcmVudCBkZXZpY2Vz IGluIHRoZSBzYW1lIDRLIHBhZ2UsCj4gQkFScyBhcmUgb25seSBhbGlnbmVkIHRvIGl0J3Mgc2l6 ZSwgc28gQkFScyBzbWFsbGVyIHRoYW4gNEsgYXJlIG5vdAo+IHJlcXVpcmVkIHRvIGJlIHBhZ2Ug YWxpZ25lZC4KCklmIHdlIGhhZCBhIG5vdGlvbiBvZiBhc3NpZ25tZW50IGdyb3VwcyBmb3IgdGhp cywgYXMgd2VsbCBhcyBkZXZpY2VzIHNoYXJpbmcgcmVxdWVzdGVyIGlkLCB0aGVuIFhlbiB3b3Vs ZCBub3QgbmVlZCB0byByZWZ1c2UgcGFzcy10aHJvdWdoLCBpdCB3b3VsZCBqdXN0IHJlcXVpcmUg dGhhdCBhbGwgZGV2aWNlcyBzaGFyaW5nIHRoZSBwYWdlIHdlcmUgcGFzc2VkIHRocm91Z2ggYXMg YSB1bml0LgoKICBQYXVsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0 Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRl dmVs