From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 156DDCCA47C for ; Thu, 23 Jun 2022 20:20:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229718AbiFWUT7 (ORCPT ); Thu, 23 Jun 2022 16:19:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229451AbiFWUT6 (ORCPT ); Thu, 23 Jun 2022 16:19:58 -0400 Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8164128723; Thu, 23 Jun 2022 13:19:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1656015566; bh=7z0s+WHf2+v1qxr7m1rw9SjbVWQ/P3W5Q+Q8hQUhFL4=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=QtTskdiVf9SnLc0VDy0EIhIbvpMEzrUAMWnmUFkmkUODhMQ/kqzxpJQVzZsHpBX89 kCFS99QVz5o6YiBoT++oDJplAkjhZPv3AeBAgMSNGdOdtrU+5tCV/z6pnf/zKBNZiz cjYEO5nRUkXUaQEGqMKQ/UWOw5/htUwm/b9qIvUE= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.0.33] ([46.223.3.134]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MplXp-1nJMNn1pnR-00q9Ow; Thu, 23 Jun 2022 22:19:26 +0200 Subject: Re: [PATCH 1/8] serial: core: only get RS485 termination gpio if supported To: Andy Shevchenko Cc: Greg Kroah-Hartman , Jiri Slaby , =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= , Rob Herring , Krzysztof Kozlowski , Vladimir Zapolskiy , linux-arm Mailing List , devicetree , "open list:SERIAL DRIVERS" , Linux Kernel Mailing List , Lukas Wunner , p.rosenberger@kunbus.com, Lino Sanfilippo References: <20220622154659.8710-1-LinoSanfilippo@gmx.de> <20220622154659.8710-2-LinoSanfilippo@gmx.de> <2dda5707-6f13-6d33-863d-a88b89e88a88@gmx.de> <52ea773c-b5b0-fc4d-9b85-022676778af7@gmx.de> From: Lino Sanfilippo Message-ID: Date: Thu, 23 Jun 2022 22:19:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:R+h3v9u71I2BMWiuwJYl5ijLux5TSOJmiFNOdVkiUBhncJoBYBj Rpba1VLsz5PHFzMjtBa1BsosaVGfcUk1ZECJJOlVS4qskkA5UY/GboaENpFRfKFWsxMBvd9 91FcB4CF+HNLwr8+H2xoEBkMJY56ompf3/WhsPfqj3qGjPuquDLrVq2Lmfm1vXqwHiAx345 xPfK2FSueTie/lNWc0DiQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:ypiX5zbmpH8=:3CTlB2vV9+v2noZpkCw0V2 1ToshIfaQqtoMscI0pX4QT62ADYtN+IpTCk2i7BkrnHytxC7icSm1HWVYvJwdoKZwhyW9SRp0 xfqEHnzToVVi7We2Y+xv4O855spRcG0Y9KDFOVBuC0PZT3UZwr5zel2fNJJ63a13PcNaTvOnX tlMZlW4ogqyGCrkBeRlwNXRa6xG8iEZEWQHALl1mHRRcSZKQAKQ2NAQN/+sK332zRVROiXJHs ycPqL9BJ0/bH/HxY1nWdaT1Iq44oH2PKLOa3Tpgw5t82OzexUIOF2/YmS20KINt5HAaavOsu8 ugSfRP99tjSz/1ZHrzq6mfFNxsniw2r/UG36ORQwCLezs4sGG2k3XJkX0S+51xwIA1tlwMTK8 FxbSmkHGg1+A8QPutHq4ia3Tb0MQQ5ZqM/GMNgzadlr6lax0J2Q/hiRF/U6a6yPx5iNXqeU90 kMxgZqOU3cbZqnZW+OGNrjbIG2h5nS5/YB6zVWji/p3fphtfL92u/lSfHvxHk1thsV7AksN+C xsn/5z9ipZo50IHuxYCzpHfYmYxpv7VEhfnP5lBsp0GaqWSVCBHXDooFK5Rxh1uqU1foPZ68t CSH2TLnBrZ9XOofredqSdV5NcY0myIxfLJ4FOr4FKoMKSTQA9j8iDdoNkgzl1WMNyfNDF/Ids NHDPssN8+4axOHqWt6Vvh3aXpvomN+NCowaYBrUle20g49spd7I/tLGGFDDXkQLUoE07jn6NZ 1PE/2dy9ZVrzNYpCD+rCAllqrP9wT9Shm3eAIAtLit1+1+YWSbAB2QQ8yYB/+B1EuMPgS4iRu wiypOa1DvVby8APC0n775tUZYsXAvlpah0iMrEA9+mO8pSFOUCr1nmIS0vTD/It5kdG+g4VPw LTQYhDotdZYbL5pekeP1pQPhO4hzE1lwgIddL4xFyTM53QKp87QCUjCy2uHe+EwerKDk+Q4Pc mG2G2LhXOhjVdRcvPrft8flDrVE1WPnn4yaTcDMvwSgOHwz8QJ+nOOsWU1J4oUMTcv1ifjzJv GGnyzzdpKaRxCKD+qm2ozFYQsF1jxxzKgA5mZiiV/rdeNWOzpx0t5GUGpoxNGB0fVAzF128b4 NE6awCfFITxHdB11Xh0DxC0f2HgzcllNK69RBsP/yOJIux8TkGhahtS1Q== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23.06.22 at 18:32, Andy Shevchenko wrote: >> >> Ok I see the point. So what about changing it to: > > You mean adding below after the existing code in the module? Right, to be more precise between getting the gpio and the error check: port->rs485_term_gpio =3D devm_gpiod_get_optional(dev, "rs485-term", GPIOD_OUT_LOW); if (port->rs485_term_gpio && !(port->rs485_supported->flags & SER_RS485_TERMINATE_BUS)) { dev_warn(port->dev, "%s (%d): RS485 termination gpio not supported by driver\n", port->name, port->line); devm_gpiod_put(dev, port->rs485_term_gpio); port->rs485_term_gpio =3D NULL; } if (IS_ERR(port->rs485_term_gpio)) { ret =3D PTR_ERR(port->rs485_term_gpio); port->rs485_term_gpio =3D NULL; return dev_err_probe(dev, ret, "Cannot get rs485-term-gpios\n"); } Regards, Lino > >> if (port->rs485_term_gpio && >> !(port->rs485_supported->flags & SER_RS485_TERMINATE_BUS)) { >> dev_warn(port->dev, >> "%s (%d): RS485 termination gpio not supported by driver\n", >> port->name, port->line); >> devm_gpiod_put(dev, port->rs485_term_gpio); >> port->rs485_term_gpio =3D NULL; >> } >> >> This would also be consistent to the warnings we print in uart_sanitize= _serial_rs485() for invalid >> RS485 settings. > > Probably it's okay, but I dunno we have much on this to gain. Users may = start > complaining of this (harmless) warning. I leave it to others to comment. > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3358EC43334 for ; Thu, 23 Jun 2022 20:20:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=ce5AWHJoLIkPpXo6o4142dyOe7i6ioT2QHGQfDuaecM=; b=Vae3NQdw5X02q/NcmPIAVnwPrT TZ0elWEst2p+b1ZkGl7dh9CTt4l6P9XTC0mLIiiG+85AVuMNpNEjcrfU8jknsHASTTqkfhfbnfsqL 23pHlftWLFO2wrPpQ989IdWKa2wWR5iQx8Ydt+/hrgrZ/YhpVSCdNZG4Nf61KxVdzk/xPMTT5mFC2 5ih6nMZgQjEDXxKbUbVr4TNdravR+nWt9vUuHk6A9ETEp3651nuMbQatzMtwYErqje0dW03dKoMT2 E1vk9D0+CsARCKUNAuHiKfjLlS/fkNWvRqCeVp38GA0KmaDoMME0OEVrGoeW6q+iF8Z6PZ4xHcmus uoHSAx/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4TIv-00Gib0-PS; Thu, 23 Jun 2022 20:19:53 +0000 Received: from mout.gmx.net ([212.227.17.20]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4TIs-00GiZw-GM for linux-arm-kernel@lists.infradead.org; Thu, 23 Jun 2022 20:19:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1656015566; bh=7z0s+WHf2+v1qxr7m1rw9SjbVWQ/P3W5Q+Q8hQUhFL4=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=QtTskdiVf9SnLc0VDy0EIhIbvpMEzrUAMWnmUFkmkUODhMQ/kqzxpJQVzZsHpBX89 kCFS99QVz5o6YiBoT++oDJplAkjhZPv3AeBAgMSNGdOdtrU+5tCV/z6pnf/zKBNZiz cjYEO5nRUkXUaQEGqMKQ/UWOw5/htUwm/b9qIvUE= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.0.33] ([46.223.3.134]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MplXp-1nJMNn1pnR-00q9Ow; Thu, 23 Jun 2022 22:19:26 +0200 Subject: Re: [PATCH 1/8] serial: core: only get RS485 termination gpio if supported To: Andy Shevchenko Cc: Greg Kroah-Hartman , Jiri Slaby , =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= , Rob Herring , Krzysztof Kozlowski , Vladimir Zapolskiy , linux-arm Mailing List , devicetree , "open list:SERIAL DRIVERS" , Linux Kernel Mailing List , Lukas Wunner , p.rosenberger@kunbus.com, Lino Sanfilippo References: <20220622154659.8710-1-LinoSanfilippo@gmx.de> <20220622154659.8710-2-LinoSanfilippo@gmx.de> <2dda5707-6f13-6d33-863d-a88b89e88a88@gmx.de> <52ea773c-b5b0-fc4d-9b85-022676778af7@gmx.de> From: Lino Sanfilippo Message-ID: Date: Thu, 23 Jun 2022 22:19:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Provags-ID: V03:K1:R+h3v9u71I2BMWiuwJYl5ijLux5TSOJmiFNOdVkiUBhncJoBYBj Rpba1VLsz5PHFzMjtBa1BsosaVGfcUk1ZECJJOlVS4qskkA5UY/GboaENpFRfKFWsxMBvd9 91FcB4CF+HNLwr8+H2xoEBkMJY56ompf3/WhsPfqj3qGjPuquDLrVq2Lmfm1vXqwHiAx345 xPfK2FSueTie/lNWc0DiQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:ypiX5zbmpH8=:3CTlB2vV9+v2noZpkCw0V2 1ToshIfaQqtoMscI0pX4QT62ADYtN+IpTCk2i7BkrnHytxC7icSm1HWVYvJwdoKZwhyW9SRp0 xfqEHnzToVVi7We2Y+xv4O855spRcG0Y9KDFOVBuC0PZT3UZwr5zel2fNJJ63a13PcNaTvOnX tlMZlW4ogqyGCrkBeRlwNXRa6xG8iEZEWQHALl1mHRRcSZKQAKQ2NAQN/+sK332zRVROiXJHs ycPqL9BJ0/bH/HxY1nWdaT1Iq44oH2PKLOa3Tpgw5t82OzexUIOF2/YmS20KINt5HAaavOsu8 ugSfRP99tjSz/1ZHrzq6mfFNxsniw2r/UG36ORQwCLezs4sGG2k3XJkX0S+51xwIA1tlwMTK8 FxbSmkHGg1+A8QPutHq4ia3Tb0MQQ5ZqM/GMNgzadlr6lax0J2Q/hiRF/U6a6yPx5iNXqeU90 kMxgZqOU3cbZqnZW+OGNrjbIG2h5nS5/YB6zVWji/p3fphtfL92u/lSfHvxHk1thsV7AksN+C xsn/5z9ipZo50IHuxYCzpHfYmYxpv7VEhfnP5lBsp0GaqWSVCBHXDooFK5Rxh1uqU1foPZ68t CSH2TLnBrZ9XOofredqSdV5NcY0myIxfLJ4FOr4FKoMKSTQA9j8iDdoNkgzl1WMNyfNDF/Ids NHDPssN8+4axOHqWt6Vvh3aXpvomN+NCowaYBrUle20g49spd7I/tLGGFDDXkQLUoE07jn6NZ 1PE/2dy9ZVrzNYpCD+rCAllqrP9wT9Shm3eAIAtLit1+1+YWSbAB2QQ8yYB/+B1EuMPgS4iRu wiypOa1DvVby8APC0n775tUZYsXAvlpah0iMrEA9+mO8pSFOUCr1nmIS0vTD/It5kdG+g4VPw LTQYhDotdZYbL5pekeP1pQPhO4hzE1lwgIddL4xFyTM53QKp87QCUjCy2uHe+EwerKDk+Q4Pc mG2G2LhXOhjVdRcvPrft8flDrVE1WPnn4yaTcDMvwSgOHwz8QJ+nOOsWU1J4oUMTcv1ifjzJv GGnyzzdpKaRxCKD+qm2ozFYQsF1jxxzKgA5mZiiV/rdeNWOzpx0t5GUGpoxNGB0fVAzF128b4 NE6awCfFITxHdB11Xh0DxC0f2HgzcllNK69RBsP/yOJIux8TkGhahtS1Q== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220623_131950_872759_734B7E8C X-CRM114-Status: GOOD ( 13.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23.06.22 at 18:32, Andy Shevchenko wrote: >> >> Ok I see the point. So what about changing it to: > > You mean adding below after the existing code in the module? Right, to be more precise between getting the gpio and the error check: port->rs485_term_gpio = devm_gpiod_get_optional(dev, "rs485-term", GPIOD_OUT_LOW); if (port->rs485_term_gpio && !(port->rs485_supported->flags & SER_RS485_TERMINATE_BUS)) { dev_warn(port->dev, "%s (%d): RS485 termination gpio not supported by driver\n", port->name, port->line); devm_gpiod_put(dev, port->rs485_term_gpio); port->rs485_term_gpio = NULL; } if (IS_ERR(port->rs485_term_gpio)) { ret = PTR_ERR(port->rs485_term_gpio); port->rs485_term_gpio = NULL; return dev_err_probe(dev, ret, "Cannot get rs485-term-gpios\n"); } Regards, Lino > >> if (port->rs485_term_gpio && >> !(port->rs485_supported->flags & SER_RS485_TERMINATE_BUS)) { >> dev_warn(port->dev, >> "%s (%d): RS485 termination gpio not supported by driver\n", >> port->name, port->line); >> devm_gpiod_put(dev, port->rs485_term_gpio); >> port->rs485_term_gpio = NULL; >> } >> >> This would also be consistent to the warnings we print in uart_sanitize_serial_rs485() for invalid >> RS485 settings. > > Probably it's okay, but I dunno we have much on this to gain. Users may start > complaining of this (harmless) warning. I leave it to others to comment. > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel