From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49586C433EF for ; Wed, 1 Jun 2022 13:37:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232808AbiFANhA (ORCPT ); Wed, 1 Jun 2022 09:37:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351697AbiFANg7 (ORCPT ); Wed, 1 Jun 2022 09:36:59 -0400 Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A39FF42A03 for ; Wed, 1 Jun 2022 06:36:57 -0700 (PDT) Received: from [192.168.1.107] ([37.4.249.170]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MG9Pg-1o1s5C0E8K-00GWzX; Wed, 01 Jun 2022 15:31:26 +0200 Message-ID: Date: Wed, 1 Jun 2022 15:31:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH V2 00/11] soc: bcm2835-power: Prepare BCM2711 V3D support Content-Language: en-US To: Peter Robinson Cc: Florian Fainelli , Ray Jui , Scott Branden , Nicolas Saenz Julienne , Lee Jones , Melissa Wen , Phil Elwell , bcm-kernel-feedback-list@broadcom.com, Maxime Ripard , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20220601125344.60602-1-stefan.wahren@i2se.com> From: Stefan Wahren In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:ygkULSg3qSLX+B1Fa7xSqBvlg6oiF2sf/WyeC80LKPH4pkhcuGl 5P42yL3CVXG3A83nRymYAWTVV2MW31pQk/HA6Y+TKOFGWMYXBU3Az0kbQnm/88V28CeRsp3 rsZxs7VsKSQHgCV/MFeRNfkq8N0ZM7NVdLZqcv7Udj5u28Jf4LIdG/80DTKKde7XrVcVFb9 IUFOcbFLyXqZnzckHzxuA== X-UI-Out-Filterresults: notjunk:1;V03:K0:HhkUv1CMDxk=:5n6VmWDKoOiFpeTNOBZYHb UPyU8wK5gJy+apYXXcY2JJ1ntD022QLwcHfxi2SB/eIwq6vYzp+bXPFAvD5SGorU3BqBXxm/+ gbkjhYM1uE4/HJ77b/UXh6WJA4iaWec4kEsl+STGgvuHRgjr+V25cFSlNo8i3i6Ym+nrt+bx+ crdNhzbTfVCIchaTIzuU4WsK70yCS4qOYKILVNga1c9tppWpHPtCBImADjGMKE7LhdpI8Iikq yTqF4H7W3blSOwD31u1P9fCNAiJGDbMpTlPlQYtxKfRwGNxJ7v4BVy3ZeL9wdmY4mPmlC/Xq8 OsJAOcgKLVZs+wwUU7hc+XZW/pxYH8CHbLVZhOnQ7VeR4Evq41GKvDvxoZu8YBBevZEouRZ9d E6jW5doD0vZCJBXUUMHmQqoDa9sQHyqU6FmQOhHZkXk7vC0jr/u8L8p3Bioyol/8xMn73ZuwO ocuN6w8wAud7Es4SGm8gpk4b14BHul04zeXgCqpUNZwc4U2h6U2RMHl34f4GURvj5sx+habb/ zQ7wnHBj2btH8CJZfzNo6ZK3cPuyWylt9/pPArDGraDXhttqHR9dXYQhopktdUugaAWnaPL4e GwoCVvNXB0kBwSpH2MAThPpGQHqFW5VpE07G5uIEfAKfkMZAK3BErcT6wRu4NVL6QBHVjIF4X ozvYliisOHK9BEhPaOh4spCMuyPg2BDYEmeinG+Zm+YQLpzI/MS+QVyAHOL3UwgLKZUrDq9A1 1HW3W8VBCkOk8sN0BjP/FJcPuyAASC9M3RCFP+R7t5EjkTCShUiDtHQU8ms= Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Peter, Am 01.06.22 um 15:19 schrieb Peter Robinson: > Hi Stefan, > > So I've done some basic boot testing on a rpi4b, rpi4b 8gb, rpi400, > rpi3b+ and rpi zero2w but all headless/remote, overall it looks good. > I'm back home tomorrow when I can test the rpi4 series with the GPU > patches on top with full desktop/display but overall this looks fab! Thanks a lot for review and testing. Stefan > > Peter > >> This series is a split out of version 4 - Raspberry PI 4 V3D enablement send >> by Peter Robinson [1]. It attemps to enable BCM2711 V3D support for the >> power management driver. It's a rework of the less controversial changes >> (excluding V3D GPU driver changes) so this can be reviewed and applied faster. >> >> Changes in V2: >> - add Peter's Reviewed-by >> - simplify schema for rpivid_asb as suggested by Rob >> - fix reference and clarify fallback & error handling in patch #7 >> - drop unnecessary newline in patch #9 >> - improve log messages as noticed by Peter >> >> Changes since the mention series: >> - fix DT schema errors >> - make rpivid_asb register optional in DT schema >> - avoid code duplication in BCM2835 ASB enable/disable >> - rework ASB V3D handling so we don't need the V3D flag >> - avoid log errors for optional register >> - use a define for expected ASB_AXI_BRDG_ID result >> - fix copy & paste issues in bcm2835-pm changes >> >> [1] - https://patchwork.kernel.org/project/linux-arm-kernel/cover/20220213225646.67761-1-pbrobinson@gmail.com/ >> >> Nicolas Saenz Julienne (6): >> dt-bindings: soc: bcm: bcm2835-pm: Convert bindings to DT schema >> dt-bindings: soc: bcm: bcm2835-pm: Introduce reg-names >> ARM: dts: bcm2835/bcm2711: Introduce reg-names in watchdog node >> ARM: dts: bcm2711: Use proper compatible in PM/Watchdog node >> mfd: bcm2835-pm: Use 'reg-names' to get resources >> soc: bcm: bcm2835-power: Bypass power_on/off() calls >> >> Stefan Wahren (5): >> dt-bindings: soc: bcm: bcm2835-pm: Add support for bcm2711 >> mfd: bcm2835-pm: Add support for BCM2711 >> soc: bcm: bcm2835-power: Refactor ASB control >> soc: bcm: bcm2835-power: Resolve ASB register macros >> soc: bcm: bcm2835-power: Add support for BCM2711's RPiVid ASB >> >> .../bindings/soc/bcm/brcm,bcm2835-pm.txt | 46 ---------- >> .../bindings/soc/bcm/brcm,bcm2835-pm.yaml | 86 +++++++++++++++++++ >> arch/arm/boot/dts/bcm2711.dtsi | 3 +- >> arch/arm/boot/dts/bcm2835-common.dtsi | 1 + >> drivers/mfd/bcm2835-pm.c | 80 +++++++++++++---- >> drivers/soc/bcm/bcm2835-power.c | 72 ++++++++++------ >> include/linux/mfd/bcm2835-pm.h | 1 + >> 7 files changed, 199 insertions(+), 90 deletions(-) >> delete mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.txt >> create mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml >> >> -- >> 2.25.1 >> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 93A06C433F5 for ; Wed, 1 Jun 2022 13:38:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=p+P0ryfC7er6rqu/gPJYWcN9U6Y8Yn57T72BT4rZ8Sw=; b=tJaOPOOd7JbBQR k+VfDC3fs5C/q9WAynZusyEFdxgWxRawX0sgC7Hthqa6byeiOgUAMDxuNWfonARfcvCw6UDPOm1BH rwn/JN3zFhC7QjvsbzbCopzoDURdSKjKbybqk56PwJ1YDW1ng4Frb5eFbMxYzQah0CB1Jhs6YHb2l pwK4dAPfhBk7c71YmRb+RZWNKnwyW9/QOr+PdS7fCKCV9oUgq0Q5Z6SXD3yX1+SiVXbuxpVboO642 /iz8+3Hkegt8Msr7qUB3TQi5mBc8cZox9Ory3X4XPNRIYhzv95vbK1ubT1AsXqfRoh+KtN4Kh3AEe mhue9d0u5AF6ETv54eVQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwOWv-00GJ4w-Ij; Wed, 01 Jun 2022 13:36:57 +0000 Received: from mout.kundenserver.de ([212.227.126.134]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwOWr-00GJ40-Pb for linux-arm-kernel@lists.infradead.org; Wed, 01 Jun 2022 13:36:55 +0000 Received: from [192.168.1.107] ([37.4.249.170]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MG9Pg-1o1s5C0E8K-00GWzX; Wed, 01 Jun 2022 15:31:26 +0200 Message-ID: Date: Wed, 1 Jun 2022 15:31:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH V2 00/11] soc: bcm2835-power: Prepare BCM2711 V3D support Content-Language: en-US To: Peter Robinson Cc: Florian Fainelli , Ray Jui , Scott Branden , Nicolas Saenz Julienne , Lee Jones , Melissa Wen , Phil Elwell , bcm-kernel-feedback-list@broadcom.com, Maxime Ripard , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20220601125344.60602-1-stefan.wahren@i2se.com> From: Stefan Wahren In-Reply-To: X-Provags-ID: V03:K1:ygkULSg3qSLX+B1Fa7xSqBvlg6oiF2sf/WyeC80LKPH4pkhcuGl 5P42yL3CVXG3A83nRymYAWTVV2MW31pQk/HA6Y+TKOFGWMYXBU3Az0kbQnm/88V28CeRsp3 rsZxs7VsKSQHgCV/MFeRNfkq8N0ZM7NVdLZqcv7Udj5u28Jf4LIdG/80DTKKde7XrVcVFb9 IUFOcbFLyXqZnzckHzxuA== X-UI-Out-Filterresults: notjunk:1;V03:K0:HhkUv1CMDxk=:5n6VmWDKoOiFpeTNOBZYHb UPyU8wK5gJy+apYXXcY2JJ1ntD022QLwcHfxi2SB/eIwq6vYzp+bXPFAvD5SGorU3BqBXxm/+ gbkjhYM1uE4/HJ77b/UXh6WJA4iaWec4kEsl+STGgvuHRgjr+V25cFSlNo8i3i6Ym+nrt+bx+ crdNhzbTfVCIchaTIzuU4WsK70yCS4qOYKILVNga1c9tppWpHPtCBImADjGMKE7LhdpI8Iikq yTqF4H7W3blSOwD31u1P9fCNAiJGDbMpTlPlQYtxKfRwGNxJ7v4BVy3ZeL9wdmY4mPmlC/Xq8 OsJAOcgKLVZs+wwUU7hc+XZW/pxYH8CHbLVZhOnQ7VeR4Evq41GKvDvxoZu8YBBevZEouRZ9d E6jW5doD0vZCJBXUUMHmQqoDa9sQHyqU6FmQOhHZkXk7vC0jr/u8L8p3Bioyol/8xMn73ZuwO ocuN6w8wAud7Es4SGm8gpk4b14BHul04zeXgCqpUNZwc4U2h6U2RMHl34f4GURvj5sx+habb/ zQ7wnHBj2btH8CJZfzNo6ZK3cPuyWylt9/pPArDGraDXhttqHR9dXYQhopktdUugaAWnaPL4e GwoCVvNXB0kBwSpH2MAThPpGQHqFW5VpE07G5uIEfAKfkMZAK3BErcT6wRu4NVL6QBHVjIF4X ozvYliisOHK9BEhPaOh4spCMuyPg2BDYEmeinG+Zm+YQLpzI/MS+QVyAHOL3UwgLKZUrDq9A1 1HW3W8VBCkOk8sN0BjP/FJcPuyAASC9M3RCFP+R7t5EjkTCShUiDtHQU8ms= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220601_063654_171905_E7499472 X-CRM114-Status: GOOD ( 19.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Peter, Am 01.06.22 um 15:19 schrieb Peter Robinson: > Hi Stefan, > > So I've done some basic boot testing on a rpi4b, rpi4b 8gb, rpi400, > rpi3b+ and rpi zero2w but all headless/remote, overall it looks good. > I'm back home tomorrow when I can test the rpi4 series with the GPU > patches on top with full desktop/display but overall this looks fab! Thanks a lot for review and testing. Stefan > > Peter > >> This series is a split out of version 4 - Raspberry PI 4 V3D enablement send >> by Peter Robinson [1]. It attemps to enable BCM2711 V3D support for the >> power management driver. It's a rework of the less controversial changes >> (excluding V3D GPU driver changes) so this can be reviewed and applied faster. >> >> Changes in V2: >> - add Peter's Reviewed-by >> - simplify schema for rpivid_asb as suggested by Rob >> - fix reference and clarify fallback & error handling in patch #7 >> - drop unnecessary newline in patch #9 >> - improve log messages as noticed by Peter >> >> Changes since the mention series: >> - fix DT schema errors >> - make rpivid_asb register optional in DT schema >> - avoid code duplication in BCM2835 ASB enable/disable >> - rework ASB V3D handling so we don't need the V3D flag >> - avoid log errors for optional register >> - use a define for expected ASB_AXI_BRDG_ID result >> - fix copy & paste issues in bcm2835-pm changes >> >> [1] - https://patchwork.kernel.org/project/linux-arm-kernel/cover/20220213225646.67761-1-pbrobinson@gmail.com/ >> >> Nicolas Saenz Julienne (6): >> dt-bindings: soc: bcm: bcm2835-pm: Convert bindings to DT schema >> dt-bindings: soc: bcm: bcm2835-pm: Introduce reg-names >> ARM: dts: bcm2835/bcm2711: Introduce reg-names in watchdog node >> ARM: dts: bcm2711: Use proper compatible in PM/Watchdog node >> mfd: bcm2835-pm: Use 'reg-names' to get resources >> soc: bcm: bcm2835-power: Bypass power_on/off() calls >> >> Stefan Wahren (5): >> dt-bindings: soc: bcm: bcm2835-pm: Add support for bcm2711 >> mfd: bcm2835-pm: Add support for BCM2711 >> soc: bcm: bcm2835-power: Refactor ASB control >> soc: bcm: bcm2835-power: Resolve ASB register macros >> soc: bcm: bcm2835-power: Add support for BCM2711's RPiVid ASB >> >> .../bindings/soc/bcm/brcm,bcm2835-pm.txt | 46 ---------- >> .../bindings/soc/bcm/brcm,bcm2835-pm.yaml | 86 +++++++++++++++++++ >> arch/arm/boot/dts/bcm2711.dtsi | 3 +- >> arch/arm/boot/dts/bcm2835-common.dtsi | 1 + >> drivers/mfd/bcm2835-pm.c | 80 +++++++++++++---- >> drivers/soc/bcm/bcm2835-power.c | 72 ++++++++++------ >> include/linux/mfd/bcm2835-pm.h | 1 + >> 7 files changed, 199 insertions(+), 90 deletions(-) >> delete mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.txt >> create mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml >> >> -- >> 2.25.1 >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel