From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FA6BC4332D for ; Fri, 5 Mar 2021 10:53:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EC16565017 for ; Fri, 5 Mar 2021 10:53:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229674AbhCEKw3 (ORCPT ); Fri, 5 Mar 2021 05:52:29 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:50832 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229558AbhCEKv6 (ORCPT ); Fri, 5 Mar 2021 05:51:58 -0500 Received: from mail-wr1-f72.google.com ([209.85.221.72]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lI83p-0000iP-20 for linux-kernel@vger.kernel.org; Fri, 05 Mar 2021 10:51:57 +0000 Received: by mail-wr1-f72.google.com with SMTP id x9so882166wro.9 for ; Fri, 05 Mar 2021 02:51:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=T/nIKyVeLDjnLO0XxbWZvWwMQYyfC7R4FZ0wj435gLk=; b=NXIg+WEuCIMa9zFdjG93DC5VnAseIJXadSZcSm/8aDZ4DTEl9n4BGZjVhpotEvg0k9 suqqg/HTXQMJzZQVbo3++bZ/5U/PrH49MI2UkCIHwLeEq5IBe6TDbuz/qnUCZD9gNoie 0buVejHosECFAoHlQ6G1Fzd6nnQbRcvDSiYKONhajYte9EDv/vRSHDVQQC8ngDAR0JKK dezY+R6FdAmFzMokIm+UsP/zBLLusOf6ioyl12ARB/rETcXqD3wizE9mWSZSk6YprPeg ZTluUEjoW9VBl91/pO8KafWviNNno2KbCCNZN5uFfSkaanO/pSMY2CIJfN9UQlRRSqO/ yIrQ== X-Gm-Message-State: AOAM531hkTvqi/XGLi23u/BuXgCu/PbrDTSz5UX0flYUxixCiqzs5G1a crqcot/26/qKnwb7am9X/S6rL6Q2Di6FnySeWzN/0CnO+I9g1eUmRR2wEFk6zsGuJYOlRR2xyZq xMcrgsHMy1QEXihBc2aDFILKvr88fXBYaxXdiJf2gOA== X-Received: by 2002:a05:6000:181b:: with SMTP id m27mr8873173wrh.363.1614941516466; Fri, 05 Mar 2021 02:51:56 -0800 (PST) X-Google-Smtp-Source: ABdhPJwSLx+ynSvyErVHtHDHShr+sqcaIVDFi0ZCngX/tDgR4DOKXKtYquKT+n+xo53Vaj5WTHxikg== X-Received: by 2002:a05:6000:181b:: with SMTP id m27mr8873154wrh.363.1614941516303; Fri, 05 Mar 2021 02:51:56 -0800 (PST) Received: from [192.168.1.116] (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.gmail.com with ESMTPSA id l21sm2344908wmg.41.2021.03.05.02.51.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Mar 2021 02:51:56 -0800 (PST) Subject: Re: [RFT PATCH v3 21/27] tty: serial: samsung_tty: IRQ rework To: Hector Martin , linux-arm-kernel@lists.infradead.org Cc: Marc Zyngier , Rob Herring , Arnd Bergmann , Olof Johansson , Mark Kettenis , Tony Lindgren , Mohamed Mediouni , Stan Skowronek , Alexander Graf , Will Deacon , Linus Walleij , Mark Rutland , Andy Shevchenko , Greg Kroah-Hartman , Jonathan Corbet , Catalin Marinas , Christoph Hellwig , "David S. Miller" , devicetree@vger.kernel.org, linux-serial@vger.kernel.org, linux-doc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210304213902.83903-1-marcan@marcan.st> <20210304213902.83903-22-marcan@marcan.st> From: Krzysztof Kozlowski Message-ID: Date: Fri, 5 Mar 2021 11:51:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210304213902.83903-22-marcan@marcan.st> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/03/2021 22:38, Hector Martin wrote: > * Split out s3c24xx_serial_tx_chars from s3c24xx_serial_tx_irq, > where only the latter acquires the port lock. This will be necessary > on platforms which have edge-triggered IRQs, as we need to call > s3c24xx_serial_tx_chars to kick off transmission from outside IRQ > context, with the port lock held. > > * Rename s3c24xx_serial_rx_chars to s3c24xx_serial_rx_irq for > consistency with the above. All it does now is call two other > functions anyway. > > Signed-off-by: Hector Martin > --- > drivers/tty/serial/samsung_tty.c | 34 +++++++++++++++++++------------- > 1 file changed, 20 insertions(+), 14 deletions(-) > Reviewed-by: Krzysztof Kozlowski Tested-by: Krzysztof Kozlowski Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F8E7C433E6 for ; Fri, 5 Mar 2021 10:55:00 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6F32B64FD6 for ; Fri, 5 Mar 2021 10:54:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6F32B64FD6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8Td3b3kX8jUVi85bPP0rLvT8bx4iM0bfhEEpRVvYZkA=; b=gaAv736QDtlx9qNtT9kKyvd+D XTFChX/ELrhY4WQ5QH+n1rb4nchwcI+sh1ZiWBkKbtWP5WAZh71mFYa9wLzfnqcDhoVY+xpLUBvaF l5IfgAcbCvQziNAB1SnojQf1b2DA2u86crs4URMprfm7ROjeARsv7j3EB6/dp+BceWrSLwWIQCuYO fN3sqTLk8gYoN4KzG19qutXEXfGIPCwXA8JMMbCJSYWWZbZdHpXXrEBSkkdlH2hOEXvWlVEZYl4H9 JGnH3hqnQCS5/Zgei1IuYDkogJTGMat8AsDebs8DPq9JT0OTseofvjfFQ8T95d3OU/obxxwEgHkqF pvKIhxj2Q==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lI844-00Edee-J0; Fri, 05 Mar 2021 10:52:13 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lI83p-00Edcb-K1 for linux-arm-kernel@lists.infradead.org; Fri, 05 Mar 2021 10:52:01 +0000 Received: from mail-wr1-f72.google.com ([209.85.221.72]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lI83o-0000iD-R7 for linux-arm-kernel@lists.infradead.org; Fri, 05 Mar 2021 10:51:56 +0000 Received: by mail-wr1-f72.google.com with SMTP id i5so893011wrp.8 for ; Fri, 05 Mar 2021 02:51:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=T/nIKyVeLDjnLO0XxbWZvWwMQYyfC7R4FZ0wj435gLk=; b=eYLYabPYfh4Dc/Gu9C99NEAJZuQfAe0qk3AnpIyypLohSLNFUak8/CGeDz090uJq6C Es664RZNGbVRXfrlTq68KBRuSsjJdWsrAqaa//wqsuF/3BF0o5OkQBsMDD1bX6chKodC p0LheT3m4WIPRtwOqsGOSXbnA1ECOZyj1QaAN2h3w/MFWukyCKeB7EE64LO023W4dtkY Qj/O/kMI6uiaagU+WWBbPQ89jUMYfZR+gOXXNMmA4ojPQ86yAUfrNfLu2wH0m+fMADP6 w/ghwHga2IQFVinVx9qtjdL7kmu0RdzEPJMEE+azo9rzDP0/dxSm1dj23KDSe5iZodDM TDqA== X-Gm-Message-State: AOAM533QrJ12Sbfmw7UOknBFYeYMavdmltSOhrxwg0JBxQoaJCyhG0Az GSYCGngLW6vZEpCb7Tpz731pun4fbHy2wYGM+3Ls5z0+NjDP+8I37qSHLKpyao0aKalTg7mx47K tNVhnHTUP7m0s0PHbOvAV/xjScLpKGCkaPLg7X0uFcrG8dLAaBT5k X-Received: by 2002:a05:6000:181b:: with SMTP id m27mr8873170wrh.363.1614941516466; Fri, 05 Mar 2021 02:51:56 -0800 (PST) X-Google-Smtp-Source: ABdhPJwSLx+ynSvyErVHtHDHShr+sqcaIVDFi0ZCngX/tDgR4DOKXKtYquKT+n+xo53Vaj5WTHxikg== X-Received: by 2002:a05:6000:181b:: with SMTP id m27mr8873154wrh.363.1614941516303; Fri, 05 Mar 2021 02:51:56 -0800 (PST) Received: from [192.168.1.116] (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.gmail.com with ESMTPSA id l21sm2344908wmg.41.2021.03.05.02.51.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Mar 2021 02:51:56 -0800 (PST) Subject: Re: [RFT PATCH v3 21/27] tty: serial: samsung_tty: IRQ rework To: Hector Martin , linux-arm-kernel@lists.infradead.org Cc: Marc Zyngier , Rob Herring , Arnd Bergmann , Olof Johansson , Mark Kettenis , Tony Lindgren , Mohamed Mediouni , Stan Skowronek , Alexander Graf , Will Deacon , Linus Walleij , Mark Rutland , Andy Shevchenko , Greg Kroah-Hartman , Jonathan Corbet , Catalin Marinas , Christoph Hellwig , "David S. Miller" , devicetree@vger.kernel.org, linux-serial@vger.kernel.org, linux-doc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210304213902.83903-1-marcan@marcan.st> <20210304213902.83903-22-marcan@marcan.st> From: Krzysztof Kozlowski Message-ID: Date: Fri, 5 Mar 2021 11:51:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210304213902.83903-22-marcan@marcan.st> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210305_105200_155177_7C3B93F5 X-CRM114-Status: GOOD ( 17.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 04/03/2021 22:38, Hector Martin wrote: > * Split out s3c24xx_serial_tx_chars from s3c24xx_serial_tx_irq, > where only the latter acquires the port lock. This will be necessary > on platforms which have edge-triggered IRQs, as we need to call > s3c24xx_serial_tx_chars to kick off transmission from outside IRQ > context, with the port lock held. > > * Rename s3c24xx_serial_rx_chars to s3c24xx_serial_rx_irq for > consistency with the above. All it does now is call two other > functions anyway. > > Signed-off-by: Hector Martin > --- > drivers/tty/serial/samsung_tty.c | 34 +++++++++++++++++++------------- > 1 file changed, 20 insertions(+), 14 deletions(-) > Reviewed-by: Krzysztof Kozlowski Tested-by: Krzysztof Kozlowski Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel