From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73D09C433EF for ; Fri, 18 Mar 2022 11:16:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234752AbiCRLRa (ORCPT ); Fri, 18 Mar 2022 07:17:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233440AbiCRLR3 (ORCPT ); Fri, 18 Mar 2022 07:17:29 -0400 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 003821C8874 for ; Fri, 18 Mar 2022 04:16:10 -0700 (PDT) Received: from dggpeml500021.china.huawei.com (unknown [172.30.72.57]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4KKhK313kgz1GCYg; Fri, 18 Mar 2022 19:16:07 +0800 (CST) Received: from dggpeml500017.china.huawei.com (7.185.36.243) by dggpeml500021.china.huawei.com (7.185.36.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Fri, 18 Mar 2022 19:16:08 +0800 Received: from [10.40.238.78] (10.40.238.78) by dggpeml500017.china.huawei.com (7.185.36.243) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Fri, 18 Mar 2022 19:16:08 +0800 Subject: Re: [PATCH for-next v4 05/12] RDMA/erdma: Add cmdq implementation To: Cheng Xu , , References: <20220314064739.81647-1-chengyou@linux.alibaba.com> <20220314064739.81647-6-chengyou@linux.alibaba.com> CC: , , , , From: Wenpeng Liang Message-ID: Date: Fri, 18 Mar 2022 19:16:08 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20220314064739.81647-6-chengyou@linux.alibaba.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.40.238.78] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpeml500017.china.huawei.com (7.185.36.243) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On 2022/3/14 14:47, Cheng Xu wrote: <...> > +int erdma_cmdq_init(struct erdma_dev *dev) > +{ > + int err, i; > + struct erdma_cmdq *cmdq = &dev->cmdq; > + u32 status, ctrl; Hi, Jason and Leon Defining and initializing variables in the form of an inverted triangle at the head of the function can make the code clearer. The kernel's coding-style does not specify this behavior, and the various kernel subsystems do not seem to have formed a unified opinion. Does our RDMA subsystem recommend this? struct erdma_cmdq *cmdq = &dev->cmdq; u32 status, ctrl; int err, i; Thanks, Wenpeng