From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 1/5] drm/i915: Remove stale asserts from i915_gem_find_active_request() Date: Wed, 30 May 2018 11:43:16 +0100 Message-ID: References: <20180529132922.6831-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 825C6739DB for ; Wed, 30 May 2018 10:43:19 +0000 (UTC) In-Reply-To: <20180529132922.6831-1-chris@chris-wilson.co.uk> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: Mika Kuoppala List-Id: intel-gfx@lists.freedesktop.org Ck9uIDI5LzA1LzIwMTggMTQ6MjksIENocmlzIFdpbHNvbiB3cm90ZToKPiBTaW5jZSB3ZSB1c2Ug aTkxNV9nZW1fZmluZF9hY3RpdmVfcmVxdWVzdCgpIGZyb20gaW5zaWRlCj4gaW50ZWxfZW5naW5l X2R1bXAoKSBhbmQgbWF5IGNhbGwgdGhhdCBhdCBhbnkgdGltZSwgd2UgZG8gbm90IGd1YXJhbnRl ZQo+IHRoYXQgdGhlIGVuZ2luZSBpcyBwYXVzZWQgbm9yIHRoYXQgdGhlIHNpZ25hbCBrdGhyZWFk cyBhbmQgaXJxIGhhbmRsZXIKPiBhcmUgc3VzcGVuZGVkLCBzbyB3ZSBjYW5ub3QgYXNzZXJ0IHRo YXQgdGhlIGJyZWFkY3J1bWIgZG9lc24ndCBhZHZhbmNlCj4gYW5kIHRoYXQgdGhlIGlycSBoYXNu J3QgaGFwcGVuZWQgb24gYW5vdGhlciBDUFUgc2lnbmFsaW5nIHRoZSByZXF1ZXN0IHdlCj4gYmVs aWV2ZSB0byBiZSBpZGxlLgo+IAo+IEZpeGVzOiBmNjM2ZWRiMjE0YTUgKCJkcm0vaTkxNTogTWFr ZSBpOTE1X2VuZ2luZV9pbmZvIHByZXR0eSBwcmludGVyIHRvIHN0YW5kYWxvbmUiKQo+IFNpZ25l ZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IENjOiBN aWthIEt1b3BwYWxhIDxtaWthLmt1b3BwYWxhQGludGVsLmNvbT4KPiBDYzogSm9vbmFzIExhaHRp bmVuIDxqb29uYXMubGFodGluZW5AbGludXguaW50ZWwuY29tPgo+IC0tLQo+ICAgZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9nZW0uYyB8IDE3ICsrKysrKysrLS0tLS0tLS0tCj4gICAxIGZpbGUg Y2hhbmdlZCwgOCBpbnNlcnRpb25zKCspLCA5IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9nZW0uYwo+IGluZGV4IDA1ZjQ0Y2EzNWEwNi4uNTMwZDZkMDEwOWI0IDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2dlbS5jCj4gQEAgLTI5NzIsMjMgKzI5NzIsMjIgQEAgaTkxNV9nZW1fZmlu ZF9hY3RpdmVfcmVxdWVzdChzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gICAJc3Ry dWN0IGk5MTVfcmVxdWVzdCAqcmVxdWVzdCwgKmFjdGl2ZSA9IE5VTEw7Cj4gICAJdW5zaWduZWQg bG9uZyBmbGFnczsKPiAgIAo+IC0JLyogV2UgYXJlIGNhbGxlZCBieSB0aGUgZXJyb3IgY2FwdHVy ZSBhbmQgcmVzZXQgYXQgYSByYW5kb20KPiAtCSAqIHBvaW50IGluIHRpbWUuIEluIHBhcnRpY3Vs YXIsIG5vdGUgdGhhdCBuZWl0aGVyIGlzIGNydWNpYWxseQo+IC0JICogb3JkZXJlZCB3aXRoIGFu IGludGVycnVwdC4gQWZ0ZXIgYSBoYW5nLCB0aGUgR1BVIGlzIGRlYWQgYW5kIHdlCj4gLQkgKiBh c3N1bWUgdGhhdCBubyBtb3JlIHdyaXRlcyBjYW4gaGFwcGVuICh3ZSB3YWl0ZWQgbG9uZyBlbm91 Z2ggZm9yCj4gLQkgKiBhbGwgd3JpdGVzIHRoYXQgd2VyZSBpbiB0cmFuc2FjdGlvbiB0byBiZSBm bHVzaGVkKSAtIGFkZGluZyBhbgo+ICsJLyoKPiArCSAqIFdlIGFyZSBjYWxsZWQgYnkgdGhlIGVy cm9yIGNhcHR1cmUsIHJlc2V0IGFuZCB0byBkdW1wIGVuZ2luZQo+ICsJICogc3RhdGUgYXQgcmFu ZG9tIHBvaW50cyBpbiB0aW1lLiBJbiBwYXJ0aWN1bGFyLCBub3RlIHRoYXQgbmVpdGhlciBpcwo+ ICsJICogY3J1Y2lhbGx5IG9yZGVyZWQgd2l0aCBhbiBpbnRlcnJ1cHQuIEFmdGVyIGEgaGFuZywg dGhlIEdQVSBpcyBkZWFkCj4gKwkgKiBhbmQgd2UgYXNzdW1lIHRoYXQgbm8gbW9yZSB3cml0ZXMg Y2FuIGhhcHBlbiAod2Ugd2FpdGVkIGxvbmcgZW5vdWdoCj4gKwkgKiBmb3IgYWxsIHdyaXRlcyB0 aGF0IHdlcmUgaW4gdHJhbnNhY3Rpb24gdG8gYmUgZmx1c2hlZCkgLSBhZGRpbmcgYW4KPiAgIAkg KiBleHRyYSBkZWxheSBmb3IgYSByZWNlbnQgaW50ZXJydXB0IGlzIHBvaW50bGVzcy4gSGVuY2Us IHdlIGRvCj4gICAJICogbm90IG5lZWQgYW4gZW5naW5lLT5pcnFfc2Vxbm9fYmFycmllcigpIGJl Zm9yZSB0aGUgc2Vxbm8gcmVhZHMuCj4gKwkgKiBBdCBhbGwgb3RoZXIgdGltZXMsIHdlIG11c3Qg YXNzdW1lIHRoZSBHUFUgaXMgc3RpbGwgcnVubmluZywgYnV0Cj4gKwkgKiB3ZSBvbmx5IGNhcmUg YWJvdXQgdGhlIHNuYXBzaG90IG9mIHRoaXMgbW9tZW50Lgo+ICAgCSAqLwo+ICAgCXNwaW5fbG9j a19pcnFzYXZlKCZlbmdpbmUtPnRpbWVsaW5lLmxvY2ssIGZsYWdzKTsKPiAgIAlsaXN0X2Zvcl9l YWNoX2VudHJ5KHJlcXVlc3QsICZlbmdpbmUtPnRpbWVsaW5lLnJlcXVlc3RzLCBsaW5rKSB7Cj4g ICAJCWlmIChfX2k5MTVfcmVxdWVzdF9jb21wbGV0ZWQocmVxdWVzdCwgcmVxdWVzdC0+Z2xvYmFs X3NlcW5vKSkKPiAgIAkJCWNvbnRpbnVlOwo+ICAgCj4gLQkJR0VNX0JVR19PTihyZXF1ZXN0LT5l bmdpbmUgIT0gZW5naW5lKTsKClJlbW92YWwgb2YgdGhpcyBvbmUgYmVsb25ncyB0byB2aXJ0dWFs IGVuZ2luZSBwZXJoYXBzPwoKUmVnYXJkcywKClR2cnRrbwoKPiAtCQlHRU1fQlVHX09OKHRlc3Rf Yml0KERNQV9GRU5DRV9GTEFHX1NJR05BTEVEX0JJVCwKPiAtCQkJCSAgICAmcmVxdWVzdC0+ZmVu Y2UuZmxhZ3MpKTsKPiAtCj4gICAJCWFjdGl2ZSA9IHJlcXVlc3Q7Cj4gICAJCWJyZWFrOwo+ICAg CX0KPiAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50 ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==