From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EF54C4332F for ; Mon, 23 May 2022 02:21:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351288AbiEWCVm (ORCPT ); Sun, 22 May 2022 22:21:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39368 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235254AbiEWCVj (ORCPT ); Sun, 22 May 2022 22:21:39 -0400 Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A72A0B874 for ; Sun, 22 May 2022 19:21:37 -0700 (PDT) Received: by mail-pg1-x535.google.com with SMTP id r71so12510521pgr.0 for ; Sun, 22 May 2022 19:21:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:to:cc:references :from:in-reply-to:content-transfer-encoding; bh=ftAlGkfVN9yFSMHjqy7cpbDkYMyhHDjfXWpCptFDTFo=; b=5ZfHbADabs94TwJ/7qwTLt2CQFczUjYovL6BMHmANuny7SYgbvOIrrYRILUThJn9sq e5qfNR/l4K6h8svb+auQZgVyvlGygBilUm09/AZMOyp1neoo8ub+9uWPBnDrkD9oLrmn yS3LSDeZZ7st/cOadWljRiZF2y/DrWsTb208bbRC2AnJy2IrM9owWxGPLKv4nbZAZHV0 621c5uRoXUUXfg2ALD7+dYqA7R+RLO8yb4dDZCkxDHPNmEvMzlmY8k/V6xyFDqtSl2YD V8396IHfHEulh4iSKKZ+mG9pifb9qGwd49VlcB+22DNVNWqYsJ/litMpU1fxM0PC7RZL BaEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :to:cc:references:from:in-reply-to:content-transfer-encoding; bh=ftAlGkfVN9yFSMHjqy7cpbDkYMyhHDjfXWpCptFDTFo=; b=6QrrEvJJMXX0rZCoUN/UQB52z5Bpjk+qtd9dkh8qVwYMukHu1F4C6ZFCMoEUYdE4Do r44CSfuiyYaunWOhSsih/uizGXLadRJU5VAOs/3ICr4cpFKj7H/ChRYK7l8SB7PlkhlP PwuhpXs1xZdmN9hnutkq33i2uiwLXBUI1d/VIviMVd/YpUKQdUn6mOqvcG9lkVxVco8i Y3PUC/iZNI59SXzMYrasqvRXL0RRrgBE4P2JNtgqyOrOr31uC4T3GT40Ubn1RH8oQYAq LLWPJov9dvI0aWZXQeZ+HaM1mrfUll6mByUZRHqHvk2OZixz8t0M0GhNDILUjlO7Tjf2 7SqA== X-Gm-Message-State: AOAM533vTZ0wKPmwywoAzo7KWJZjhIbLD3rcfVAl06HeTdF8jccU3Nna aEx9vpdoNDL14Axa6fb2lLTboQ== X-Google-Smtp-Source: ABdhPJxRaFpMXHUmAwAQvJOURtMeJdgu+9o6mOi0Xa1VO1LPiywHr+NUZm86xDqsmpq+lh4gOGMk3A== X-Received: by 2002:a63:553:0:b0:3f5:f32a:7c54 with SMTP id 80-20020a630553000000b003f5f32a7c54mr17959211pgf.138.1653272497211; Sun, 22 May 2022 19:21:37 -0700 (PDT) Received: from [10.71.57.194] ([139.177.225.241]) by smtp.gmail.com with ESMTPSA id y12-20020aa7854c000000b0050dc7628195sm5846585pfn.111.2022.05.22.19.21.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 May 2022 19:21:36 -0700 (PDT) Message-ID: Date: Mon, 23 May 2022 10:21:26 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [External] Re: [PATCH bpf-next v2] selftests/bpf: fix some bugs in map_lookup_percpu_elem testcase To: Andrii Nakryiko , Yonghong Song Cc: Shuah Khan , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin Lau , Song Liu , john fastabend , KP Singh , Steven Rostedt , Ingo Molnar , Jiri Olsa , Dave Marchevsky , Joanne Koong , Geliang Tang , "open list:KERNEL SELFTEST FRAMEWORK" , Networking , bpf , open list , duanxiongchun@bytedance.com, Muchun Song , Dongdong Wang , Cong Wang , zhouchengming@bytedance.com, Yosry Ahmed References: <20220518025053.20492-1-zhoufeng.zf@bytedance.com> From: Feng Zhou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2022/5/21 上午6:00, Andrii Nakryiko 写道: > On Wed, May 18, 2022 at 8:44 AM Yonghong Song wrote: >> >> >> On 5/17/22 7:50 PM, Feng zhou wrote: >>> From: Feng Zhou >>> >>> comments from Andrii Nakryiko, details in here: >>> https://lore.kernel.org/lkml/20220511093854.411-1-zhoufeng.zf@bytedance.com/T/ >>> >>> use /* */ instead of // >>> use libbpf_num_possible_cpus() instead of sysconf(_SC_NPROCESSORS_ONLN) >>> use 8 bytes for value size >>> fix memory leak >>> use ASSERT_EQ instead of ASSERT_OK >>> add bpf_loop to fetch values on each possible CPU >>> >>> Fixes: ed7c13776e20c74486b0939a3c1de984c5efb6aa ("selftests/bpf: add test case for bpf_map_lookup_percpu_elem") >>> Signed-off-by: Feng Zhou >> Acked-by: Yonghong Song > > I've fixed remaining formatting issues and added my_pid check to avoid > accidental interference with other tests/processes. Applied to > bpf-next, thanks. Ok, Thanks.