From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH v3] net/vhost: fix segfault when creating vdev dynamically Date: Fri, 30 Mar 2018 09:36:15 +0200 Message-ID: References: <20180329153544.270488-1-junjie.j.chen@intel.com> <20180330065831.107558-1-junjie.j.chen@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" , "Chen@dpdk.org" To: "Yang, Zhiyong" , "Chen, Junjie J" , "Tan, Jianfeng" , "mtetsuyah@gmail.com" Return-path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 6E49516E for ; Fri, 30 Mar 2018 09:36:18 +0200 (CEST) In-Reply-To: Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 03/30/2018 09:32 AM, Yang, Zhiyong wrote: > Hi Maxime, Junjie, > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Junjie Chen >> Sent: Friday, March 30, 2018 2:59 PM >> To: Tan, Jianfeng ; maxime.coquelin@redhat.com; >> mtetsuyah@gmail.com >> Cc: dev@dpdk.org; Chen, Junjie J ; >> Chen@dpdk.org >> Subject: [dpdk-dev] [PATCH v3] net/vhost: fix segfault when creating vdev >> dynamically >> >> When creating vdev dynamically, vhost pmd driver starts directly without >> checking TX/RX queues are ready or not, and thus causes segmentation fault >> when vhost library accesses queues. This patch adds a flag to check whether >> queues are setup or not, and adds queues setup into dev_start function to >> allow user to start them after setting up. >> >> Fixes: aed0b12930b3 ("net/vhost: fix socket file deleted on stop") >> Signed-off-by: Chen, Junjie >> --- > > Thanks for Junjie's patch! > > I also came across the similar issue when developing virtio-user server mode. > From user's perspective, the patch can fix the issue in my user case instead of > the patch http://www.dpdk.org/dev/patchwork/patch/36340/ > > Tested-by: Zhiyong Yang Great it solves your issue, and thanks for having tested it. Maxime > Thanks > Zhiyong >