From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Osipenko Subject: Re: [PATCH v1] usb: chipidea: tegra: Fix missed ci_hdrc_remove_device() Date: Tue, 26 Feb 2019 18:40:45 +0300 Message-ID: References: <20190224153622.8877-1-digetx@gmail.com> <20190225080715.4965810a@dimatab> <20190226105615.GA12397@kroah.com> <20190226145857.GB26080@kroah.com> <20190226152144.GA17948@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20190226152144.GA17948@kroah.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Greg Kroah-Hartman Cc: Joe Perches , Andy Whitcroft , Peter Chen , Thierry Reding , Jonathan Hunter , "linux-usb@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" List-Id: linux-tegra@vger.kernel.org 26.02.2019 18:21, Greg Kroah-Hartman пишет: > On Tue, Feb 26, 2019 at 06:08:17PM +0300, Dmitry Osipenko wrote: >> 26.02.2019 17:58, Greg Kroah-Hartman пишет: >>> On Tue, Feb 26, 2019 at 05:33:05PM +0300, Dmitry Osipenko wrote: >>>> 26.02.2019 13:56, Greg Kroah-Hartman пишет: >>>>> On Mon, Feb 25, 2019 at 08:07:15AM +0300, Dmitry Osipenko wrote: >>>>>> В Mon, 25 Feb 2019 02:27:19 +0000 >>>>>> Peter Chen пишет: >>>>>> >>>>>>> >>>>>>>> >>>>>>>> Fixes: dfebb5f43a78827a ("usb: chipidea: Add support for >>>>>>>> Tegra20/30/114/124") >>>>>>> >>>>>>> I suppose you need to apply at stable tree too, right? >>>>>>> >>>>>> >>>>>> It is enough to have the "Fixes" tag to get patch backported into all >>>>>> relevant kernel versions. >>>>> >>>>> No it is not. My scripts do NOT trigger off of the fixes: tag, please >>>>> read: >>>>> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html >>>>> for how to do this properly. >>>> >>>> Okay, my bad then. Maybe this is something that could warned by checkpatch.. adding Joe and Andy to the thread. >>> >>> Why? It's allowed to put fixes: tags for a patch that does not belong >>> in a stable tree. That happens all the time, and is encouraged. Look >>> at some of the stuff in linux-next now, we have Fixes: for commits that >>> are still in linux-next as well, because we do not rebase our trees. >>> When they all merge into Linus's tree, all is good. >>> >>> So this is not something that checkpatch needs to do anything about. >> >> At least that might help in cases like this if maintainer is also oblivious. > > If the maintainer is "oblivious", they are not going to be running > checkpatch :) > > Remember, the "Fixes:" tag is a relatively new thing compared to the cc: > stable tag, which has been a documented requirement for over a decade. > Yes, some subsystems do not even do cc: stable, but that is because > those subsystem maintainers do not want to do it, or do not care. > Again, checkpatch is not going to help them. > > checkpatch is not a panacea, people still have to use their brains. My point that either submitter or maintainers may catch up the problem if at least there are means to report the problem. So I'm still thinking it's not a bad idea to add the warning message, maybe even for the "checkpatch --strict" option only. I'm not insisting that it is something super-necessary and it's up to you guys to decide in the end. From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v1] usb: chipidea: tegra: Fix missed ci_hdrc_remove_device() From: Dmitry Osipenko Message-Id: Date: Tue, 26 Feb 2019 18:40:45 +0300 To: Greg Kroah-Hartman Cc: Joe Perches , Andy Whitcroft , Peter Chen , Thierry Reding , Jonathan Hunter , "linux-usb@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" List-ID: MjYuMDIuMjAxOSAxODoyMSwgR3JlZyBLcm9haC1IYXJ0bWFuINC/0LjRiNC10YI6Cj4gT24gVHVl LCBGZWIgMjYsIDIwMTkgYXQgMDY6MDg6MTdQTSArMDMwMCwgRG1pdHJ5IE9zaXBlbmtvIHdyb3Rl Ogo+PiAyNi4wMi4yMDE5IDE3OjU4LCBHcmVnIEtyb2FoLUhhcnRtYW4g0L/QuNGI0LXRgjoKPj4+ IE9uIFR1ZSwgRmViIDI2LCAyMDE5IGF0IDA1OjMzOjA1UE0gKzAzMDAsIERtaXRyeSBPc2lwZW5r byB3cm90ZToKPj4+PiAyNi4wMi4yMDE5IDEzOjU2LCBHcmVnIEtyb2FoLUhhcnRtYW4g0L/QuNGI 0LXRgjoKPj4+Pj4gT24gTW9uLCBGZWIgMjUsIDIwMTkgYXQgMDg6MDc6MTVBTSArMDMwMCwgRG1p dHJ5IE9zaXBlbmtvIHdyb3RlOgo+Pj4+Pj4g0JIgTW9uLCAyNSBGZWIgMjAxOSAwMjoyNzoxOSAr MDAwMAo+Pj4+Pj4gUGV0ZXIgQ2hlbiA8cGV0ZXIuY2hlbkBueHAuY29tPiDQv9C40YjQtdGCOgo+ Pj4+Pj4KPj4+Pj4+PiAgCj4+Pj4+Pj4+Cj4+Pj4+Pj4+IEZpeGVzOiBkZmViYjVmNDNhNzg4Mjdh ICgidXNiOiBjaGlwaWRlYTogQWRkIHN1cHBvcnQgZm9yCj4+Pj4+Pj4+IFRlZ3JhMjAvMzAvMTE0 LzEyNCIpICAKPj4+Pj4+Pgo+Pj4+Pj4+IEkgc3VwcG9zZSB5b3UgbmVlZCB0byBhcHBseSBhdCBz dGFibGUgdHJlZSB0b28sIHJpZ2h0Pwo+Pj4+Pj4+Cj4+Pj4+Pgo+Pj4+Pj4gSXQgaXMgZW5vdWdo IHRvIGhhdmUgdGhlICJGaXhlcyIgdGFnIHRvIGdldCBwYXRjaCBiYWNrcG9ydGVkIGludG8gYWxs Cj4+Pj4+PiByZWxldmFudCBrZXJuZWwgdmVyc2lvbnMuCj4+Pj4+Cj4+Pj4+IE5vIGl0IGlzIG5v dC4gIE15IHNjcmlwdHMgZG8gTk9UIHRyaWdnZXIgb2ZmIG9mIHRoZSBmaXhlczogdGFnLCBwbGVh c2UKPj4+Pj4gcmVhZDoKPj4+Pj4gICAgIGh0dHBzOi8vd3d3Lmtlcm5lbC5vcmcvZG9jL2h0bWwv bGF0ZXN0L3Byb2Nlc3Mvc3RhYmxlLWtlcm5lbC1ydWxlcy5odG1sCj4+Pj4+IGZvciBob3cgdG8g ZG8gdGhpcyBwcm9wZXJseS4KPj4+Pgo+Pj4+IE9rYXksIG15IGJhZCB0aGVuLiBNYXliZSB0aGlz IGlzIHNvbWV0aGluZyB0aGF0IGNvdWxkIHdhcm5lZCBieSBjaGVja3BhdGNoLi4gYWRkaW5nIEpv ZSBhbmQgQW5keSB0byB0aGUgdGhyZWFkLgo+Pj4KPj4+IFdoeT8gIEl0J3MgYWxsb3dlZCB0byBw dXQgZml4ZXM6IHRhZ3MgZm9yIGEgcGF0Y2ggdGhhdCBkb2VzIG5vdCBiZWxvbmcKPj4+IGluIGEg c3RhYmxlIHRyZWUuICBUaGF0IGhhcHBlbnMgYWxsIHRoZSB0aW1lLCBhbmQgaXMgZW5jb3VyYWdl ZC4gIExvb2sKPj4+IGF0IHNvbWUgb2YgdGhlIHN0dWZmIGluIGxpbnV4LW5leHQgbm93LCB3ZSBo YXZlIEZpeGVzOiBmb3IgY29tbWl0cyB0aGF0Cj4+PiBhcmUgc3RpbGwgaW4gbGludXgtbmV4dCBh cyB3ZWxsLCBiZWNhdXNlIHdlIGRvIG5vdCByZWJhc2Ugb3VyIHRyZWVzLgo+Pj4gV2hlbiB0aGV5 IGFsbCBtZXJnZSBpbnRvIExpbnVzJ3MgdHJlZSwgYWxsIGlzIGdvb2QuCj4+Pgo+Pj4gU28gdGhp cyBpcyBub3Qgc29tZXRoaW5nIHRoYXQgY2hlY2twYXRjaCBuZWVkcyB0byBkbyBhbnl0aGluZyBh Ym91dC4KPj4KPj4gQXQgbGVhc3QgdGhhdCBtaWdodCBoZWxwIGluIGNhc2VzIGxpa2UgdGhpcyBp ZiBtYWludGFpbmVyIGlzIGFsc28gb2JsaXZpb3VzLgo+IAo+IElmIHRoZSBtYWludGFpbmVyIGlz ICJvYmxpdmlvdXMiLCB0aGV5IGFyZSBub3QgZ29pbmcgdG8gYmUgcnVubmluZwo+IGNoZWNrcGF0 Y2ggOikKPiAKPiBSZW1lbWJlciwgdGhlICJGaXhlczoiIHRhZyBpcyBhIHJlbGF0aXZlbHkgbmV3 IHRoaW5nIGNvbXBhcmVkIHRvIHRoZSBjYzoKPiBzdGFibGUgdGFnLCB3aGljaCBoYXMgYmVlbiBh IGRvY3VtZW50ZWQgcmVxdWlyZW1lbnQgZm9yIG92ZXIgYSBkZWNhZGUuCj4gWWVzLCBzb21lIHN1 YnN5c3RlbXMgZG8gbm90IGV2ZW4gZG8gY2M6IHN0YWJsZSwgYnV0IHRoYXQgaXMgYmVjYXVzZQo+ IHRob3NlIHN1YnN5c3RlbSBtYWludGFpbmVycyBkbyBub3Qgd2FudCB0byBkbyBpdCwgb3IgZG8g bm90IGNhcmUuCj4gQWdhaW4sIGNoZWNrcGF0Y2ggaXMgbm90IGdvaW5nIHRvIGhlbHAgdGhlbS4K PiAKPiBjaGVja3BhdGNoIGlzIG5vdCBhIHBhbmFjZWEsIHBlb3BsZSBzdGlsbCBoYXZlIHRvIHVz ZSB0aGVpciBicmFpbnMuCgpNeSBwb2ludCB0aGF0IGVpdGhlciBzdWJtaXR0ZXIgb3IgbWFpbnRh aW5lcnMgbWF5IGNhdGNoIHVwIHRoZSBwcm9ibGVtIGlmIGF0IGxlYXN0IHRoZXJlIGFyZSBtZWFu cyB0byByZXBvcnQgdGhlIHByb2JsZW0uIFNvIEknbSBzdGlsbCB0aGlua2luZyBpdCdzIG5vdCBh IGJhZCBpZGVhIHRvIGFkZCB0aGUgd2FybmluZyBtZXNzYWdlLCBtYXliZSBldmVuIGZvciB0aGUg ImNoZWNrcGF0Y2ggLS1zdHJpY3QiIG9wdGlvbiBvbmx5LiBJJ20gbm90IGluc2lzdGluZyB0aGF0 IGl0IGlzIHNvbWV0aGluZyBzdXBlci1uZWNlc3NhcnkgYW5kIGl0J3MgdXAgdG8geW91IGd1eXMg dG8gZGVjaWRlIGluIHRoZSBlbmQuCg==