All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Borkmann <daniel@iogearbox.net>
To: Jakub Kicinski <jakub.kicinski@netronome.com>,
	Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>
Cc: Alexei Starovoitov <ast@kernel.org>,
	Quentin Monnet <quentin.monnet@netronome.com>,
	Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
	Yonghong Song <yhs@fb.com>,
	netdev@vger.kernel.org
Subject: Re: [PATCH bpf-next] tools/bpftool: show btf id in program information
Date: Thu, 11 Apr 2019 09:51:47 +0200	[thread overview]
Message-ID: <ed580e58-2853-561c-c3a3-29814c72ab03@iogearbox.net> (raw)
In-Reply-To: <20190410083905.328e05fd@cakuba.netronome.com>

On 04/10/2019 05:39 PM, Jakub Kicinski wrote:
> On Wed, 10 Apr 2019 13:56:42 +0900, Prashant Bhole wrote:
>> Let's add a way to know whether a program has btf context.
>> Patch adds 'btf_id' in the output of program listing.
>> When btf_id is present, it means program has btf context.
>>
>> Sample output:
>> user@test# bpftool prog list
>> 25: xdp  name xdp_prog1  tag 539ec6ce11b52f98  gpl
>> 	loaded_at 2019-04-10T11:44:20+0900  uid 0
>> 	xlated 488B  not jited  memlock 4096B  map_ids 23
>> 	btf_id 1
>>
>> Signed-off-by: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>
> 
> Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>

Applied, thanks!

What would be the plan for the maps listing?

I think what we could also potentially have is some way to dump
the BTF type info based on such above id. Perhaps it would make
sense to similarly share the verifier's printer with bpftool?

  reply	other threads:[~2019-04-11  7:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-10  4:56 [PATCH bpf-next] tools/bpftool: show btf id in program information Prashant Bhole
2019-04-10 15:39 ` Jakub Kicinski
2019-04-11  7:51   ` Daniel Borkmann [this message]
2019-04-11 15:37     ` Yonghong Song
2019-04-16  0:54       ` Andrii Nakryiko
2019-04-16  8:02         ` Daniel Borkmann
2019-04-16  8:57         ` Prashant Bhole

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ed580e58-2853-561c-c3a3-29814c72ab03@iogearbox.net \
    --to=daniel@iogearbox.net \
    --cc=ast@kernel.org \
    --cc=bhole_prashant_q7@lab.ntt.co.jp \
    --cc=jakub.kicinski@netronome.com \
    --cc=kafai@fb.com \
    --cc=netdev@vger.kernel.org \
    --cc=quentin.monnet@netronome.com \
    --cc=songliubraving@fb.com \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.