From: Randy Dunlap <rdunlap@infradead.org>
To: LKML <linux-kernel@vger.kernel.org>,
linux-spi@vger.kernel.org, Mark Brown <broonie@kernel.org>
Subject: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when SPI_SPRD_ADI=y and HWSPINLOCK=m
Date: Thu, 21 Sep 2017 11:02:31 -0700 [thread overview]
Message-ID: <ed5b8ca2-b853-755d-2801-57cc0b626508@infradead.org> (raw)
From: Randy Dunlap <rdunlap@infradead.org>
Fix build errors when CONFIG_HWSPINLOCK=m and SPI_SPRD_ADI=y.
That combination is not allowed.
drivers/spi/spi-sprd-adi.o: In function `sprd_adi_remove':
spi-sprd-adi.c:(.text+0x13): undefined reference to `hwspin_lock_free'
drivers/spi/spi-sprd-adi.o: In function `sprd_adi_probe':
spi-sprd-adi.c:(.text+0xf5): undefined reference to `of_hwspin_lock_get_id'
spi-sprd-adi.c:(.text+0x107): undefined reference to `hwspin_lock_request_specific'
spi-sprd-adi.c:(.text+0x22e): undefined reference to `hwspin_lock_free'
drivers/spi/spi-sprd-adi.o: In function `sprd_adi_transfer_one':
spi-sprd-adi.c:(.text+0x2eb): undefined reference to `__hwspin_lock_timeout'
spi-sprd-adi.c:(.text+0x349): undefined reference to `__hwspin_unlock'
spi-sprd-adi.c:(.text+0x389): undefined reference to `__hwspin_lock_timeout'
spi-sprd-adi.c:(.text+0x3ee): undefined reference to `__hwspin_unlock'
v2: allow build with or without HWSPINLOCK, but restrict to =m
if HWSPINLOCK=m.
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Baolin Wang <Baolin.Wang@spreadtrum.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org
---
drivers/spi/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20170921.orig/drivers/spi/Kconfig
+++ linux-next-20170921/drivers/spi/Kconfig
@@ -625,6 +625,7 @@ config SPI_SIRF
config SPI_SPRD_ADI
tristate "Spreadtrum ADI controller"
depends on ARCH_SPRD || COMPILE_TEST
+ depends on HWSPINLOCK || HWSPINLOCK=n
help
ADI driver based on SPI for Spreadtrum SoCs.
next reply other threads:[~2017-09-21 18:02 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 18:02 Randy Dunlap [this message]
2017-09-22 9:26 ` [PATCH v2 -next] spi: fix spi-sprd-adi build errors when SPI_SPRD_ADI=y and HWSPINLOCK=m Mark Brown
2017-09-22 9:26 ` Mark Brown
2017-09-23 1:46 ` Randy Dunlap
2017-09-23 1:46 ` Randy Dunlap
2017-09-25 16:12 ` Mark Brown
2017-09-25 16:12 ` Mark Brown
2017-09-25 17:19 ` Randy Dunlap
2017-09-25 17:36 ` Mark Brown
2017-09-25 17:36 ` Mark Brown
2017-09-25 19:20 ` Geert Uytterhoeven
2017-09-25 19:20 ` Geert Uytterhoeven
2017-09-25 19:22 ` Mark Brown
2017-09-25 19:31 ` Randy Dunlap
2017-09-25 19:44 ` Mark Brown
2017-09-25 19:44 ` Mark Brown
2017-09-25 19:53 ` Randy Dunlap
2017-09-25 19:53 ` Randy Dunlap
2017-09-25 21:11 ` Mark Brown
2017-09-25 21:11 ` Mark Brown
2017-09-25 22:32 ` Randy Dunlap
2017-09-25 22:32 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed5b8ca2-b853-755d-2801-57cc0b626508@infradead.org \
--to=rdunlap@infradead.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.