From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25633C43215 for ; Tue, 19 Nov 2019 11:15:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F275C222DE for ; Tue, 19 Nov 2019 11:15:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727741AbfKSLPc (ORCPT ); Tue, 19 Nov 2019 06:15:32 -0500 Received: from mx2.suse.de ([195.135.220.15]:55640 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727699AbfKSLPb (ORCPT ); Tue, 19 Nov 2019 06:15:31 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 0E48BBA0D; Tue, 19 Nov 2019 11:15:30 +0000 (UTC) Subject: Re: [PATCH 5/7] ARM: dts: rtd1195: Introduce r-bus To: James Tai Cc: "linux-realtek-soc@lists.infradead.org" , Mark Rutland , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Rob Herring , "linux-arm-kernel@lists.infradead.org" References: <20191111030434.29977-1-afaerber@suse.de> <20191111030434.29977-6-afaerber@suse.de> <960a80b9-b1bf-3709-bbb7-fc2a3c3ae1da@suse.de> <753c18eee3fb4e9ea25d42798542b3dd@realtek.com> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Organization: SUSE Software Solutions Germany GmbH Message-ID: Date: Tue, 19 Nov 2019 12:15:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 MIME-Version: 1.0 In-Reply-To: <753c18eee3fb4e9ea25d42798542b3dd@realtek.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi James, Am 18.11.19 um 07:53 schrieb James Tai: >> So another question, applicable to all SoCs: This reserved Boot ROM area at >> the start of the address space, here of size 0xa800, is that copied into RAM, or >> is that the actual ROM overlapping RAM? If the latter, we should exclude it >> from /memory@0's reg (making it /memory@a800), and add it to soc's ranges >> here for correctness. >> > Yes, we should exclude it from /memory@0's reg. OK, will look into it. > >> With the follow-up question: Is it correct that, given the size 0xa800, I have a >> gap between /memreserve/s from 0xa800 to 0xc000, or should we reserve that >> gap by extending the next /memreserve/ or inserting one? > > We should reserve memory address from 0x0000 to 0xa800 for the internal ROM. Please see [1] - I had already updated the second reservation to start at 0xa800 and extended it to 0x100000 before your response here. The previous "bootcode" size of 0xc000 can be found here: https://github.com/BPI-SINOVOIP/BPI-M4-bsp/blob/master/linux-rtk/arch/arm/mach-rtd119x/include/mach/memory.h https://github.com/BPI-SINOVOIP/BPI-M4-bsp/blob/master/linux-rtk/arch/arm/boot/dts/realtek/rtd119x/rtd-119x-horseradish.dts As you can see the 0xc000 and 0xf4000 were hardcoded and did not depend on SYS_BOOTCODE_MEMSIZE... For later SoCs I saw some FIXME(?) comment that area up to 0x100000 was reserved due to some Jira ticket and should get fixed? Any insights on what is in that memory range causing problems? Regards, Andreas [1] https://patchwork.kernel.org/patch/11248033/ -- SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer HRB 36809 (AG Nürnberg) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEEB4C432C0 for ; Tue, 19 Nov 2019 11:15:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 794B5222DE for ; Tue, 19 Nov 2019 11:15:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pD+OqsM0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 794B5222DE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KqcgT/5UItiNm4N3CAoXnpFQgJcrcYwAGeipn+C7jOU=; b=pD+OqsM0yZ2TWR p6Esu9PcsR4aCmx9GHhOAgruz/cZuYF3lzy12nVw5jimzkRx4FAHwB/M5SV1Gu9TBqid594Bor5IY ywMbpjw1xI+aXFv2H4xlj8NpZVQ1qq10ROdhNcLtwXjdBFcs5t2J3LMg2EnoY19noBPoLTqmi17ZC x1CVQwxT2s+8/ixkOyX0gj0fLBvZinadTTOGMsE61Fjk9JUX5zHqP/8sZ41bNklfk54G+j2uqSuZL crId69Q3Qq5SWTNIDtUXF2pNkug0w+IasBtLuBfWDB/mFjtpXGPXftAjgHJyLEU/QhCnzR5ct2nQN O7Tj/KA+eHbvS2wapfnQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iX1Ts-0001E7-TX; Tue, 19 Nov 2019 11:15:36 +0000 Received: from mx2.suse.de ([195.135.220.15] helo=mx1.suse.de) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iX1To-0001D0-9y; Tue, 19 Nov 2019 11:15:34 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 0E48BBA0D; Tue, 19 Nov 2019 11:15:30 +0000 (UTC) Subject: Re: [PATCH 5/7] ARM: dts: rtd1195: Introduce r-bus To: James Tai References: <20191111030434.29977-1-afaerber@suse.de> <20191111030434.29977-6-afaerber@suse.de> <960a80b9-b1bf-3709-bbb7-fc2a3c3ae1da@suse.de> <753c18eee3fb4e9ea25d42798542b3dd@realtek.com> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Organization: SUSE Software Solutions Germany GmbH Message-ID: Date: Tue, 19 Nov 2019 12:15:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 MIME-Version: 1.0 In-Reply-To: <753c18eee3fb4e9ea25d42798542b3dd@realtek.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191119_031532_514261_4E2B0DD6 X-CRM114-Status: GOOD ( 14.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "devicetree@vger.kernel.org" , "linux-realtek-soc@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Rob Herring , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgSmFtZXMsCgpBbSAxOC4xMS4xOSB1bSAwNzo1MyBzY2hyaWViIEphbWVzIFRhaToKPj4gU28g YW5vdGhlciBxdWVzdGlvbiwgYXBwbGljYWJsZSB0byBhbGwgU29DczogVGhpcyByZXNlcnZlZCBC b290IFJPTSBhcmVhIGF0Cj4+IHRoZSBzdGFydCBvZiB0aGUgYWRkcmVzcyBzcGFjZSwgaGVyZSBv ZiBzaXplIDB4YTgwMCwgaXMgdGhhdCBjb3BpZWQgaW50byBSQU0sIG9yCj4+IGlzIHRoYXQgdGhl IGFjdHVhbCBST00gb3ZlcmxhcHBpbmcgUkFNPyBJZiB0aGUgbGF0dGVyLCB3ZSBzaG91bGQgZXhj bHVkZSBpdAo+PiBmcm9tIC9tZW1vcnlAMCdzIHJlZyAobWFraW5nIGl0IC9tZW1vcnlAYTgwMCks IGFuZCBhZGQgaXQgdG8gc29jJ3MgcmFuZ2VzCj4+IGhlcmUgZm9yIGNvcnJlY3RuZXNzLgo+Pgo+ IFllcywgd2Ugc2hvdWxkIGV4Y2x1ZGUgaXQgZnJvbSAvbWVtb3J5QDAncyByZWcuCgpPSywgd2ls bCBsb29rIGludG8gaXQuCgo+IAo+PiBXaXRoIHRoZSBmb2xsb3ctdXAgcXVlc3Rpb246IElzIGl0 IGNvcnJlY3QgdGhhdCwgZ2l2ZW4gdGhlIHNpemUgMHhhODAwLCBJIGhhdmUgYQo+PiBnYXAgYmV0 d2VlbiAvbWVtcmVzZXJ2ZS9zIGZyb20gMHhhODAwIHRvIDB4YzAwMCwgb3Igc2hvdWxkIHdlIHJl c2VydmUgdGhhdAo+PiBnYXAgYnkgZXh0ZW5kaW5nIHRoZSBuZXh0IC9tZW1yZXNlcnZlLyBvciBp bnNlcnRpbmcgb25lPwo+IAo+IFdlIHNob3VsZCByZXNlcnZlIG1lbW9yeSBhZGRyZXNzIGZyb20g MHgwMDAwIHRvIDB4YTgwMCBmb3IgdGhlIGludGVybmFsIFJPTS4KClBsZWFzZSBzZWUgWzFdIC0g SSBoYWQgYWxyZWFkeSB1cGRhdGVkIHRoZSBzZWNvbmQgcmVzZXJ2YXRpb24gdG8gc3RhcnQKYXQg MHhhODAwIGFuZCBleHRlbmRlZCBpdCB0byAweDEwMDAwMCBiZWZvcmUgeW91ciByZXNwb25zZSBo ZXJlLgoKVGhlIHByZXZpb3VzICJib290Y29kZSIgc2l6ZSBvZiAweGMwMDAgY2FuIGJlIGZvdW5k IGhlcmU6Cmh0dHBzOi8vZ2l0aHViLmNvbS9CUEktU0lOT1ZPSVAvQlBJLU00LWJzcC9ibG9iL21h c3Rlci9saW51eC1ydGsvYXJjaC9hcm0vbWFjaC1ydGQxMTl4L2luY2x1ZGUvbWFjaC9tZW1vcnku aApodHRwczovL2dpdGh1Yi5jb20vQlBJLVNJTk9WT0lQL0JQSS1NNC1ic3AvYmxvYi9tYXN0ZXIv bGludXgtcnRrL2FyY2gvYXJtL2Jvb3QvZHRzL3JlYWx0ZWsvcnRkMTE5eC9ydGQtMTE5eC1ob3Jz ZXJhZGlzaC5kdHMKCkFzIHlvdSBjYW4gc2VlIHRoZSAweGMwMDAgYW5kIDB4ZjQwMDAgd2VyZSBo YXJkY29kZWQgYW5kIGRpZCBub3QgZGVwZW5kCm9uIFNZU19CT09UQ09ERV9NRU1TSVpFLi4uCkZv ciBsYXRlciBTb0NzIEkgc2F3IHNvbWUgRklYTUUoPykgY29tbWVudCB0aGF0IGFyZWEgdXAgdG8g MHgxMDAwMDAgd2FzCnJlc2VydmVkIGR1ZSB0byBzb21lIEppcmEgdGlja2V0IGFuZCBzaG91bGQg Z2V0IGZpeGVkPyBBbnkgaW5zaWdodHMgb24Kd2hhdCBpcyBpbiB0aGF0IG1lbW9yeSByYW5nZSBj YXVzaW5nIHByb2JsZW1zPwoKUmVnYXJkcywKQW5kcmVhcwoKWzFdIGh0dHBzOi8vcGF0Y2h3b3Jr Lmtlcm5lbC5vcmcvcGF0Y2gvMTEyNDgwMzMvCgotLSAKU1VTRSBTb2Z0d2FyZSBTb2x1dGlvbnMg R2VybWFueSBHbWJICk1heGZlbGRzdHIuIDUsIDkwNDA5IE7DvHJuYmVyZywgR2VybWFueQpHRjog RmVsaXggSW1lbmTDtnJmZmVyCkhSQiAzNjgwOSAoQUcgTsO8cm5iZXJnKQoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWls aW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=