Re: [PATCH] clk: qcom: Fix SM_GPUCC_8650 dependencies

From: neil.armstrong@linaro.org
To: Yue Haibing <yuehaibing@huawei.com>,
	andersson@kernel.org, konrad.dybcio@linaro.org,
	mturquette@baylibre.com, sboyd@kernel.org,
	dmitry.baryshkov@linaro.org
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: qcom: Fix SM_GPUCC_8650 dependencies
Date: Mon, 25 Mar 2024 15:10:20 +0100	[thread overview]
Message-ID: <ed6a4199-ad9d-4ee8-a24c-cc3be4642fad@linaro.org> (raw)
In-Reply-To: <20240323032806.14356-1-yuehaibing@huawei.com>

On 23/03/2024 04:28, Yue Haibing wrote:
> CONFIG_SM_GCC_8650 depends on ARM64 but it is selected by
> CONFIG_SM_GPUCC_8650, which can be selected on ARM, resulting in a
> Kconfig warning.
> 
> WARNING: unmet direct dependencies detected for SM_GCC_8650
>    Depends on [n]: COMMON_CLK [=y] && COMMON_CLK_QCOM [=y] && (ARM64 || COMPILE_TEST [=n])
>    Selected by [m]:
>    - SM_GPUCC_8650 [=m] && COMMON_CLK [=y] && COMMON_CLK_QCOM [=y]
> 
> Add the same dependencies to CONFIG_SM_GPUCC_8650 to resolve the warning.
> 
> Fixes: 8676fd4f3874 ("clk: qcom: add the SM8650 GPU Clock Controller driver")
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
>   drivers/clk/qcom/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
> index 8ab08e7b5b6c..3e85df1514bd 100644
> --- a/drivers/clk/qcom/Kconfig
> +++ b/drivers/clk/qcom/Kconfig
> @@ -1094,6 +1094,7 @@ config SM_GPUCC_8550
>   
>   config SM_GPUCC_8650
>   	tristate "SM8650 Graphics Clock Controller"
> +	depends on ARM64 || COMPILE_TEST
>   	select SM_GCC_8650
>   	help
>   	  Support for the graphics clock controller on SM8650 devices.

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>