From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F026C433E9 for ; Tue, 2 Mar 2021 03:39:22 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0452464DE4 for ; Tue, 2 Mar 2021 03:39:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0452464DE4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35076 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lGvsX-0002DF-3V for qemu-devel@archiver.kernel.org; Mon, 01 Mar 2021 22:39:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43734) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lGvqT-0001NT-0g for qemu-devel@nongnu.org; Mon, 01 Mar 2021 22:37:13 -0500 Received: from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431]:43092) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lGvqL-0003sc-6N for qemu-devel@nongnu.org; Mon, 01 Mar 2021 22:37:12 -0500 Received: by mail-pf1-x431.google.com with SMTP id q204so11880530pfq.10 for ; Mon, 01 Mar 2021 19:37:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=pTyphq2Qa/NVTfk6IuE13qs1qajpOtzWDwkWAGwaJyc=; b=xcIq79BTbngrzIUFAaXuAIB1k5dS9W9VYu+Y2PAr5F60k6yk60T6xXkyrET6kLY/1a rtHkBdtfwkdtt7lAe4AklWP6AbSxLWyxzjjnkqd4tWXKtclJXNxmvZdeFZyc91WhiZk1 EUmUsSZ7nH2tTJAi1cRkdYxZ2/ZgbwgLeoyhuPMmhB0HnLpzX1iUascZngMadbeCseS/ Y21Aj6HbOr9CjbE8v80xOBdh4cmGAnJriHuDdqm7NcbtLBBLFjy31zA2f1uhH8rB7ZlA 8mVNWpS+G11C2Ld5v9dhLEbrsbgG4c0fAoOZyEiDMS8LI67H36nEvhC9go9yqd1jczMm uj4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=pTyphq2Qa/NVTfk6IuE13qs1qajpOtzWDwkWAGwaJyc=; b=nH+vBRTuzIPm90k/bCK5LM16/bqgwwiyOaiGTJKHrV21bTUwFvFb9QcI9olRn3Bgoy Y1HGp2IJvI1ThWjPdSj3gJm1Wz+O/9lVE631GVTCLoB00YpK3oStNCqysoItrENAFGGx RAqAp0/53GocBdmB1Eis9q7OHblE/6w121Kg07no1+yU+ZkZAr6hD0VKeGVMiZvckrnF II0aV+Ky223fJcHOb8oVCE5KkdU8rhafZhOASv9rRJnTP/XvuKccZcBARZvGNY8xfahx 58/y1EIeCUFRNuR4G63LTfxw+3beDBA5kJc9CF8SyGuUpwTa8XBkJEWSQNc+gznEm8Ed g4qQ== X-Gm-Message-State: AOAM531i+bzZEQpRiDJZD7P9+RLUlKNqdwBGNSe+uEhj9Yi0bk8akFR0 z6kOV4Ox75eRPLawspdE0Y4RRymwTlSeyA== X-Google-Smtp-Source: ABdhPJwfygNCCv5u6x1DlHphuxZZuC6aqfG9SjqVj37g6b4fCZWgNywvYYocMyzLhXRd5lLLrcjD3A== X-Received: by 2002:a63:4709:: with SMTP id u9mr16233633pga.250.1614656219832; Mon, 01 Mar 2021 19:36:59 -0800 (PST) Received: from [192.168.1.11] (174-21-84-25.tukw.qwest.net. [174.21.84.25]) by smtp.gmail.com with ESMTPSA id o11sm19652874pfp.136.2021.03.01.19.36.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Mar 2021 19:36:59 -0800 (PST) Subject: Re: [RFC v2 10/24] target/arm: only perform TCG cpu and machine inits if tcg enabled To: Claudio Fontana References: <20210301164936.19446-1-cfontana@suse.de> <20210301164936.19446-11-cfontana@suse.de> From: Richard Henderson Message-ID: Date: Mon, 1 Mar 2021 19:36:57 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210301164936.19446-11-cfontana@suse.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::431; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 3/1/21 8:49 AM, Claudio Fontana wrote: > @@ -1321,6 +1323,7 @@ static void arm_cpu_realizefn(DeviceState *dev, Error **errp) > } > } > > +#ifdef CONFIG_TCG > { > uint64_t scale; > > @@ -1346,7 +1349,8 @@ static void arm_cpu_realizefn(DeviceState *dev, Error **errp) > cpu->gt_timer[GTIMER_HYPVIRT] = timer_new(QEMU_CLOCK_VIRTUAL, scale, > arm_gt_hvtimer_cb, cpu); > } > -#endif > +#endif /* CONFIG_TCG */ You can use tcg_enabled here. > - } > > #ifndef CONFIG_USER_ONLY > - cpu->pmu_timer = timer_new_ns(QEMU_CLOCK_VIRTUAL, arm_pmu_timer_cb, > - cpu); > + cpu->pmu_timer = timer_new_ns(QEMU_CLOCK_VIRTUAL, arm_pmu_timer_cb, > + cpu); Incorrect indentation change. Otherwise, LGTM. r~