From mboxrd@z Thu Jan  1 00:00:00 1970
From: Declan Doherty <declan.doherty@intel.com>
Subject: Re: [PATCH] test: Fix memory corruption issues which
 fails the link_bonding test.
Date: Wed, 12 Jul 2017 10:59:56 +0100
Message-ID: <ed6d7471-8542-5300-9b7a-5565aef7d3df@intel.com>
References: <1499671222-8283-1-git-send-email-herbert.guan@arm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
To: Herbert Guan <herbert.guan@arm.com>, dev@dpdk.org, jianbo.liu@linaro.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id DE7172E83
 for <dev@dpdk.org>; Wed, 12 Jul 2017 11:59:58 +0200 (CEST)
In-Reply-To: <1499671222-8283-1-git-send-email-herbert.guan@arm.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/07/2017 8:20 AM, Herbert Guan wrote:
> There were double-free problems in some test cases of link_bonding,
> which will cause a duplicated mbuf will be added into mempool.  After
> double-free, some new allocated mbuf will hold a same address and
> thus cause the memory corruption.
>
> Another minor issue is that in some test cases, allocated mbuf will
> not be released after test case exits.  Hopefully these leaked mbuf
> will be released by the next test case in its setup phase when
> stopping the virtual pmd ports, while this do is a memory leak of
> the exited test case.
>
> To fix above 2 issues, this patch will do:
> 1) Release virtual pmd ports' tx queue in the clean up function
>    remove_slaves_and_stop_bonded_device() of each test cases.
> 2) Do not release allocated mbufs for test bursts.  These mbufs
>    will be released in remove_slaves_and_stop_bonded_device() when
>    test case exits.
>
> Signed-off-by: Herbert Guan <herbert.guan@arm.com>
> ---
...
>


Hey Herbert,

I'm seeing compilation warnings for unused variables when I apply this 
patch, otherwise these changes look good.

   CC test_link_bonding.o
/home/declan/Development/dpdk-org/master/test/test/test_link_bonding.c:2407:9: 
error: unused variable 'j'
       [-Werror,-Wunused-variable]
         int i, j, burst_size, slave_count, primary_port;
                ^
/home/declan/Development/dpdk-org/master/test/test/test_link_bonding.c:3301:9: 
error: unused variable 'j'
       [-Werror,-Wunused-variable]
         int i, j, burst_size, slave_count;
                ^
/home/declan/Development/dpdk-org/master/test/test/test_link_bonding.c:3860:9: 
error: unused variable 'j'
       [-Werror,-Wunused-variable]
         int i, j, burst_size, slave_count;
                ^
/home/declan/Development/dpdk-org/master/test/test/test_link_bonding.c:4372:9: 
error: unused variable 'j'
       [-Werror,-Wunused-variable]
         int i, j, burst_size, slave_count, primary_port;