All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anand Jain <anand.jain@oracle.com>
To: Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v4 3/3] btrfs: refactor btrfs_check_can_nocow() into two variants
Date: Tue, 23 Jun 2020 22:56:35 +0800	[thread overview]
Message-ID: <ed6eedb1-26e9-c209-900f-069322a02503@oracle.com> (raw)
In-Reply-To: <20200623052112.198682-4-wqu@suse.com>




> +static int check_nocow_nolock(struct btrfs_inode *inode, loff_t pos,
> +			      size_t *write_bytes)
> +{
> +	return check_can_nocow(inode, pos, write_bytes, false);
> +}


> +int btrfs_check_nocow_lock(struct btrfs_inode *inode, loff_t pos,
> +			   size_t *write_bytes)
> +{
> +	return check_can_nocow(inode, pos, write_bytes, false);
> +}


  Both functions are same.  Something obviously not ok.

Thanks, Anand

  parent reply	other threads:[~2020-06-23 14:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-23  5:21 [PATCH v4 0/3] btrfs: allow btrfs_truncate_block() to fallback to nocow for data space reservation Qu Wenruo
2020-06-23  5:21 ` [PATCH v4 1/3] " Qu Wenruo
2020-06-23  5:21 ` [PATCH v4 2/3] btrfs: add comments for btrfs_check_can_nocow() and can_nocow_extent() Qu Wenruo
2020-06-23  8:35   ` Johannes Thumshirn
2020-06-23  5:21 ` [PATCH v4 3/3] btrfs: refactor btrfs_check_can_nocow() into two variants Qu Wenruo
2020-06-23  8:34   ` Johannes Thumshirn
2020-06-23 14:56   ` Anand Jain [this message]
2020-06-23 15:03     ` Johannes Thumshirn
2020-06-23 22:39       ` Qu Wenruo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ed6eedb1-26e9-c209-900f-069322a02503@oracle.com \
    --to=anand.jain@oracle.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.