All of lore.kernel.org
 help / color / mirror / Atom feed
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: kernel-janitors@vger.kernel.org,
	Alexandre Bounine <alexandre.bounine@idt.com>,
	Matt Porter <mporter@kernel.crashing.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 5/7] rapidio: Delete an unnecessary variable initialisation in three functions
Date: Fri, 15 Dec 2017 11:34:01 +0100	[thread overview]
Message-ID: <ed729e8c-815c-8b56-a48f-1be579d0cc2b@users.sourceforge.net> (raw)
In-Reply-To: <f6e4d185-2c9d-a31d-793d-bda521c450ea@users.sourceforge.net>

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 15 Dec 2017 10:21:15 +0100

The local variable "rc" will be set to an appropriate value a bit later.
Thus omit the explicit initialisation at the beginning.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/rapidio/rio.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/rapidio/rio.c b/drivers/rapidio/rio.c
index 90534365e46c..4604410fb001 100644
--- a/drivers/rapidio/rio.c
+++ b/drivers/rapidio/rio.c
@@ -441,7 +441,7 @@ int rio_request_inb_dbell(struct rio_mport *mport,
 			  void (*dinb) (struct rio_mport * mport, void *dev_id, u16 src,
 					u16 dst, u16 info))
 {
-	int rc = 0;
+	int rc;
 	struct resource *res = kzalloc(sizeof(*res), GFP_KERNEL);
 
 	if (res) {
@@ -693,7 +693,7 @@ EXPORT_SYMBOL_GPL(rio_pw_enable);
 int rio_map_inb_region(struct rio_mport *mport, dma_addr_t local,
 			u64 rbase, u32 size, u32 rflags)
 {
-	int rc = 0;
+	int rc;
 	unsigned long flags;
 
 	if (!mport->ops->map_inb)
@@ -737,7 +737,7 @@ EXPORT_SYMBOL_GPL(rio_unmap_inb_region);
 int rio_map_outb_region(struct rio_mport *mport, u16 destid, u64 rbase,
 			u32 size, u32 rflags, dma_addr_t *local)
 {
-	int rc = 0;
+	int rc;
 	unsigned long flags;
 
 	if (!mport->ops->map_outb)
-- 
2.15.1

WARNING: multiple messages have this Message-ID (diff)
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: kernel-janitors@vger.kernel.org,
	Alexandre Bounine <alexandre.bounine@idt.com>,
	Matt Porter <mporter@kernel.crashing.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 5/7] rapidio: Delete an unnecessary variable initialisation in three functions
Date: Fri, 15 Dec 2017 10:34:01 +0000	[thread overview]
Message-ID: <ed729e8c-815c-8b56-a48f-1be579d0cc2b@users.sourceforge.net> (raw)
In-Reply-To: <f6e4d185-2c9d-a31d-793d-bda521c450ea@users.sourceforge.net>

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 15 Dec 2017 10:21:15 +0100

The local variable "rc" will be set to an appropriate value a bit later.
Thus omit the explicit initialisation at the beginning.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/rapidio/rio.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/rapidio/rio.c b/drivers/rapidio/rio.c
index 90534365e46c..4604410fb001 100644
--- a/drivers/rapidio/rio.c
+++ b/drivers/rapidio/rio.c
@@ -441,7 +441,7 @@ int rio_request_inb_dbell(struct rio_mport *mport,
 			  void (*dinb) (struct rio_mport * mport, void *dev_id, u16 src,
 					u16 dst, u16 info))
 {
-	int rc = 0;
+	int rc;
 	struct resource *res = kzalloc(sizeof(*res), GFP_KERNEL);
 
 	if (res) {
@@ -693,7 +693,7 @@ EXPORT_SYMBOL_GPL(rio_pw_enable);
 int rio_map_inb_region(struct rio_mport *mport, dma_addr_t local,
 			u64 rbase, u32 size, u32 rflags)
 {
-	int rc = 0;
+	int rc;
 	unsigned long flags;
 
 	if (!mport->ops->map_inb)
@@ -737,7 +737,7 @@ EXPORT_SYMBOL_GPL(rio_unmap_inb_region);
 int rio_map_outb_region(struct rio_mport *mport, u16 destid, u64 rbase,
 			u32 size, u32 rflags, dma_addr_t *local)
 {
-	int rc = 0;
+	int rc;
 	unsigned long flags;
 
 	if (!mport->ops->map_outb)
-- 
2.15.1


  parent reply	other threads:[~2017-12-15 10:34 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-15 10:26 [PATCH 0/7] RapidIO: Adjustments for some function implementations SF Markus Elfring
2017-12-15 10:26 ` SF Markus Elfring
2017-12-15 10:28 ` [PATCH 1/7] rapidio: Delete an error message for a failed memory allocation in rio_init_mports() SF Markus Elfring
2017-12-15 10:28   ` SF Markus Elfring
2017-12-15 10:30 ` [PATCH 2/7] rapidio: Adjust 12 checks for null pointers SF Markus Elfring
2017-12-15 10:30   ` SF Markus Elfring
2017-12-15 10:31 ` [PATCH 3/7] rapidio: Adjust five function calls together with a variable assignment SF Markus Elfring
2017-12-15 10:31   ` SF Markus Elfring
2017-12-15 10:32 ` [PATCH 4/7] rapidio: Improve a size determination in five functions SF Markus Elfring
2017-12-15 10:32   ` SF Markus Elfring
2017-12-15 10:34 ` SF Markus Elfring [this message]
2017-12-15 10:34   ` [PATCH 5/7] rapidio: Delete an unnecessary variable initialisation in three functions SF Markus Elfring
2017-12-15 10:35 ` [PATCH 6/7] rapidio: Return an error code only as a constant in two functions SF Markus Elfring
2017-12-15 10:35   ` SF Markus Elfring
2017-12-15 10:36 ` [PATCH 7/7] rapidio: Move 12 EXPORT_SYMBOL_GPL() calls to function implementations SF Markus Elfring
2017-12-15 10:36   ` SF Markus Elfring
2017-12-21 13:51 ` [PATCH 0/7] RapidIO: Adjustments for some " Bounine, Alexandre
2017-12-21 13:51   ` Bounine, Alexandre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ed729e8c-815c-8b56-a48f-1be579d0cc2b@users.sourceforge.net \
    --to=elfring@users.sourceforge.net \
    --cc=alexandre.bounine@idt.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mporter@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.