From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Subject: Re: [PATCH V4 0/5] AC97 driver for mpc5200 Date: Tue, 26 May 2009 06:39:30 -0500 Message-ID: References: <20090525221406.21370.30326.stgit@terra> <9e4733910905260408x335ac337wc77e4d9ac5027f61@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-qy0-f103.google.com (mail-qy0-f103.google.com [209.85.221.103]) by alsa0.perex.cz (Postfix) with ESMTP id 4FE832474F for ; Tue, 26 May 2009 13:39:33 +0200 (CEST) Received: by qyk1 with SMTP id 1so4945934qyk.16 for ; Tue, 26 May 2009 04:39:30 -0700 (PDT) In-Reply-To: <9e4733910905260408x335ac337wc77e4d9ac5027f61@mail.gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Jon Smirl Cc: grant.likely@secretlab.ca, linuxppc-dev@ozlabs.org, alsa-devel@alsa-project.org, broonie@sirena.org.uk, Geert Uytterhoeven List-Id: alsa-devel@alsa-project.org On Tue, May 26, 2009 at 6:08 AM, Jon Smirl wrote: > On Mon, May 25, 2009 at 11:44 PM, Timur Tabi wrote: >> On Mon, May 25, 2009 at 5:15 PM, Jon Smirl wrote: >> >>> =A0 =A0 =A0The macro spin_event_timeout() takes a condition and timeout= value >> >> My patch is already set to go through the powerpc tree, so there's no >> need to repost it here. =A0Please, you changed the title of the patch. > > I'm changing the code, My code? If you want to make your own version of spin_event_timeout, then you should change the name and keep it local to your C files. > I removed the ! on the rc. Geert just asked to > have it changed to an in-line too. And Geert's request won't work. -- = Timur Tabi Linux kernel developer at Freescale From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from qw-out-2122.google.com (qw-out-2122.google.com [74.125.92.24]) by ozlabs.org (Postfix) with ESMTP id 914B9DE065 for ; Tue, 26 May 2009 21:39:32 +1000 (EST) Received: by qw-out-2122.google.com with SMTP id 3so1926962qwe.15 for ; Tue, 26 May 2009 04:39:30 -0700 (PDT) MIME-Version: 1.0 Sender: timur.tabi@gmail.com In-Reply-To: <9e4733910905260408x335ac337wc77e4d9ac5027f61@mail.gmail.com> References: <20090525221406.21370.30326.stgit@terra> <9e4733910905260408x335ac337wc77e4d9ac5027f61@mail.gmail.com> Date: Tue, 26 May 2009 06:39:30 -0500 Message-ID: Subject: Re: [alsa-devel] [PATCH V4 0/5] AC97 driver for mpc5200 From: Timur Tabi To: Jon Smirl Content-Type: text/plain; charset=ISO-8859-1 Cc: linuxppc-dev@ozlabs.org, alsa-devel@alsa-project.org, broonie@sirena.org.uk, Geert Uytterhoeven List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, May 26, 2009 at 6:08 AM, Jon Smirl wrote: > On Mon, May 25, 2009 at 11:44 PM, Timur Tabi wrote: >> On Mon, May 25, 2009 at 5:15 PM, Jon Smirl wrote: >> >>> =A0 =A0 =A0The macro spin_event_timeout() takes a condition and timeout= value >> >> My patch is already set to go through the powerpc tree, so there's no >> need to repost it here. =A0Please, you changed the title of the patch. > > I'm changing the code, My code? If you want to make your own version of spin_event_timeout, then you should change the name and keep it local to your C files. > I removed the ! on the rc. Geert just asked to > have it changed to an in-line too. And Geert's request won't work. --=20 Timur Tabi Linux kernel developer at Freescale