From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D40B2C07E99 for ; Fri, 9 Jul 2021 09:11:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6261D613D3 for ; Fri, 9 Jul 2021 09:11:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6261D613D3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vivier.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45226 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1mYA-0007xq-Hd for qemu-devel@archiver.kernel.org; Fri, 09 Jul 2021 05:11:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46188) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1mXL-00071V-0X; Fri, 09 Jul 2021 05:11:07 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:34701) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1mXI-0004cb-SS; Fri, 09 Jul 2021 05:11:06 -0400 Received: from [192.168.100.1] ([82.142.13.34]) by mrelayeu.kundenserver.de (mreue010 [213.165.67.103]) with ESMTPSA (Nemesis) id 1MF3U0-1lvCxQ2mhU-00FWuu; Fri, 09 Jul 2021 11:11:00 +0200 Subject: Re: [PATCH v2] hw/virtio: Document *_should_notify() are called within rcu_read_lock() To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org, "Michael S. Tsirkin" References: <20210523094040.3516968-1-philmd@redhat.com> <5711b02d-5cc0-414c-eb5c-4e8a7f191088@redhat.com> From: Laurent Vivier Message-ID: Date: Fri, 9 Jul 2021 11:10:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <5711b02d-5cc0-414c-eb5c-4e8a7f191088@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:cXH6m8DZ4cEMFtX97neDUlyfL1uEHposv1ryVVWLeCqRFcQQo74 C+GC42D1eYnbWJ2FmSPPneGjIkC98BxMsnROpGcJr3HUG7vYtZG/jyIcuu5uzlMW2foT0va BqjyU+/pwWx+XvdP55JcJh8WgP9uoFheO46n4CXDN5Pnb+7af7/MIX9oxvQ8WLFPqIT6Ezc Mc2jmWXhT3/gXbm8nlJjQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:Xl9EDk8rP58=:JnaqghsudpT9XaYcP0y9kv tsU5nV1P/0X0NuAXGe092oCQ0ugNvaB7puNqOtrlDGtk2aUkQvAXQtdVKx2UukspUbjRynF8o B2TVTqjeTbEq/CmTCTr0bI0Bv73cTJvGgJ0HIl1znP7LJscH4Hc/lkRHDPt7QVHXCPrpChBIA 3SZVoQ4YRsJS+0IJui+I8RxcLN9NMovU8AVpYNXQzYSn2lyqS5mc0b/SZVTGhSmVh6UFTNVsv CqCvXrsk/98fJ19nkianJ4reBfEQLcAojtngAQx1dWRhorcjG98vApjgV3XljOSf4/zcwNq5n aOocJMwnSXPU2S8Px7SbvHvbZee5rmNjRP9+/NqRi+YWRZ6FHEANz5p+EivfABylIvI34NqM2 q7Qp3QMKbGC/3Qfb4R/gp38J6RwqJ1WS/r4VF+NaBlNQgheco1tFsXV0TU0t4PyywRbP6gWFN dBjz0Nb1mXRr5FOxDi2MHlMvaaq1e0j7kub78P5JVqKE+tJp1vzNQokElA7GlZtWEs9EaeXVC gUvlpSWui7CoZoHxwdyyh78wYsVAyf4cjIz6hyr5vzPBsp+/2i8It1zakMQ+tKE4dIv34gwjc xE4F0FfbdVKB+4R2ZfwuVkQzPtkeDWUUciPkh9ayjTeH5OC8SbQkb1uouNmcVGWOVj+LJLVkc gJORjr+GN3noVdeZIaGgtwjVEKN3LDS9vY1++IU5rD+U/AXsBexl9kvRkBc12/VaBy/m7xR5H 7oUPP4Qn1bq5xWrb46pf4EqFE/rDctwM7qr3kt6FlIOG198zfTSw8mZX3gzTUWt7LLO9ge7iQ vR8HR4UtV1FlV6Gv60VPt9Rh1aPQI4X8kXmfd+YLJkKOCYDOR8WfHWi1/CI4CEMqvZBHoZp Received-SPF: none client-ip=212.227.126.133; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Le 06/07/2021 à 12:04, Philippe Mathieu-Daudé a écrit : > Hi Michael, since I asked a modification on v1, I suppose > this patch is somehow worth in documentation, so I'm > pinging again. It could go via qemu-trival if you ack it. > > On 6/21/21 12:06 PM, Philippe Mathieu-Daudé wrote: >> ping? Applied to my trivial-patches branch. Thanks, Laurent >> On 5/23/21 11:40 AM, Philippe Mathieu-Daudé wrote: >>> Such comments make reviewing this file somehow easier. >>> >>> Signed-off-by: Philippe Mathieu-Daudé >>> --- >>> v2: only one space before end of comment (mst) >>> --- >>> hw/virtio/virtio.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c >>> index e02544b2df7..130e3568409 100644 >>> --- a/hw/virtio/virtio.c >>> +++ b/hw/virtio/virtio.c >>> @@ -2449,6 +2449,7 @@ static void virtio_set_isr(VirtIODevice *vdev, int value) >>> } >>> } >>> >>> +/* Called within rcu_read_lock(). */ >>> static bool virtio_split_should_notify(VirtIODevice *vdev, VirtQueue *vq) >>> { >>> uint16_t old, new; >>> @@ -2485,6 +2486,7 @@ static bool vring_packed_need_event(VirtQueue *vq, bool wrap, >>> return vring_need_event(off, new, old); >>> } >>> >>> +/* Called within rcu_read_lock(). */ >>> static bool virtio_packed_should_notify(VirtIODevice *vdev, VirtQueue *vq) >>> { >>> VRingPackedDescEvent e; >>> >> > >