Re: Patch to fix 'ip' utility recvmsg with ancillary data

[Nicolas Dichtel <nicolas.dichtel@6wind.com>]

Le 14/07/2021 à 10:48, Lahav Daniel Schlesinger a écrit :
> Hi David, thanks for reviewing the patch!
> Here is the updated patch, I hope it's okay now:
> 
> ipmonitor: Fix recvmsg with ancillary data
> 
> A successful call to recvmsg() causes msg.msg_controllen to contain the length
> of the received ancillary data. However, the current code in the 'ip' utility
> doesn't reset this value after each recvmsg().
> 
> This means that if a call to recvmsg() doesn't have ancillary data, then
> 'msg.msg_controllen' will be set to 0, causing future recvmsg() which do
> contain ancillary data to get MSG_CTRUNC set in msg.msg_flags.
> 
> This fixes 'ip monitor' running with the all-nsid option - With this option the
> kernel passes the nsid as ancillary data. If while 'ip monitor' is running an
> even on the current netns is received, then no ancillary data will be sent,
> causing 'msg.msg_controllen' to be set to 0, which causes 'ip monitor' to
> indefinitely print "[nsid current]" instead of the real nsid.
> 
> Fixes: 449b824ad196 ("ipmonitor: allows to monitor in several netns")
> Cc: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> Signed-off-by: Lahav Schlesinger <lschlesinger@drivenets.com>
Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>

[snip]

>> patch looks right. Can you send it as a formal patch with a commit log
>> message, Signed-off-by, etc. See  'git log' for expected format and
>> Documentation/process/submitting-patches.rst in the kernel tree. Make
The format is still unexpected. Please, consider using git send-email.


Regards,
Nicolas