From: Ray Kinsella <mdr@ashroe.eu>
To: David Marchand <david.marchand@redhat.com>,
Pavan Nikhilesh <pbhagavatula@marvell.com>
Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
Andrzej Ostruszka <aostruszka@marvell.com>,
Neil Horman <nhorman@tuxdriver.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
Anoob Joseph <anoobj@marvell.com>,
Thomas Monjalon <thomas@monjalon.net>, dev <dev@dpdk.org>,
Dodji Seketeli <dodji@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v2 1/2] common/octeontx2: move internal symbols to INTERNAL section
Date: Wed, 13 May 2020 10:11:25 +0100 [thread overview]
Message-ID: <ed9c4f23-5f87-7fc0-dcc3-c5a29168d4f0@ashroe.eu> (raw)
In-Reply-To: <CAJFAV8y9QzvVRBbv_VNtvQY+S5MMA2tN8bNf2jSc4v9UMV2uYA@mail.gmail.com>
On 13/05/2020 09:58, David Marchand wrote:
> On Wed, May 13, 2020 at 3:05 AM <pbhagavatula@marvell.com> wrote:
>> diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore
>> index c9ee73cb3..dfe346db4 100644
>> --- a/devtools/libabigail.abignore
>> +++ b/devtools/libabigail.abignore
>> @@ -48,3 +48,7 @@
>> changed_enumerators = RTE_CRYPTO_AEAD_LIST_END
>> [suppress_variable]
>> name = rte_crypto_aead_algorithm_strings
>> +
>> +; Ignore moving internal OCTEONTX2 stable functions to INTERNAL tag
>> +[suppress_file]
>> + soname_regexp = librte_common_octeontx2.*
>
> This syntax will work with libabigail (current master and 1.7), but
> not with older versions like the 1.6 we use in Travis:
> https://travis-ci.com/github/david-marchand/dpdk/jobs/333080901#L2387
>
> mlx common drivers were handled with the file_name_regexp syntax.
> https://git.dpdk.org/next/dpdk-next-net-mlx/diff/devtools/libabigail.abignore?id=196ca2dfc05df7685b86aba8cdd657b4aa401ffa
>
>
> Rather than bump to 1.7 in Travis, my preference goes to using a
> single syntax for those exceptions.
>
> Ray, opinion?
>
We need to aim for lowest common denominator support.
Ubuntu 20.04 shipped with 1.6
Ubuntu 20.04 shipped with 1.2 (however I suspect we will soon be depreciating this).
CentOS 8/7 EPEL both ship with 1.7
Supporting 1.6 is a reasonable choice.
Ray K
next prev parent reply other threads:[~2020-05-13 9:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 10:00 [dpdk-dev] [PATCH 1/2] common/octeontx2: move internal symbols to INTERNAL section pbhagavatula
2020-05-11 10:00 ` [dpdk-dev] [PATCH 2/2] mempool/octeontx2: " pbhagavatula
2020-05-11 14:45 ` [dpdk-dev] [PATCH 1/2] common/octeontx2: " Thomas Monjalon
2020-05-13 1:04 ` [dpdk-dev] [PATCH v2 " pbhagavatula
2020-05-13 1:04 ` [dpdk-dev] [PATCH v2 2/2] mempool/octeontx2: " pbhagavatula
2020-05-13 8:58 ` [dpdk-dev] [PATCH v2 1/2] common/octeontx2: " David Marchand
2020-05-13 9:11 ` Ray Kinsella [this message]
2020-05-13 9:51 ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula
2020-05-13 9:55 ` [dpdk-dev] [PATCH v3 " pbhagavatula
2020-05-13 9:55 ` [dpdk-dev] [PATCH v3 2/2] mempool/octeontx2: " pbhagavatula
2020-05-14 7:02 ` [dpdk-dev] [PATCH v2 1/2] common/octeontx2: " Ray Kinsella
2020-05-14 12:50 ` David Marchand
2020-05-18 15:51 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed9c4f23-5f87-7fc0-dcc3-c5a29168d4f0@ashroe.eu \
--to=mdr@ashroe.eu \
--cc=anoobj@marvell.com \
--cc=aostruszka@marvell.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dodji@redhat.com \
--cc=jerinj@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=nhorman@tuxdriver.com \
--cc=pbhagavatula@marvell.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.