From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51840C43334 for ; Mon, 13 Jun 2022 20:10:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Y20AWzTFCMeJVT09lPSA74iffVIT1XOgGcep3v17WYg=; b=Ickt+nOvFX7D3i nsAXrToyk0YgdAi9cdEuakRnwbEHy1TVKLEWf+qV79+qxY7PlakIq5L0lpoxT+xmUpG6zXAiKON/f 0CmdxykFHyl9sNfYPMxp6ciaOwkzbuw4fAlKZdJXfogzOh4Nv7iDlfgcbRgP30e1fCNaMjGuXooFV t3yFGw6zeqdF2LYjQ4bwQQAT8Nq8yFbSsz3C4lfsT4SyoYpDKPqJL2ena/yk+ml9LOks7btUj9mgz uNmeaNoILBmQz4bcxcCw+o0YTKfi5GlpgXcdhfGE7p9qeH/THlblfO+29L981NCqZX/i62g7d51kC 6U4I/xlfz849jXvVv5gQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o0qOK-005WV6-Hz; Mon, 13 Jun 2022 20:10:28 +0000 Received: from mail-qk1-x736.google.com ([2607:f8b0:4864:20::736]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o0qO4-005WL9-7I for linux-mediatek@lists.infradead.org; Mon, 13 Jun 2022 20:10:14 +0000 Received: by mail-qk1-x736.google.com with SMTP id n197so4908427qke.1 for ; Mon, 13 Jun 2022 13:10:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ndufresne-ca.20210112.gappssmtp.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :content-transfer-encoding:user-agent:mime-version; bh=v7I9W+KWz8qCcwRO9hK+FauPyteN/yVzDhLqH8wmqRU=; b=qUfbsn7KlSJMoOLXI6w6yy7TrJ1t3GV0eaUVEpVlSmhhSGPrIysNUeydu8ibydKY2p 1zMc9WXdAnvTmzm/lrM27CFeS6jhwcwhiZx2Ch+XXMkguFXByWQ1/3m9I+9pp8etU2CF wrkQRVC0U5MG0ta45bpCFNsfYcLbmavJSAPP3NEu/pDmPwFapsEotpifbzYcKQ5wkiL4 dAYl9wue9Te1yAbLZJE0fxDNbbZKuu1H0mwbDD3ztzuhlxwL2jF0RXF9WlqjiHKqlmm8 +eZ7tSpup8IssWLJOtSXTNAsUlDpf5nuAlDTqiciGANTlc+VgbcwYDZbXTeCqb3jVEOo vXRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=v7I9W+KWz8qCcwRO9hK+FauPyteN/yVzDhLqH8wmqRU=; b=j5W6WhHGN81EZKB7Vv8eJ+W7dBFBMoqGZVqtdBEgP9FLIuFTDyNEN2TzmGF2YdhKj9 iA5YQkRGTVdowv9czOT/Z2Z5SFc1HJ8is2fUQHFfjR1xJnp6P/iyg9li75+u5v221oUT rln1HNQQk/tFDZxUiwGiLuDcjsvU+198go7S70qTZmFTqA+kORuMf5Ce1DowqHcLu9Wt YdeDrQEs1ScSeBkcAJeL3hncFGILU0hGOFpTGRLAvoUU60Pvd6WTBjGQBjDwvv+hXOs9 lved+OzJQv54JfNfhkD+l7h5cLCIlMS0fQWnc/PYxbY8QnLsSqHOwqJOiyVYT/Z+xo0U vfMQ== X-Gm-Message-State: AOAM532ssGD7+KB+pe/ddCMAQToJsKid3SbK1BjXBC2yiaTQnqYCKuaU yk+ClfoXzUx6reLhF/bZ0fCRIg== X-Google-Smtp-Source: ABdhPJypEb0jxGKtk5VfHQekdsoaNysCZ3OatxB9gwkAI+QgXupZeQPtmwZAmNKNz+Dgb1z5OMMIwQ== X-Received: by 2002:a05:620a:4e9:b0:6a7:8357:303d with SMTP id b9-20020a05620a04e900b006a78357303dmr1407957qkh.105.1655151007308; Mon, 13 Jun 2022 13:10:07 -0700 (PDT) Received: from nicolas-tpx395.localdomain (192-222-136-102.qc.cable.ebox.net. [192.222.136.102]) by smtp.gmail.com with ESMTPSA id r13-20020a05620a298d00b006a6d60a39d0sm8268202qkp.5.2022.06.13.13.10.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jun 2022 13:10:06 -0700 (PDT) Message-ID: Subject: Re: [PATCH v4, 0/3] add h264 decoder driver for mt8186 From: Nicolas Dufresne To: Yunfei Dong , Alexandre Courbot , Hans Verkuil , AngeloGioacchino Del Regno , Benjamin Gaignard , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa Cc: George Sun , Xiaoyong Lu , Hsin-Yi Wang , Fritz Koenig , Daniel Vetter , dri-devel , Irui Wang , Steve Cho , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com Date: Mon, 13 Jun 2022 16:10:05 -0400 In-Reply-To: <20220512034620.30500-1-yunfei.dong@mediatek.com> References: <20220512034620.30500-1-yunfei.dong@mediatek.com> User-Agent: Evolution 3.44.1 (3.44.1-1.fc36) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220613_131012_356960_BA5D0A09 X-CRM114-Status: GOOD ( 16.06 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org TGUgamV1ZGkgMTIgbWFpIDIwMjIgw6AgMTE6NDYgKzA4MDAsIFl1bmZlaSBEb25nIGEgw6ljcml0 wqA6Cj4gRmlyc3RseSwgYWRkIG10ODE4NiBjb21wYXRpYmxlIGFuZCBwcml2YXRlIGRhdGEsIHRo ZW4gYWRkIGRvY3VtZW50IGZvcgo+IGNvbXBhdGlibGUgIm1lZGlhdGVrLG10ODE4Ni12Y29kZWMt ZGVjIi4gRm9yIG10ODE4NiBpcyBzaW5nbGUgY29yZQo+IGFyY2hpdGVjdHVyZSwgbmVlZCB0byBh ZGQgbmV3IGludGVyZmFjZSBmb3IgaDI2NCBoYXJkd2FyZSBkZWNvZGVyLgoKV291bGQgYmUgbmlj ZSB0byB0YWtlIHRoZSBoYWJpdCBvZiBzaGFyaW5nIGZsdXN0ZXIgc2NvcmUgZm9yIHRoaXMgbmV3 IEhXLCBJCndvdWxkIGV4cGVjdCBubyBsZXNzIHRoZW4gd2hhdCB0aGUgbnVtYmVycyB5b3UnZCBn ZXQgZnJvbSBydW5uaW5nIG92ZXIgTVQ4MTk1IG9yCjkyLCByZW1haW5zIG5pY2UgdG8gZGVtb25z dHJhdGUgdGhhdCB0aGlzIHdhcyB0ZXN0ZWQgYW5kIGRvY3VtZW50IGFueSBvb3BzIGFsb25nCnRo ZSB3YXkuCj4gCj4gUGF0Y2hlIDEgYWRkIG10ODE4NiBjb21wYXRpYmxlIGFuZCBwcml2YXRlIGRh dGEuCj4gUGF0Y2hlIDIgYWRkIG10ODE4NiBjb21wYXRpYmxlIGRvY3VtZW50Lgo+IFBhdGNoZSAz IGFkZCBoMjY0IHNpbmdsZSBjb3JlIGRyaXZlci4KPiAtLS0KPiBUaGlzIHBhdGNoIGRlcGVuZHMg b24gInN1cHBvcnQgZm9yIE1UODE5MiBkZWNvZGVyIlsxXQo+IAo+IFsxXSAgaHR0cHM6Ly9wYXRj aHdvcmsua2VybmVsLm9yZy9wcm9qZWN0L2xpbnV4LW1lZGlhdGVrL2NvdmVyLzIwMjIwNTEyMDIx OTUwLjI5MDg3LTEteXVuZmVpLmRvbmdAbWVkaWF0ZWsuY29tLwo+IC0tLQo+IGNoYW5nZWQgd2l0 aCB2MzoKPiAtIGZpeCBfX2lvbWVtIG5vdCByZWFzb25hYmxlLCBhbGlnbiBzaGFyZSBtZW1vcnkg dG8gZHJhbS4KPiBjaGFuZ2VkIHdpdGggdjI6Cj4gLSBmaXggc3BhcnNlIGFuZCBzbWF0Y2ggY2hl Y2sgZmFpbCBmb3IgcGF0Y2ggMwo+IGNoYW5nZWQgd2l0aCB2MToKPiAtIHJlYmFzZSBkcml2ZXIg dG8gdGhlIGxhdGVzdCBtZWRpYV9zdGFnZS4KPiAtLS0KPiBZdW5mZWkgRG9uZyAoMyk6Cj4gICBk dC1iaW5kaW5nczogbWVkaWE6IG1lZGlhdGVrOiB2Y29kZWM6IEFkZHMgZGVjb2RlciBkdC1iaW5k aW5ncyBmb3IKPiAgICAgbXQ4MTg2Cj4gICBtZWRpYTogbWVkaWF0ZWs6IHZjb2RlYzogU3VwcG9y dCBNVDgxODYKPiAgIG1lZGlhOiBtZWRpYXRlazogdmNvZGVjOiBhZGQgaDI2NCBkZWNvZGVyIGRy aXZlciBmb3IgbXQ4MTg2Cj4gCj4gIC4uLi9tZWRpYS9tZWRpYXRlayx2Y29kZWMtc3ViZGV2LWRl Y29kZXIueWFtbCB8ICAgNCArLQo+ICAuLi4vcGxhdGZvcm0vbWVkaWF0ZWsvdmNvZGVjL210a192 Y29kZWNfZGVjLmggfCAgIDEgKwo+ICAuLi4vbWVkaWF0ZWsvdmNvZGVjL210a192Y29kZWNfZGVj X2Rydi5jICAgICAgfCAgIDQgKwo+ICAuLi4vdmNvZGVjL210a192Y29kZWNfZGVjX3N0YXRlbGVz cy5jICAgICAgICAgfCAgMTkgKysKPiAgLi4uL3Zjb2RlYy92ZGVjL3ZkZWNfaDI2NF9yZXFfbXVs dGlfaWYuYyAgICAgIHwgMTc3ICsrKysrKysrKysrKysrKysrLQo+ICA1IGZpbGVzIGNoYW5nZWQs IDIwMyBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+IAoKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LW1lZGlhdGVrIG1haWxpbmcgbGlz dApMaW51eC1tZWRpYXRla0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbWVkaWF0ZWsK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 81A5EC433EF for ; Mon, 13 Jun 2022 20:10:10 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D5D2610F7DA; Mon, 13 Jun 2022 20:10:09 +0000 (UTC) Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4D3E610F7E5 for ; Mon, 13 Jun 2022 20:10:08 +0000 (UTC) Received: by mail-qk1-x72c.google.com with SMTP id b142so4901125qkg.2 for ; Mon, 13 Jun 2022 13:10:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ndufresne-ca.20210112.gappssmtp.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :content-transfer-encoding:user-agent:mime-version; bh=v7I9W+KWz8qCcwRO9hK+FauPyteN/yVzDhLqH8wmqRU=; b=qUfbsn7KlSJMoOLXI6w6yy7TrJ1t3GV0eaUVEpVlSmhhSGPrIysNUeydu8ibydKY2p 1zMc9WXdAnvTmzm/lrM27CFeS6jhwcwhiZx2Ch+XXMkguFXByWQ1/3m9I+9pp8etU2CF wrkQRVC0U5MG0ta45bpCFNsfYcLbmavJSAPP3NEu/pDmPwFapsEotpifbzYcKQ5wkiL4 dAYl9wue9Te1yAbLZJE0fxDNbbZKuu1H0mwbDD3ztzuhlxwL2jF0RXF9WlqjiHKqlmm8 +eZ7tSpup8IssWLJOtSXTNAsUlDpf5nuAlDTqiciGANTlc+VgbcwYDZbXTeCqb3jVEOo vXRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=v7I9W+KWz8qCcwRO9hK+FauPyteN/yVzDhLqH8wmqRU=; b=whI7MnJdRlkMGRkxr0w8ztwRChZT1CL6FaRfx5OZrXkRZcyR3AnvblTWFy9xsbOTRS 7s914juMIG5veDVPc9bHBTmoKR5NGdkpOAul9540jtyk0/Uk5Yn8Mv1y7oiWWCZOsMhM /FhnCkS5ap7rYRKjwzxsbwxZP5KtURFzjg/xAvD63C1Vu/eysdMnUZqZ3YdmXC/rTO+T +MdAV1HhD2Nrli9JDz8GLFopzGI2K2bLOSQb57QEBKGhQF4ToJHk4l+d+Tq5/VQKrp7n g1FOQ3/wdyJIpRP7nB+T5ifMevdUHvUOqD725Q9C4XZdT+fu1SQdxhnQwpWhGzm7Icoq 33vg== X-Gm-Message-State: AOAM532k7Nz95rTN00YaD6/GSJ7uwvpUKGSINwG6rIMCdLsyIe+t+vM1 DYnlLU48SShe+0s7j0DyrpoW8A== X-Google-Smtp-Source: ABdhPJypEb0jxGKtk5VfHQekdsoaNysCZ3OatxB9gwkAI+QgXupZeQPtmwZAmNKNz+Dgb1z5OMMIwQ== X-Received: by 2002:a05:620a:4e9:b0:6a7:8357:303d with SMTP id b9-20020a05620a04e900b006a78357303dmr1407957qkh.105.1655151007308; Mon, 13 Jun 2022 13:10:07 -0700 (PDT) Received: from nicolas-tpx395.localdomain (192-222-136-102.qc.cable.ebox.net. [192.222.136.102]) by smtp.gmail.com with ESMTPSA id r13-20020a05620a298d00b006a6d60a39d0sm8268202qkp.5.2022.06.13.13.10.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jun 2022 13:10:06 -0700 (PDT) Message-ID: Subject: Re: [PATCH v4, 0/3] add h264 decoder driver for mt8186 From: Nicolas Dufresne To: Yunfei Dong , Alexandre Courbot , Hans Verkuil , AngeloGioacchino Del Regno , Benjamin Gaignard , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa Date: Mon, 13 Jun 2022 16:10:05 -0400 In-Reply-To: <20220512034620.30500-1-yunfei.dong@mediatek.com> References: <20220512034620.30500-1-yunfei.dong@mediatek.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.1 (3.44.1-1.fc36) MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Irui Wang , George Sun , Steve Cho , devicetree@vger.kernel.org, Project_Global_Chrome_Upstream_Group@mediatek.com, linux-kernel@vger.kernel.org, dri-devel , Xiaoyong Lu , linux-mediatek@lists.infradead.org, Hsin-Yi Wang , Fritz Koenig , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Le jeudi 12 mai 2022 =C3=A0 11:46 +0800, Yunfei Dong a =C3=A9crit=C2=A0: > Firstly, add mt8186 compatible and private data, then add document for > compatible "mediatek,mt8186-vcodec-dec". For mt8186 is single core > architecture, need to add new interface for h264 hardware decoder. Would be nice to take the habit of sharing fluster score for this new HW, I would expect no less then what the numbers you'd get from running over MT81= 95 or 92, remains nice to demonstrate that this was tested and document any oops = along the way. >=20 > Patche 1 add mt8186 compatible and private data. > Patche 2 add mt8186 compatible document. > Patche 3 add h264 single core driver. > --- > This patch depends on "support for MT8192 decoder"[1] >=20 > [1] https://patchwork.kernel.org/project/linux-mediatek/cover/2022051202= 1950.29087-1-yunfei.dong@mediatek.com/ > --- > changed with v3: > - fix __iomem not reasonable, align share memory to dram. > changed with v2: > - fix sparse and smatch check fail for patch 3 > changed with v1: > - rebase driver to the latest media_stage. > --- > Yunfei Dong (3): > dt-bindings: media: mediatek: vcodec: Adds decoder dt-bindings for > mt8186 > media: mediatek: vcodec: Support MT8186 > media: mediatek: vcodec: add h264 decoder driver for mt8186 >=20 > .../media/mediatek,vcodec-subdev-decoder.yaml | 4 +- > .../platform/mediatek/vcodec/mtk_vcodec_dec.h | 1 + > .../mediatek/vcodec/mtk_vcodec_dec_drv.c | 4 + > .../vcodec/mtk_vcodec_dec_stateless.c | 19 ++ > .../vcodec/vdec/vdec_h264_req_multi_if.c | 177 +++++++++++++++++- > 5 files changed, 203 insertions(+), 2 deletions(-) >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3E743C43334 for ; Mon, 13 Jun 2022 20:11:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=m6nC0d4TvQscFwflmU3T5Z6bIGIcHWSnXqzQmhe8Nxw=; b=EyoE0tA8GCP3ON qz4lLN/6A3wakWJqNNWz6SzVijm2jrCAGQoMQnv08qS70RRs6PTkzE4I8tKfmcI8nwKbeDWMrwqj2 rsrwS8PmMtQT1WG72PY6cP7aFhk7CloEL4y4Jna9q1UKy0srMArHm0Gz31WUzlgHwK/w6FecX13Zn jLefb/8GXWcf3zdxF4GxioHa2jWrLhDAfeT3qrNob8IzT43PTaApj63eyTL52fiUEL0fFf4NL7sko dztkF7+8L8PivgqHSSKGP0jWVqWv+GQnPvtnl2EJ4V5QJtkkn82pn2XIAmIXK2bfsC7jVURi+7O0O /34RZ+GBoJ7rV3oN9NjA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o0qO7-005WPn-Mn; Mon, 13 Jun 2022 20:10:15 +0000 Received: from mail-qk1-x72a.google.com ([2607:f8b0:4864:20::72a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o0qO4-005WL8-7J for linux-arm-kernel@lists.infradead.org; Mon, 13 Jun 2022 20:10:14 +0000 Received: by mail-qk1-x72a.google.com with SMTP id 15so4888167qki.6 for ; Mon, 13 Jun 2022 13:10:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ndufresne-ca.20210112.gappssmtp.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :content-transfer-encoding:user-agent:mime-version; bh=v7I9W+KWz8qCcwRO9hK+FauPyteN/yVzDhLqH8wmqRU=; b=qUfbsn7KlSJMoOLXI6w6yy7TrJ1t3GV0eaUVEpVlSmhhSGPrIysNUeydu8ibydKY2p 1zMc9WXdAnvTmzm/lrM27CFeS6jhwcwhiZx2Ch+XXMkguFXByWQ1/3m9I+9pp8etU2CF wrkQRVC0U5MG0ta45bpCFNsfYcLbmavJSAPP3NEu/pDmPwFapsEotpifbzYcKQ5wkiL4 dAYl9wue9Te1yAbLZJE0fxDNbbZKuu1H0mwbDD3ztzuhlxwL2jF0RXF9WlqjiHKqlmm8 +eZ7tSpup8IssWLJOtSXTNAsUlDpf5nuAlDTqiciGANTlc+VgbcwYDZbXTeCqb3jVEOo vXRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=v7I9W+KWz8qCcwRO9hK+FauPyteN/yVzDhLqH8wmqRU=; b=ycAfhExJfZ1tAQWzyj4WBtI4Ck96Tcn01kaYHdGIl5f85lBJhAHIaWzjk62lqFY2aH eLFWAndwqxHVHqtndubrz97YH2UPEHE/TVtK7mkuiabVmrZKCkEmJPJayPpqCvShSqSe OlfSRdmiqKhjuYID5boV5CU68EBiyfObvcAwsZOsItzyIUCcsR9mw1W8jCXA4GmVTHVu 8bhBCjBE5vwxJW47qWEZDILojDmnCNZCB0kMnxgmK+Hm0on8unFfoX7gdHAJAsK82HBt 020+Ede9AC+XxZ8P6CVOE6RZhXvnuYEeIxLQSKBymgvpPl4+H+slFg0RaTb109wZRVZ4 I2/A== X-Gm-Message-State: AOAM531hs+Xd56plE+zI2PEpUIrnEvD/O1Cbol8UZ6eVZthsoln9c1nv D/JvHBw4OON0MjHX9ugfnXhPOQ== X-Google-Smtp-Source: ABdhPJypEb0jxGKtk5VfHQekdsoaNysCZ3OatxB9gwkAI+QgXupZeQPtmwZAmNKNz+Dgb1z5OMMIwQ== X-Received: by 2002:a05:620a:4e9:b0:6a7:8357:303d with SMTP id b9-20020a05620a04e900b006a78357303dmr1407957qkh.105.1655151007308; Mon, 13 Jun 2022 13:10:07 -0700 (PDT) Received: from nicolas-tpx395.localdomain (192-222-136-102.qc.cable.ebox.net. [192.222.136.102]) by smtp.gmail.com with ESMTPSA id r13-20020a05620a298d00b006a6d60a39d0sm8268202qkp.5.2022.06.13.13.10.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jun 2022 13:10:06 -0700 (PDT) Message-ID: Subject: Re: [PATCH v4, 0/3] add h264 decoder driver for mt8186 From: Nicolas Dufresne To: Yunfei Dong , Alexandre Courbot , Hans Verkuil , AngeloGioacchino Del Regno , Benjamin Gaignard , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa Cc: George Sun , Xiaoyong Lu , Hsin-Yi Wang , Fritz Koenig , Daniel Vetter , dri-devel , Irui Wang , Steve Cho , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com Date: Mon, 13 Jun 2022 16:10:05 -0400 In-Reply-To: <20220512034620.30500-1-yunfei.dong@mediatek.com> References: <20220512034620.30500-1-yunfei.dong@mediatek.com> User-Agent: Evolution 3.44.1 (3.44.1-1.fc36) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220613_131012_343074_CC960BFC X-CRM114-Status: GOOD ( 17.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org TGUgamV1ZGkgMTIgbWFpIDIwMjIgw6AgMTE6NDYgKzA4MDAsIFl1bmZlaSBEb25nIGEgw6ljcml0 wqA6Cj4gRmlyc3RseSwgYWRkIG10ODE4NiBjb21wYXRpYmxlIGFuZCBwcml2YXRlIGRhdGEsIHRo ZW4gYWRkIGRvY3VtZW50IGZvcgo+IGNvbXBhdGlibGUgIm1lZGlhdGVrLG10ODE4Ni12Y29kZWMt ZGVjIi4gRm9yIG10ODE4NiBpcyBzaW5nbGUgY29yZQo+IGFyY2hpdGVjdHVyZSwgbmVlZCB0byBh ZGQgbmV3IGludGVyZmFjZSBmb3IgaDI2NCBoYXJkd2FyZSBkZWNvZGVyLgoKV291bGQgYmUgbmlj ZSB0byB0YWtlIHRoZSBoYWJpdCBvZiBzaGFyaW5nIGZsdXN0ZXIgc2NvcmUgZm9yIHRoaXMgbmV3 IEhXLCBJCndvdWxkIGV4cGVjdCBubyBsZXNzIHRoZW4gd2hhdCB0aGUgbnVtYmVycyB5b3UnZCBn ZXQgZnJvbSBydW5uaW5nIG92ZXIgTVQ4MTk1IG9yCjkyLCByZW1haW5zIG5pY2UgdG8gZGVtb25z dHJhdGUgdGhhdCB0aGlzIHdhcyB0ZXN0ZWQgYW5kIGRvY3VtZW50IGFueSBvb3BzIGFsb25nCnRo ZSB3YXkuCj4gCj4gUGF0Y2hlIDEgYWRkIG10ODE4NiBjb21wYXRpYmxlIGFuZCBwcml2YXRlIGRh dGEuCj4gUGF0Y2hlIDIgYWRkIG10ODE4NiBjb21wYXRpYmxlIGRvY3VtZW50Lgo+IFBhdGNoZSAz IGFkZCBoMjY0IHNpbmdsZSBjb3JlIGRyaXZlci4KPiAtLS0KPiBUaGlzIHBhdGNoIGRlcGVuZHMg b24gInN1cHBvcnQgZm9yIE1UODE5MiBkZWNvZGVyIlsxXQo+IAo+IFsxXSAgaHR0cHM6Ly9wYXRj aHdvcmsua2VybmVsLm9yZy9wcm9qZWN0L2xpbnV4LW1lZGlhdGVrL2NvdmVyLzIwMjIwNTEyMDIx OTUwLjI5MDg3LTEteXVuZmVpLmRvbmdAbWVkaWF0ZWsuY29tLwo+IC0tLQo+IGNoYW5nZWQgd2l0 aCB2MzoKPiAtIGZpeCBfX2lvbWVtIG5vdCByZWFzb25hYmxlLCBhbGlnbiBzaGFyZSBtZW1vcnkg dG8gZHJhbS4KPiBjaGFuZ2VkIHdpdGggdjI6Cj4gLSBmaXggc3BhcnNlIGFuZCBzbWF0Y2ggY2hl Y2sgZmFpbCBmb3IgcGF0Y2ggMwo+IGNoYW5nZWQgd2l0aCB2MToKPiAtIHJlYmFzZSBkcml2ZXIg dG8gdGhlIGxhdGVzdCBtZWRpYV9zdGFnZS4KPiAtLS0KPiBZdW5mZWkgRG9uZyAoMyk6Cj4gICBk dC1iaW5kaW5nczogbWVkaWE6IG1lZGlhdGVrOiB2Y29kZWM6IEFkZHMgZGVjb2RlciBkdC1iaW5k aW5ncyBmb3IKPiAgICAgbXQ4MTg2Cj4gICBtZWRpYTogbWVkaWF0ZWs6IHZjb2RlYzogU3VwcG9y dCBNVDgxODYKPiAgIG1lZGlhOiBtZWRpYXRlazogdmNvZGVjOiBhZGQgaDI2NCBkZWNvZGVyIGRy aXZlciBmb3IgbXQ4MTg2Cj4gCj4gIC4uLi9tZWRpYS9tZWRpYXRlayx2Y29kZWMtc3ViZGV2LWRl Y29kZXIueWFtbCB8ICAgNCArLQo+ICAuLi4vcGxhdGZvcm0vbWVkaWF0ZWsvdmNvZGVjL210a192 Y29kZWNfZGVjLmggfCAgIDEgKwo+ICAuLi4vbWVkaWF0ZWsvdmNvZGVjL210a192Y29kZWNfZGVj X2Rydi5jICAgICAgfCAgIDQgKwo+ICAuLi4vdmNvZGVjL210a192Y29kZWNfZGVjX3N0YXRlbGVz cy5jICAgICAgICAgfCAgMTkgKysKPiAgLi4uL3Zjb2RlYy92ZGVjL3ZkZWNfaDI2NF9yZXFfbXVs dGlfaWYuYyAgICAgIHwgMTc3ICsrKysrKysrKysrKysrKysrLQo+ICA1IGZpbGVzIGNoYW5nZWQs IDIwMyBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+IAoKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBs aXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5m cmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2E03C43334 for ; Mon, 13 Jun 2022 20:52:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347001AbiFMUwu (ORCPT ); Mon, 13 Jun 2022 16:52:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236213AbiFMUwM (ORCPT ); Mon, 13 Jun 2022 16:52:12 -0400 Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [IPv6:2607:f8b0:4864:20::735]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D58FE0C8 for ; Mon, 13 Jun 2022 13:10:08 -0700 (PDT) Received: by mail-qk1-x735.google.com with SMTP id p63so4871320qkd.10 for ; Mon, 13 Jun 2022 13:10:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ndufresne-ca.20210112.gappssmtp.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :content-transfer-encoding:user-agent:mime-version; bh=v7I9W+KWz8qCcwRO9hK+FauPyteN/yVzDhLqH8wmqRU=; b=qUfbsn7KlSJMoOLXI6w6yy7TrJ1t3GV0eaUVEpVlSmhhSGPrIysNUeydu8ibydKY2p 1zMc9WXdAnvTmzm/lrM27CFeS6jhwcwhiZx2Ch+XXMkguFXByWQ1/3m9I+9pp8etU2CF wrkQRVC0U5MG0ta45bpCFNsfYcLbmavJSAPP3NEu/pDmPwFapsEotpifbzYcKQ5wkiL4 dAYl9wue9Te1yAbLZJE0fxDNbbZKuu1H0mwbDD3ztzuhlxwL2jF0RXF9WlqjiHKqlmm8 +eZ7tSpup8IssWLJOtSXTNAsUlDpf5nuAlDTqiciGANTlc+VgbcwYDZbXTeCqb3jVEOo vXRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=v7I9W+KWz8qCcwRO9hK+FauPyteN/yVzDhLqH8wmqRU=; b=mG2Vo/jAqbxbcS5vLu5idJiZknP0rpoj8rpzcQ3EU7WgH2Dxmj8vLcJ5umDhWVHs8L cYdlfZJzTP6Z2CxGp/N9l5cyOvjutz02LXKQF3+T3N4lhQt42pNfYFAC+MiVZpPF2Eyx hIvBZhKkykNoatXqd2sZL5vxl+YvqQBAVEjbNCDqLIOCwOvfpis/WdPwP7lO4HnKeeUw Ph4IM5f07DpwxlTXz8SGp7dLTxFz3Hj5MVgzFQYtvYjUw0IlewchxyUj+YOuGBfckynq FvOPd45mmACdgIN7a4oOrezOIqoyf2ZbOxWWF/W9cIzRm+gto6eCplaAH8wi1TXQ9zwI kusw== X-Gm-Message-State: AOAM532D8zYBbRn0KW4Tc+xi1wo+Iny8eNLsZ7tEalu6MGCO/RS1LxIA MW0lWVIuKczmRJPNMD6Qg7vSPQ== X-Google-Smtp-Source: ABdhPJypEb0jxGKtk5VfHQekdsoaNysCZ3OatxB9gwkAI+QgXupZeQPtmwZAmNKNz+Dgb1z5OMMIwQ== X-Received: by 2002:a05:620a:4e9:b0:6a7:8357:303d with SMTP id b9-20020a05620a04e900b006a78357303dmr1407957qkh.105.1655151007308; Mon, 13 Jun 2022 13:10:07 -0700 (PDT) Received: from nicolas-tpx395.localdomain (192-222-136-102.qc.cable.ebox.net. [192.222.136.102]) by smtp.gmail.com with ESMTPSA id r13-20020a05620a298d00b006a6d60a39d0sm8268202qkp.5.2022.06.13.13.10.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jun 2022 13:10:06 -0700 (PDT) Message-ID: Subject: Re: [PATCH v4, 0/3] add h264 decoder driver for mt8186 From: Nicolas Dufresne To: Yunfei Dong , Alexandre Courbot , Hans Verkuil , AngeloGioacchino Del Regno , Benjamin Gaignard , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa Cc: George Sun , Xiaoyong Lu , Hsin-Yi Wang , Fritz Koenig , Daniel Vetter , dri-devel , Irui Wang , Steve Cho , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com Date: Mon, 13 Jun 2022 16:10:05 -0400 In-Reply-To: <20220512034620.30500-1-yunfei.dong@mediatek.com> References: <20220512034620.30500-1-yunfei.dong@mediatek.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.1 (3.44.1-1.fc36) MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le jeudi 12 mai 2022 =C3=A0 11:46 +0800, Yunfei Dong a =C3=A9crit=C2=A0: > Firstly, add mt8186 compatible and private data, then add document for > compatible "mediatek,mt8186-vcodec-dec". For mt8186 is single core > architecture, need to add new interface for h264 hardware decoder. Would be nice to take the habit of sharing fluster score for this new HW, I would expect no less then what the numbers you'd get from running over MT81= 95 or 92, remains nice to demonstrate that this was tested and document any oops = along the way. >=20 > Patche 1 add mt8186 compatible and private data. > Patche 2 add mt8186 compatible document. > Patche 3 add h264 single core driver. > --- > This patch depends on "support for MT8192 decoder"[1] >=20 > [1] https://patchwork.kernel.org/project/linux-mediatek/cover/2022051202= 1950.29087-1-yunfei.dong@mediatek.com/ > --- > changed with v3: > - fix __iomem not reasonable, align share memory to dram. > changed with v2: > - fix sparse and smatch check fail for patch 3 > changed with v1: > - rebase driver to the latest media_stage. > --- > Yunfei Dong (3): > dt-bindings: media: mediatek: vcodec: Adds decoder dt-bindings for > mt8186 > media: mediatek: vcodec: Support MT8186 > media: mediatek: vcodec: add h264 decoder driver for mt8186 >=20 > .../media/mediatek,vcodec-subdev-decoder.yaml | 4 +- > .../platform/mediatek/vcodec/mtk_vcodec_dec.h | 1 + > .../mediatek/vcodec/mtk_vcodec_dec_drv.c | 4 + > .../vcodec/mtk_vcodec_dec_stateless.c | 19 ++ > .../vcodec/vdec/vdec_h264_req_multi_if.c | 177 +++++++++++++++++- > 5 files changed, 203 insertions(+), 2 deletions(-) >=20