From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753661AbdDKU7M (ORCPT ); Tue, 11 Apr 2017 16:59:12 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:35986 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753618AbdDKU7K (ORCPT ); Tue, 11 Apr 2017 16:59:10 -0400 Subject: Re: [PATCH net-next] net: dsa: add CONFIG_NET_DSA_LEGACY To: Vivien Didelot , netdev@vger.kernel.org References: <20170411205237.29309-1-vivien.didelot@savoirfairelinux.com> Cc: linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Andrew Lunn From: Florian Fainelli Message-ID: Date: Tue, 11 Apr 2017 13:59:08 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170411205237.29309-1-vivien.didelot@savoirfairelinux.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/11/2017 01:52 PM, Vivien Didelot wrote: > This patch moves as is the legacy DSA code from dsa.c to legacy.c, > except the few shared symbols which remain in dsa.c. > > Compile legacy.o only if a new CONFIG_NET_DSA_LEGACY symbol is enabled, > which is true by default. > > DSA drivers without legacy support don't need the probe function as well > as driver registration helpers anymore, so remove their definitions if > CONFIG_NET_DSA_LEGACY is disabled. > > NET_DSA_MV88E6060 and NET_DSA_BCM_SF2 now depend on the legacy support. BCM_SF2 is not dependent on legacy support since it got converted to the new API in the past few months. You may want to generate your patch with git format-patch -M to help detect renames/code movements. Thanks for doing this! -- Florian