From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from foss.arm.com ([217.140.101.70]:47280 "EHLO foss.arm.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S935346AbeFMNBa (ORCPT <rfc822;stable@vger.kernel.org>);
        Wed, 13 Jun 2018 09:01:30 -0400
Subject: Re: [PATCH v4 2/2] drm/rockchip: vop: fix irq disabled after vop
 driver probed
To: Heiko Stuebner <heiko@sntech.de>, dri-devel@lists.freedesktop.org
Cc: linux-rockchip@lists.infradead.org, ezequiel@collabora.com,
        tfiga@chromium.org, robin.murphy@arm.com,
        jeffy.chen@rock-chips.com, hjc@rock-chips.com,
        enric.balletbo@collabora.co.uk, tomeu.vizoso@collabora.co.uk,
        stable@vger.kernel.org
References: <20180612132028.27490-1-heiko@sntech.de>
 <20180612132028.27490-3-heiko@sntech.de>
From: Marc Zyngier <marc.zyngier@arm.com>
Message-ID: <edc71874-4517-c097-c851-d60565f06817@arm.com>
Date: Wed, 13 Jun 2018 14:01:27 +0100
MIME-Version: 1.0
In-Reply-To: <20180612132028.27490-3-heiko@sntech.de>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On 12/06/18 14:20, Heiko Stuebner wrote:
> From: Sandy Huang <hjc@rock-chips.com>
> 
> The vop irq is shared between vop and iommu and irq probing in the
> iommu driver moved to the probe function recently. This can in some
> cases lead to a stall if the irq is triggered while the vop driver
> still has it disabled, but the vop irq handler gets called.
> 
> But there is no real need to disable the irq, as the vop can simply
> also track its enabled state and ignore irqs in that case.
> For this we can simply check the power-domain state of the vop,
> similar to how the iommu driver does it.
> 
> So remove the enable/disable handling and add appropriate condition
> to the irq handler.
> 
> changes in v2:
> - move to just check the power-domain state
> - add clock handling
> changes in v3:
> - clarify comment to speak of runtime-pm not power-domain
> changes in v4:
> - address Marc's comments (clk-enable WARN_ON and style improvement)
> 
> Fixes: d0b912bd4c23 ("iommu/rockchip: Request irqs in rk_iommu_probe()")
> Cc: stable@vger.kernel.org
> Signed-off-by: Sandy Huang <hjc@rock-chips.com>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> Tested-by: Ezequiel Garcia <ezequiel@collabora.com>

Reviewed-by: Marc Zyngier <marc.zyngier@arm.com>

	M.
-- 
Jazz is not dead. It just smells funny...