From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF4E9C433DF for ; Thu, 14 May 2020 14:09:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 86E6C20671 for ; Thu, 14 May 2020 14:09:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="OVE3o/Fn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 86E6C20671 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56078 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZEYf-0001VM-Np for qemu-devel@archiver.kernel.org; Thu, 14 May 2020 10:09:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37408) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZEY2-0000j8-Ef for qemu-devel@nongnu.org; Thu, 14 May 2020 10:09:18 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:59625 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jZEY1-0002m1-Fq for qemu-devel@nongnu.org; Thu, 14 May 2020 10:09:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589465356; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gSwL79+Ytr2fWQ3sSTVtTLJM8IALtQD3+xIyqja5Ow8=; b=OVE3o/FnOUV9oCRG4ft+rMmc5gf+ypl7/y6Z9yjPn4qLRqfwCpmjcbwvA7kU5wkMWGdxvo n0NYT1XIakXtfHF2tH970s6PVr4x6akyDCErIEqsgS79Vvz+t9/QHJgPBHlXlgmzFa7XOR TwzK8vmlhNcjXCNBMoxpgRqDJ23pIlU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-349-cvTsIGLpOVW3E4xQZ6jGKg-1; Thu, 14 May 2020 10:09:14 -0400 X-MC-Unique: cvTsIGLpOVW3E4xQZ6jGKg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C903E1899530; Thu, 14 May 2020 14:09:13 +0000 (UTC) Received: from [10.3.116.145] (ovpn-116-145.phx2.redhat.com [10.3.116.145]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3F91C6116F; Thu, 14 May 2020 14:09:13 +0000 (UTC) Subject: Re: [PATCH v4 3/9] block: Make it easier to learn which BDS support bitmaps To: Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org References: <20200513011648.166876-1-eblake@redhat.com> <20200513011648.166876-4-eblake@redhat.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: Date: Thu, 14 May 2020 09:09:12 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=207.211.31.120; envelope-from=eblake@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/13 22:25:46 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, nsoffer@redhat.com, John Snow , qemu-block@nongnu.org, mreitz@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 5/14/20 12:19 AM, Vladimir Sementsov-Ogievskiy wrote: >> In the future, when we improve the ability to look up bitmaps through >> a filter, we will probably also want to teach the block layer to >> automatically let filters pass this request on through. > > Hm. I think that bitmap at filter bs is a valid thing (moreover I have a > plan to use it for one issue), so I'm not sure that it's good idea to do > any generic logic around bitmaps work through filters, better to always > address the exact node you mean.. In the immediate term, the only user of this new function is qemu-img, and qemu-img is not setting up filters, so whether this callback can see through filters is moot (that is, we are always addressing the exact node the user passed on the command line, for whatever bitmap operations qemu-img does). In the long term, being able to see bitmaps through filters is better addressed after we finally include Max's series that include filter handling overall. > >> >> Signed-off-by: Eric Blake > > Reviewed-by: Vladimir Sementsov-Ogievskiy Thanks. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org