From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC02EC433C1 for ; Fri, 26 Mar 2021 13:13:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8274361A0F for ; Fri, 26 Mar 2021 13:13:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230059AbhCZNMb (ORCPT ); Fri, 26 Mar 2021 09:12:31 -0400 Received: from foss.arm.com ([217.140.110.172]:59118 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229882AbhCZNL6 (ORCPT ); Fri, 26 Mar 2021 09:11:58 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B66CD143D; Fri, 26 Mar 2021 06:11:56 -0700 (PDT) Received: from [192.168.178.6] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 736913F7D7; Fri, 26 Mar 2021 06:11:54 -0700 (PDT) Subject: Re: [PATCH 7/9] sched,debug: Convert sysctl sched_domains to debugfs To: Peter Zijlstra , mingo@kernel.org, mgorman@suse.de, juri.lelli@redhat.com, vincent.guittot@linaro.org, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, joshdon@google.com, valentin.schneider@arm.com Cc: linux-kernel@vger.kernel.org, greg@kroah.com References: <20210326103352.603456266@infradead.org> <20210326103935.264012208@infradead.org> From: Dietmar Eggemann Message-ID: Date: Fri, 26 Mar 2021 14:11:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210326103935.264012208@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/03/2021 11:33, Peter Zijlstra wrote: > Stop polluting sysctl, move to debugfs for SCHED_DEBUG stuff. > > Signed-off-by: Peter Zijlstra (Intel) > --- > kernel/sched/debug.c | 255 ++++++++++-------------------------------------- > kernel/sched/sched.h | 2 > kernel/sched/topology.c | 1 > 3 files changed, 59 insertions(+), 199 deletions(-) Reviewed-by: Dietmar Eggemann [...] > +#define SDM(type, mode, member) \ > + debugfs_create_##type(#member, mode, parent, &sd->member) > > - WARN_ON(sd_ctl_dir[0].child); > - sd_ctl_dir[0].child = cpu_entries; > - } > + SDM(ulong, 0644, min_interval); > + SDM(ulong, 0644, max_interval); > + SDM(u64, 0644, max_newidle_lb_cost); > + SDM(u32, 0644, busy_factor); > + SDM(u32, 0644, imbalance_pct); > + SDM(u32, 0644, cache_nice_tries); > +// SDM(x32, 0444, flags); Can be removed. > + SDM(str, 0444, name); > > - if (!cpu_idx) { > - struct ctl_table *e = cpu_entries; > +#undef SDM > > - cpu_idx = kcalloc(nr_cpu_ids, sizeof(struct ctl_table*), GFP_KERNEL); > - if (!cpu_idx) > - return; > + debugfs_create_file("flags", 0444, parent, &sd->flags, &sd_flags_fops); > +} [...]