Re: [Intel-gfx] [PATCH v2 3/5] drm/i915/display: Workaround cursor left overs with PSR2 selective fetch enabled

["Souza, Jose" <jose.souza@intel.com>]

On Wed, 2021-09-15 at 17:58 +0300, Ville Syrjälä wrote:
> On Tue, Sep 14, 2021 at 02:25:05PM -0700, José Roberto de Souza wrote:
> > Not sure why but when moving the cursor fast it causes some artifacts
> > of the cursor to be left in the cursor path, adding some pixels above
> > the cursor to the damaged area fixes the issue, so leaving this as a
> > workaround until proper fix is found.
> 
> Have you tried warping the cursor clear across the screen while
> a partial update is already pending? I think it will go badly.

You mean move the cursor for example from 0x0 to 500x500 in one frame?
It will mark as damaged the previous area and the new one.

> 
> In fact I'm thinking the mailbox style legacy cursor updates are just
> fundementally incompatible with partial updates since the cursor
> can move outside of the already committed update region any time.
> Ie. I suspect while the cursor is visible we simply can't do partial
> updates.

Probably I did not understand what you want to say, but each cursor update will be in one frame, updating the necessary area.
So I can't understand why it is incompatible.


> 
> > 
> > This is reproducile on TGL and ADL-P.
> > 
> > Cc: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
> > Reviewed-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
> > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > ---
> >  drivers/gpu/drm/i915/display/intel_psr.c | 25 ++++++++++++++++++++++++
> >  1 file changed, 25 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
> > index 567c7ceef8dba..f8fa30e50e70c 100644
> > --- a/drivers/gpu/drm/i915/display/intel_psr.c
> > +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> > @@ -1543,6 +1543,28 @@ static void intel_psr2_sel_fetch_pipe_alignment(const struct intel_crtc_state *c
> >  		drm_warn(&dev_priv->drm, "Missing PSR2 sel fetch alignment with DSC\n");
> >  }
> >  
> > +/*
> > + * FIXME: Not sure why but when moving the cursor fast it causes some artifacts
> > + * of the cursor to be left in the cursor path, adding some pixels above the
> > + * cursor to the damaged area fixes the issue.
> > + */
> > +static void cursor_area_workaround(const struct intel_plane_state *new_plane_state,
> > +				   struct drm_rect *damaged_area,
> > +				   struct drm_rect *pipe_clip)
> > +{
> > +	const struct intel_plane *plane = to_intel_plane(new_plane_state->uapi.plane);
> > +	int height;
> > +
> > +	if (plane->id != PLANE_CURSOR)
> > +		return;
> > +
> > +	height = drm_rect_height(&new_plane_state->uapi.dst) / 2;
> > +	damaged_area->y1 -=  height;
> > +	damaged_area->y1 = max(damaged_area->y1, 0);
> > +
> > +	clip_area_update(pipe_clip, damaged_area);
> > +}
> > +
> >  int intel_psr2_sel_fetch_update(struct intel_atomic_state *state,
> >  				struct intel_crtc *crtc)
> >  {
> > @@ -1611,6 +1633,9 @@ int intel_psr2_sel_fetch_update(struct intel_atomic_state *state,
> >  				damaged_area.y2 = new_plane_state->uapi.dst.y2;
> >  				clip_area_update(&pipe_clip, &damaged_area);
> >  			}
> > +
> > +			cursor_area_workaround(new_plane_state, &damaged_area,
> > +					       &pipe_clip);
> >  			continue;
> >  		} else if (new_plane_state->uapi.alpha != old_plane_state->uapi.alpha ||
> >  			   (!num_clips &&
> > -- 
> > 2.33.0
>