From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5C3CC43217 for ; Tue, 21 Dec 2021 08:19:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235508AbhLUITv (ORCPT ); Tue, 21 Dec 2021 03:19:51 -0500 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]:53778 "EHLO smtp-relay-internal-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232095AbhLUITt (ORCPT ); Tue, 21 Dec 2021 03:19:49 -0500 Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 8AC743F20D for ; Tue, 21 Dec 2021 08:19:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1640074788; bh=AmwBkgsCQBlvy6a8IJhNBe3rHFIw/oazUsEvZEPNdNw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=p0gp1Ub/qBL4Lo0HnHH0ySOaLrz2zHVSV+jPW6Nlzta9gdEaA0qt7fumUtBmKfRlL gAhkExfiWqLj5PTHrZzK4gQlBtwyNldRXIBzT9EQTwWI7dMfYBcXb+apTs2RmOFW3y XJQ6ujOMPbTi0SOFjwd9DIl1nal4zEr2NHgAlr1s3RTMt1gHDKOaHI4FmapOarKb/O rWX/HxroBATh69wF58tn3VYjyKSKt4uk9xdTzhbRvTyoVX5H98u2NC2+GlmdQcMDYK PICxzYkZmjCg/b8Dp7ok6kW9e1ZZwEkruh9VpkuVCg4F/iACBKIneR8lFjmcf1/sTH 6lRtxU9REfh/A== Received: by mail-lf1-f72.google.com with SMTP id g18-20020a05651222d200b0042612bda352so1588634lfu.11 for ; Tue, 21 Dec 2021 00:19:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=AmwBkgsCQBlvy6a8IJhNBe3rHFIw/oazUsEvZEPNdNw=; b=V/ELlJWkJMeLTC6ge4iuJoP4BHHQL8kOVuSEjN5bvFnBEb+aJLnvVkIfTt8TlFWQns KyzQCRIE6bslq7i+P+rvyeBU4yexuYB4c++sh/dYQM5JdVZEE3FGayAknoni659cQEoI D1dupIKEZ8xHC23Tbic5WEqzAP57dpKg3SamM3mhh+X+ZZ8y+mjzAY23bI6Uf/6x7C/E vORXtouQOlVYzf2PEno8QO6U7R5d+hE8XkkvAnHryuirELgZj6Kd/q6Rcnf56+XmxJnA +FsWFxhDngxR6o67+Z3vLSyPunQGoBqnN3MQnAAwp7jC3fdPcDGVFA3VZqe77rmHybdm raTw== X-Gm-Message-State: AOAM533rwwu4TJAcXgFOz1og8nZXzT6qWrS8qix5SEO0Gd5Pjee7uVUs hF8uItoUTysFSRgaAoP1d4qnwhZ1ihil6Y31ibtZSmx5SAw5lSilJUgQRoOEtAIfnIkb0hRPiGp N1H3wshS48Bzzr/LdILuZGGryrITtyjFbYOE7hKEv6Q== X-Received: by 2002:a2e:b177:: with SMTP id a23mr1708971ljm.168.1640074787938; Tue, 21 Dec 2021 00:19:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJxy/XhlYssCNLAWRYkWoIWMzAeGZqkYE+7VzTrmhujnAacn27xoPqnMQ2uSgBrGs8xv+IeKow== X-Received: by 2002:a2e:b177:: with SMTP id a23mr1708948ljm.168.1640074787666; Tue, 21 Dec 2021 00:19:47 -0800 (PST) Received: from [192.168.0.27] (89-77-68-124.dynamic.chello.pl. [89.77.68.124]) by smtp.gmail.com with ESMTPSA id z26sm2654830lja.48.2021.12.21.00.19.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Dec 2021 00:19:47 -0800 (PST) Message-ID: Date: Tue, 21 Dec 2021 09:19:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Subject: Re: [PATCH v4 1/7] dt-bindings: clock: exynos850: Add bindings for Exynos850 sysreg clocks Content-Language: en-US To: Sam Protsenko Cc: Sylwester Nawrocki , Jaewon Kim , Chanho Park , David Virag , Youngmin Nam , Tomasz Figa , Chanwoo Choi , Michael Turquette , Stephen Boyd , Linus Walleij , Daniel Palmer , Hao Fang , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Sylwester Nawrocki , Rob Herring References: <20211217161549.24836-1-semen.protsenko@linaro.org> <20211217161549.24836-2-semen.protsenko@linaro.org> <2fdc5c97-6c19-8e70-d717-28b29d86160c@kernel.org> <5bd5c0bf-4390-22c2-e4e0-cb02b80dfb9c@canonical.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/12/2021 15:55, Sam Protsenko wrote: > On Mon, 20 Dec 2021 at 11:31, Krzysztof Kozlowski > wrote: >> >> On 19/12/2021 23:29, Sylwester Nawrocki wrote: >>> On 17.12.2021 17:15, Sam Protsenko wrote: >>>> System Register is used to configure system behavior, like USI protocol, >>>> etc. SYSREG clocks should be provided to corresponding syscon nodes, to >>>> make it possible to modify SYSREG registers. >>>> >>>> While at it, add also missing PMU and GPIO clocks, which looks necessary >>>> and might be needed for corresponding Exynos850 features soon. >>>> >>>> Reviewed-by: Krzysztof Kozlowski >>>> Acked-by: Rob Herring >>>> Acked-by: Chanwoo Choi >>>> Signed-off-by: Sam Protsenko >>> >>> Apologies for late reply, this patch is applied now. >>> >> >> Sam, >> >> The clock is used in the DTSI, so since this was applied, there are only >> two choices now: >> 1. wait for next cycle with DTSI and DTS, >> 2. Resubmit with replacing the newly added clocks in DTSI/DTS with >> numbers and a TODO note. >> > > But why? I thought because Sylwester applied my clock patches, those > will get into v5.17, and so DTSI/DTS might rely on those clocks? If I > get it wrong, please let me know why, and I'll go with item (2) you > suggested. If I apply the DTSI+DTS, all my builds will start failing. The linux-next (since Sylwester's tree is included) should build fine, but my tree won't be buildable anymore. Then arm-soc pulls my tree and gets said because it does not build. Later, Linus will be unhappy if he pulls arm-soc (thus mine) before clock tree. Other solution, instead of using raw numbers, is to copy-paste the clock macros you use directly in DTSI and do not include the clock header. This actually might be cleaner choice - changes will be limited to one place in DTSI. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37D6FC433F5 for ; Tue, 21 Dec 2021 08:21:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=991T0DGQsLa+8DMRyDY1yvf1y6/8Yfhqn3+QDIs5WSU=; b=HItX2982GUc+l1 9DbROQsBTDLard3R9IxFY/F/sEWoG9v8hcaXJADcpfJMLQOnQSkVopA/NdL9mdUOLX1T8aqHXtTIU uOTj4ZePoLLmmpGk9AZna728kepNDjM7dDEowuJgww9u2kKcOiGimgCwoAytF/DrzQReKTc2+aR92 SOr9ON3iKFJLAThrbLR7/MLKAev2LFbrJqLJfgtr5+1UtftQUyXKy8QwuyXI5uIgZiR+FAxtHv2w9 yY+q8uJIS7PZeKwhIf7T4U6rv1hP23WqrrRA7TRPbrb+gm8A4fZxTgf26eg32Xw+kWFFmyehhpvbb eNA2laz8ZzIQz5O14sjA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mzaNK-005u43-Jm; Tue, 21 Dec 2021 08:19:59 +0000 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mzaND-005tzE-0G for linux-arm-kernel@lists.infradead.org; Tue, 21 Dec 2021 08:19:52 +0000 Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 7B8743F1EE for ; Tue, 21 Dec 2021 08:19:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1640074788; bh=AmwBkgsCQBlvy6a8IJhNBe3rHFIw/oazUsEvZEPNdNw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=p0gp1Ub/qBL4Lo0HnHH0ySOaLrz2zHVSV+jPW6Nlzta9gdEaA0qt7fumUtBmKfRlL gAhkExfiWqLj5PTHrZzK4gQlBtwyNldRXIBzT9EQTwWI7dMfYBcXb+apTs2RmOFW3y XJQ6ujOMPbTi0SOFjwd9DIl1nal4zEr2NHgAlr1s3RTMt1gHDKOaHI4FmapOarKb/O rWX/HxroBATh69wF58tn3VYjyKSKt4uk9xdTzhbRvTyoVX5H98u2NC2+GlmdQcMDYK PICxzYkZmjCg/b8Dp7ok6kW9e1ZZwEkruh9VpkuVCg4F/iACBKIneR8lFjmcf1/sTH 6lRtxU9REfh/A== Received: by mail-lj1-f197.google.com with SMTP id w16-20020a05651c103000b00218c9d46faeso1978094ljm.2 for ; Tue, 21 Dec 2021 00:19:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=AmwBkgsCQBlvy6a8IJhNBe3rHFIw/oazUsEvZEPNdNw=; b=FxLEyolnlmQIktA6HtxQfmIt4DPOlrylNcCcdn5ffMnUqybluFdntpBrwLISJX0E2c o2VvrAA6DvDrgLHt34znftDQ67/PPq8U1WdMXxg93eEAlOwIPp2oHjAdXdlsXgenr8B7 qqIc9hkfFrHWhVIT0Kc3YaRodjy7AWeNkkl4y69/8mOCVUIqJJOwPWspZzcYAzbBS5wm tiSCeZrCmSUXOVNda+QQMZGGiTTA1xLKIMFIycWjMXKjza8L6P8gJnauDD57gB6Umve6 nLogNd4etCxS2LTHk+BnFA+BAWLW1sl63xzCytQmakYtjrEGz5VW1XFcqIX53okcNchO ZGLw== X-Gm-Message-State: AOAM531MFlObZxuRoNcOxBxwDNonz9STh2rFKKhs/KcCyyapsa/6U0RW BDXi1aRwoa2GYApWWmCA7Ypq4ZGHFN2aTZJp/O3FCyj2EOPtPyL/RsvQQvy2zDs5v+Sy2Cdafpo jNfHTQOBh7jOn153ZkKqHg1qkPzOWYXkJglvYXyeXqOURWEmtFPLN X-Received: by 2002:a2e:b177:: with SMTP id a23mr1708958ljm.168.1640074787848; Tue, 21 Dec 2021 00:19:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJxy/XhlYssCNLAWRYkWoIWMzAeGZqkYE+7VzTrmhujnAacn27xoPqnMQ2uSgBrGs8xv+IeKow== X-Received: by 2002:a2e:b177:: with SMTP id a23mr1708948ljm.168.1640074787666; Tue, 21 Dec 2021 00:19:47 -0800 (PST) Received: from [192.168.0.27] (89-77-68-124.dynamic.chello.pl. [89.77.68.124]) by smtp.gmail.com with ESMTPSA id z26sm2654830lja.48.2021.12.21.00.19.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Dec 2021 00:19:47 -0800 (PST) Message-ID: Date: Tue, 21 Dec 2021 09:19:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Subject: Re: [PATCH v4 1/7] dt-bindings: clock: exynos850: Add bindings for Exynos850 sysreg clocks Content-Language: en-US To: Sam Protsenko Cc: Sylwester Nawrocki , Jaewon Kim , Chanho Park , David Virag , Youngmin Nam , Tomasz Figa , Chanwoo Choi , Michael Turquette , Stephen Boyd , Linus Walleij , Daniel Palmer , Hao Fang , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Sylwester Nawrocki , Rob Herring References: <20211217161549.24836-1-semen.protsenko@linaro.org> <20211217161549.24836-2-semen.protsenko@linaro.org> <2fdc5c97-6c19-8e70-d717-28b29d86160c@kernel.org> <5bd5c0bf-4390-22c2-e4e0-cb02b80dfb9c@canonical.com> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211221_001951_236426_B4379168 X-CRM114-Status: GOOD ( 21.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 20/12/2021 15:55, Sam Protsenko wrote: > On Mon, 20 Dec 2021 at 11:31, Krzysztof Kozlowski > wrote: >> >> On 19/12/2021 23:29, Sylwester Nawrocki wrote: >>> On 17.12.2021 17:15, Sam Protsenko wrote: >>>> System Register is used to configure system behavior, like USI protocol, >>>> etc. SYSREG clocks should be provided to corresponding syscon nodes, to >>>> make it possible to modify SYSREG registers. >>>> >>>> While at it, add also missing PMU and GPIO clocks, which looks necessary >>>> and might be needed for corresponding Exynos850 features soon. >>>> >>>> Reviewed-by: Krzysztof Kozlowski >>>> Acked-by: Rob Herring >>>> Acked-by: Chanwoo Choi >>>> Signed-off-by: Sam Protsenko >>> >>> Apologies for late reply, this patch is applied now. >>> >> >> Sam, >> >> The clock is used in the DTSI, so since this was applied, there are only >> two choices now: >> 1. wait for next cycle with DTSI and DTS, >> 2. Resubmit with replacing the newly added clocks in DTSI/DTS with >> numbers and a TODO note. >> > > But why? I thought because Sylwester applied my clock patches, those > will get into v5.17, and so DTSI/DTS might rely on those clocks? If I > get it wrong, please let me know why, and I'll go with item (2) you > suggested. If I apply the DTSI+DTS, all my builds will start failing. The linux-next (since Sylwester's tree is included) should build fine, but my tree won't be buildable anymore. Then arm-soc pulls my tree and gets said because it does not build. Later, Linus will be unhappy if he pulls arm-soc (thus mine) before clock tree. Other solution, instead of using raw numbers, is to copy-paste the clock macros you use directly in DTSI and do not include the clock header. This actually might be cleaner choice - changes will be limited to one place in DTSI. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel