From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D13E3C433F5 for ; Thu, 10 Feb 2022 11:22:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240844AbiBJLWI (ORCPT ); Thu, 10 Feb 2022 06:22:08 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:32982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240774AbiBJLWF (ORCPT ); Thu, 10 Feb 2022 06:22:05 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id AC263F46; Thu, 10 Feb 2022 03:22:06 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 77D27ED1; Thu, 10 Feb 2022 03:22:06 -0800 (PST) Received: from [10.57.17.101] (unknown [10.57.17.101]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id ED6A03F73B; Thu, 10 Feb 2022 03:22:03 -0800 (PST) Subject: Re: [PATCH v5 6/7] thermal: netlink: Add a new event to notify CPU capabilities change To: "Rafael J. Wysocki" Cc: "Rafael J. Wysocki" , Linux PM , the arch/x86 maintainers , "open list:DOCUMENTATION" , Len Brown , Srinivas Pandruvada , Aubrey Li , Amit Kucheria , Andi Kleen , Tim Chen , "Ravi V. Shankar" , Ricardo Neri , Linux Kernel Mailing List , Ricardo Neri , Daniel Lezcano References: <20220127193454.12814-1-ricardo.neri-calderon@linux.intel.com> <20220127193454.12814-7-ricardo.neri-calderon@linux.intel.com> From: Lukasz Luba Message-ID: Date: Thu, 10 Feb 2022 11:22:02 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/30/22 3:20 PM, Rafael J. Wysocki wrote: > On Thu, Jan 27, 2022 at 8:33 PM Ricardo Neri > wrote: >> >> From: Srinivas Pandruvada >> >> Add a new netlink event to notify change in CPU capabilities in terms of >> performance and efficiency. >> >> Firmware may change CPU capabilities as a result of thermal events in the >> system or to account for changes in the TDP (thermal design power) level. >> >> This notification type will allow user space to avoid running workloads >> on certain CPUs or proactively adjust power limits to avoid future events. >> >> The netlink message consists of a nested attribute >> (THERMAL_GENL_ATTR_CPU_CAPABILITY) with three attributes: >> >> * THERMAL_GENL_ATTR_CPU_CAPABILITY_ID (type u32): >> -- logical CPU number >> * THERMAL_GENL_ATTR_CPU_CAPABILITY_PERFORMANCE (type u32): >> -- Scaled performance from 0-1023 >> * THERMAL_GENL_ATTR_CPU_CAPABILITY_EFFICIENCY (type u32): >> -- Scaled efficiency from 0-1023 >> >> Cc: Andi Kleen >> Cc: Aubrey Li >> Cc: Lukasz Luba >> Cc: Tim Chen >> Cc: "Ravi V. Shankar" >> Reviewed-by: Len Brown >> Signed-off-by: Srinivas Pandruvada > > Daniel, Lukasz, if you have any comments or concerns regarding this > patch, please let me know. > My apologies Rafael, I missed that email. I've looked at the patches 6/7 and 7/7 and they look OK with the scaling.