From: Max Reitz <mreitz@redhat.com>
To: Peter Lieven <pl@kamp.de>, qemu-block@nongnu.org
Cc: kwolf@redhat.com, qemu-devel@nongnu.org,
ronniesahlberg@gmail.com, qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH V2 1/2] block/nfs: tear down aio before nfs_close
Date: Fri, 13 Sep 2019 11:51:19 +0200 [thread overview]
Message-ID: <ede55319-ca74-ab1c-6b3e-8558d9e6bdd8@redhat.com> (raw)
In-Reply-To: <20190910154110.6905-2-pl@kamp.de>
[-- Attachment #1.1: Type: text/plain, Size: 726 bytes --]
On 10.09.19 17:41, Peter Lieven wrote:
> nfs_close is a sync call from libnfs and has its own event
> handler polling on the nfs FD. Avoid that both QEMU and libnfs
> are intefering here.
>
> CC: qemu-stable@nongnu.org
> Signed-off-by: Peter Lieven <pl@kamp.de>
> ---
> block/nfs.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
I’ve just seen that Kevin has already included the second patch (in its
v1) in his pull request.
So all that I can do is take this patch, which sounds good to me,
especially since Ronnie has agreed that we should remove our FD handler
there.
(So I’ve rebased the patch on top of Kevin’s pull request, and I’ve
taken it to my block branch.)
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-09-13 9:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-10 15:41 [Qemu-devel] [PATCH V2 0/2] add support for nfs_umount Peter Lieven
2019-09-10 15:41 ` [Qemu-devel] [PATCH V2 1/2] block/nfs: tear down aio before nfs_close Peter Lieven
2019-09-13 9:51 ` Max Reitz [this message]
2019-09-13 10:15 ` Peter Lieven
2019-09-13 10:21 ` Kevin Wolf
2019-09-10 15:41 ` [Qemu-devel] [PATCH V2 2/2] block/nfs: add support for nfs_umount Peter Lieven
2019-09-11 7:48 ` Max Reitz
2019-09-11 12:22 ` Peter Lieven
2019-09-13 10:09 ` ronnie sahlberg
2019-09-13 11:13 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ede55319-ca74-ab1c-6b3e-8558d9e6bdd8@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=ronniesahlberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.