From mboxrd@z Thu Jan 1 00:00:00 1970 From: icenowy-h8G6r0blFSE@public.gmane.org Subject: Re: [PATCH 2/4] dt-bindings: add binding for RTL8211E Ethernet PHY Date: Fri, 05 May 2017 02:10:50 +0800 Message-ID: References: <20170421232436.10924-1-icenowy@aosc.io> <20170421232436.10924-3-icenowy@aosc.io> Reply-To: icenowy-h8G6r0blFSE@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Cc: Andrew Lunn , Rob Herring , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Icenowy Zheng To: Florian Fainelli Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , List-Id: netdev.vger.kernel.org =E5=9C=A8 2017-04-22 08:22=EF=BC=8CFlorian Fainelli =E5=86=99=E9=81=93=EF= =BC=9A > On 04/21/2017 04:24 PM, Icenowy Zheng wrote: >> From: Icenowy Zheng >>=20 >> Some RTL8211E Ethernet PHY have an issue that needs a workaround >> indicated with device tree. >>=20 >> Add the binding for a property that indicates this workaround. >>=20 >> Signed-off-by: Icenowy Zheng >> --- >> .../devicetree/bindings/net/realtek,rtl8211e.txt | 22=20 >> ++++++++++++++++++++++ >> 1 file changed, 22 insertions(+) >> create mode 100644=20 >> Documentation/devicetree/bindings/net/realtek,rtl8211e.txt >>=20 >> diff --git=20 >> a/Documentation/devicetree/bindings/net/realtek,rtl8211e.txt=20 >> b/Documentation/devicetree/bindings/net/realtek,rtl8211e.txt >> new file mode 100644 >> index 000000000000..c1913301bfe8 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/realtek,rtl8211e.txt >> @@ -0,0 +1,22 @@ >> +Realtek RTL8211E Ethernet PHY >> + >> +One batch of RTL8211E is slight broken, that needs some special (and >> +full of magic numbers) tweaking in order to make GbE to operate=20 >> properly. >> +The only well-known board that used the broken batch is Pine64+. >> +Configure it through an Ethernet OF device node. >> + >> +Optional properties: >> + >> +- realtek,disable-rx-delay: >> + If set, RX delay will be completely disabled (according to=20 >> Realtek). This >> + will affect the performance on non-broken boards. >> + default: do not disable RX delay. >=20 > Please don't introduce custom properties to do that, instead correct > specify the "phy-mode" such that it is e.g: "rgmii-txid" which=20 > indicates > that there should be no RX internal delay, but a TX internal delay=20 > added > by the PHY. Checked the document, the meaning of "rgmii-txid" is not correct here. This doesn't effect the MAC, and the MAC should still add TX delay. The definition of "rgmii-txid" in Documentation/devicetree/binding/net/ethernet.txt is "RGMII with internal TX delay provided by the PHY, the MAC should not add an TX=20 delay in this case". However, this do not indicate that the MAC doesn't add TX delay; in fact that just totally disabled the PHY to provide the RX=20 delay. MAC still should to add delay on both TX/RX, which is the semantic of standard "rgmii". So I cannot used "rgmii-txid" here, but should continue to use this custom property. --=20 You received this message because you are subscribed to the Google Groups "= linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout.