From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933837AbdKQGzZ (ORCPT ); Fri, 17 Nov 2017 01:55:25 -0500 Received: from mx2.suse.de ([195.135.220.15]:41926 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757044AbdKQGzQ (ORCPT ); Fri, 17 Nov 2017 01:55:16 -0500 Subject: Re: [PATCH 02/13] x86/paravirt: Fix output constraint macro names To: Josh Poimboeuf Cc: x86@kernel.org, linux-kernel@vger.kernel.org, Andy Lutomirski , Linus Torvalds , Sasha Levin , live-patching@vger.kernel.org, Jiri Slaby , Ingo Molnar , "H. Peter Anvin" , Peter Zijlstra , Mike Galbraith , Chris Wright , Alok Kataria , Rusty Russell , virtualization@lists.linux-foundation.org, Boris Ostrovsky , xen-devel@lists.xenproject.org, Thomas Gleixner , Borislav Petkov References: <5d2799f9-fb5d-381e-a576-15098626201f@suse.com> <20171116205042.wyl6x2q5tjwmoyeg@treble> From: Juergen Gross Message-ID: Date: Fri, 17 Nov 2017 07:55:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171116205042.wyl6x2q5tjwmoyeg@treble> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/11/17 21:50, Josh Poimboeuf wrote: > On Wed, Oct 25, 2017 at 11:33:43AM +0200, Juergen Gross wrote: >> On 04/10/17 17:58, Josh Poimboeuf wrote: >>> Some of the paravirt '*_CLOBBERS' macros refer to output constraints >>> instead of clobbers, which makes the code extra confusing. Rename the >>> output constraint related macros to '*_OUTPUTS'. >>> >>> Signed-off-by: Josh Poimboeuf >> >> I'm fine with the changes, but you might want to rename the "call_clbr" >> parameter of ____PVOP_[V]CALL, too, e.g. to "outputs". > > Yeah, good catch. > >> You could then drop the "CALL_" from the macros, too. > > Hm, which macros are you referring to, and why? Good question. I think I didn't take the *CALLEE* macros into account. So please ignore this remark. Juergen From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juergen Gross Subject: Re: [PATCH 02/13] x86/paravirt: Fix output constraint macro names Date: Fri, 17 Nov 2017 07:55:07 +0100 Message-ID: References: <5d2799f9-fb5d-381e-a576-15098626201f@suse.com> <20171116205042.wyl6x2q5tjwmoyeg@treble> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20171116205042.wyl6x2q5tjwmoyeg@treble> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Josh Poimboeuf Cc: Boris Ostrovsky , Rusty Russell , Mike Galbraith , xen-devel@lists.xenproject.org, Peter Zijlstra , Jiri Slaby , x86@kernel.org, linux-kernel@vger.kernel.org, Sasha Levin , Chris Wright , Thomas Gleixner , Andy Lutomirski , "H. Peter Anvin" , Borislav Petkov , live-patching@vger.kernel.org, Alok Kataria , virtualization@lists.linux-foundation.org, Linus Torvalds , Ingo Molnar List-Id: virtualization@lists.linuxfoundation.org On 16/11/17 21:50, Josh Poimboeuf wrote: > On Wed, Oct 25, 2017 at 11:33:43AM +0200, Juergen Gross wrote: >> On 04/10/17 17:58, Josh Poimboeuf wrote: >>> Some of the paravirt '*_CLOBBERS' macros refer to output constraints >>> instead of clobbers, which makes the code extra confusing. Rename the >>> output constraint related macros to '*_OUTPUTS'. >>> >>> Signed-off-by: Josh Poimboeuf >> >> I'm fine with the changes, but you might want to rename the "call_clbr" >> parameter of ____PVOP_[V]CALL, too, e.g. to "outputs". > > Yeah, good catch. > >> You could then drop the "CALL_" from the macros, too. > > Hm, which macros are you referring to, and why? Good question. I think I didn't take the *CALLEE* macros into account. So please ignore this remark. Juergen