From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B685AC04AA7 for ; Mon, 13 May 2019 12:16:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 835CB2168B for ; Mon, 13 May 2019 12:16:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729749AbfEMMQM (ORCPT ); Mon, 13 May 2019 08:16:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57278 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727997AbfEMMQM (ORCPT ); Mon, 13 May 2019 08:16:12 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2F26F87620; Mon, 13 May 2019 12:16:11 +0000 (UTC) Received: from [10.36.116.17] (ovpn-116-17.ams2.redhat.com [10.36.116.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BB24219C67; Mon, 13 May 2019 12:16:03 +0000 (UTC) Subject: Re: [PATCH v7 14/23] iommu/smmuv3: Implement cache_invalidate To: Robin Murphy , eric.auger.pro@gmail.com, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, joro@8bytes.org, alex.williamson@redhat.com, jacob.jun.pan@linux.intel.com, yi.l.liu@intel.com, jean-philippe.brucker@arm.com, will.deacon@arm.com Cc: kevin.tian@intel.com, ashok.raj@intel.com, marc.zyngier@arm.com, christoffer.dall@arm.com, peter.maydell@linaro.org, vincent.stehle@arm.com References: <20190408121911.24103-1-eric.auger@redhat.com> <20190408121911.24103-15-eric.auger@redhat.com> From: Auger Eric Message-ID: Date: Mon, 13 May 2019 14:16:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 13 May 2019 12:16:11 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Robin, On 5/8/19 5:01 PM, Robin Murphy wrote: > On 08/04/2019 13:19, Eric Auger wrote: >> Implement domain-selective and page-selective IOTLB invalidations. >> >> Signed-off-by: Eric Auger >> >> --- >> v6 -> v7 >> - check the uapi version >> >> v3 -> v4: >> - adapt to changes in the uapi >> - add support for leaf parameter >> - do not use arm_smmu_tlb_inv_range_nosync or arm_smmu_tlb_inv_context >>    anymore >> >> v2 -> v3: >> - replace __arm_smmu_tlb_sync by arm_smmu_cmdq_issue_sync >> >> v1 -> v2: >> - properly pass the asid >> --- >>   drivers/iommu/arm-smmu-v3.c | 60 +++++++++++++++++++++++++++++++++++++ >>   1 file changed, 60 insertions(+) >> >> diff --git a/drivers/iommu/arm-smmu-v3.c b/drivers/iommu/arm-smmu-v3.c >> index 1486baf53425..4366921d8318 100644 >> --- a/drivers/iommu/arm-smmu-v3.c >> +++ b/drivers/iommu/arm-smmu-v3.c >> @@ -2326,6 +2326,65 @@ static void arm_smmu_detach_pasid_table(struct >> iommu_domain *domain) >>       mutex_unlock(&smmu_domain->init_mutex); >>   } >>   +static int >> +arm_smmu_cache_invalidate(struct iommu_domain *domain, struct device >> *dev, >> +              struct iommu_cache_invalidate_info *inv_info) >> +{ >> +    struct arm_smmu_domain *smmu_domain = to_smmu_domain(domain); >> +    struct arm_smmu_device *smmu = smmu_domain->smmu; >> + >> +    if (smmu_domain->stage != ARM_SMMU_DOMAIN_NESTED) >> +        return -EINVAL; >> + >> +    if (!smmu) >> +        return -EINVAL; >> + >> +    if (inv_info->version != IOMMU_CACHE_INVALIDATE_INFO_VERSION_1) >> +        return -EINVAL; >> + >> +    if (inv_info->cache & IOMMU_CACHE_INV_TYPE_IOTLB) { >> +        if (inv_info->granularity == IOMMU_INV_GRANU_PASID) { >> +            struct arm_smmu_cmdq_ent cmd = { >> +                .opcode = CMDQ_OP_TLBI_NH_ASID, >> +                .tlbi = { >> +                    .vmid = smmu_domain->s2_cfg.vmid, >> +                    .asid = inv_info->pasid, >> +                }, >> +            }; >> + >> +            arm_smmu_cmdq_issue_cmd(smmu, &cmd); >> +            arm_smmu_cmdq_issue_sync(smmu); > > I'd much rather make arm_smmu_tlb_inv_context() understand nested > domains than open-code commands all over the place. > >> + >> +        } else if (inv_info->granularity == IOMMU_INV_GRANU_ADDR) { >> +            struct iommu_inv_addr_info *info = &inv_info->addr_info; >> +            size_t size = info->nb_granules * info->granule_size; >> +            bool leaf = info->flags & IOMMU_INV_ADDR_FLAGS_LEAF; >> +            struct arm_smmu_cmdq_ent cmd = { >> +                .opcode = CMDQ_OP_TLBI_NH_VA, >> +                .tlbi = { >> +                    .addr = info->addr, >> +                    .vmid = smmu_domain->s2_cfg.vmid, >> +                    .asid = info->pasid, >> +                    .leaf = leaf, >> +                }, >> +            }; >> + >> +            do { >> +                arm_smmu_cmdq_issue_cmd(smmu, &cmd); >> +                cmd.tlbi.addr += info->granule_size; >> +            } while (size -= info->granule_size); >> +            arm_smmu_cmdq_issue_sync(smmu); > > An this in particular I would really like to go all the way through > io_pgtable_tlb_add_flush()/io_pgtable_sync() if at all possible. Hooking > up range-based invalidations is going to be a massive headache if the > abstraction isn't solid. The concern is the host does not "own" the s1 config asid (smmu_domain->s1_cfg.cd.asid is not set, practically). In our case the asid only is passed by the userspace on CACHE_INVALIDATE ioctl call. arm_smmu_tlb_inv_context and arm_smmu_tlb_inv_range_nosync use this field Jean-Philippe highlighted that fact in https://lkml.org/lkml/2019/1/11/1062 and suggested to open-code commands instead, hence the current form. Thanks Eric > > Robin. > >> +        } else { >> +            return -EINVAL; >> +        } >> +    } >> +    if (inv_info->cache & IOMMU_CACHE_INV_TYPE_PASID || >> +        inv_info->cache & IOMMU_CACHE_INV_TYPE_DEV_IOTLB) { >> +        return -ENOENT; >> +    } >> +    return 0; >> +} >> + >>   static struct iommu_ops arm_smmu_ops = { >>       .capable        = arm_smmu_capable, >>       .domain_alloc        = arm_smmu_domain_alloc, >> @@ -2346,6 +2405,7 @@ static struct iommu_ops arm_smmu_ops = { >>       .put_resv_regions    = arm_smmu_put_resv_regions, >>       .attach_pasid_table    = arm_smmu_attach_pasid_table, >>       .detach_pasid_table    = arm_smmu_detach_pasid_table, >> +    .cache_invalidate    = arm_smmu_cache_invalidate, >>       .pgsize_bitmap        = -1UL, /* Restricted during device attach */ >>   }; >>   From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9D0CC04AAA for ; Mon, 13 May 2019 12:16:14 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 842B820879 for ; Mon, 13 May 2019 12:16:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 842B820879 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 46934D8B; Mon, 13 May 2019 12:16:14 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 63B77D83 for ; Mon, 13 May 2019 12:16:13 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 3687E837 for ; Mon, 13 May 2019 12:16:12 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2F26F87620; Mon, 13 May 2019 12:16:11 +0000 (UTC) Received: from [10.36.116.17] (ovpn-116-17.ams2.redhat.com [10.36.116.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BB24219C67; Mon, 13 May 2019 12:16:03 +0000 (UTC) Subject: Re: [PATCH v7 14/23] iommu/smmuv3: Implement cache_invalidate To: Robin Murphy , eric.auger.pro@gmail.com, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, joro@8bytes.org, alex.williamson@redhat.com, jacob.jun.pan@linux.intel.com, yi.l.liu@intel.com, jean-philippe.brucker@arm.com, will.deacon@arm.com References: <20190408121911.24103-1-eric.auger@redhat.com> <20190408121911.24103-15-eric.auger@redhat.com> From: Auger Eric Message-ID: Date: Mon, 13 May 2019 14:16:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 13 May 2019 12:16:11 +0000 (UTC) Cc: peter.maydell@linaro.org, kevin.tian@intel.com, vincent.stehle@arm.com, ashok.raj@intel.com, marc.zyngier@arm.com, christoffer.dall@arm.com X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org SGkgUm9iaW4sCk9uIDUvOC8xOSA1OjAxIFBNLCBSb2JpbiBNdXJwaHkgd3JvdGU6Cj4gT24gMDgv MDQvMjAxOSAxMzoxOSwgRXJpYyBBdWdlciB3cm90ZToKPj4gSW1wbGVtZW50IGRvbWFpbi1zZWxl Y3RpdmUgYW5kIHBhZ2Utc2VsZWN0aXZlIElPVExCIGludmFsaWRhdGlvbnMuCj4+Cj4+IFNpZ25l ZC1vZmYtYnk6IEVyaWMgQXVnZXIgPGVyaWMuYXVnZXJAcmVkaGF0LmNvbT4KPj4KPj4gLS0tCj4+ IHY2IC0+IHY3Cj4+IC0gY2hlY2sgdGhlIHVhcGkgdmVyc2lvbgo+Pgo+PiB2MyAtPiB2NDoKPj4g LSBhZGFwdCB0byBjaGFuZ2VzIGluIHRoZSB1YXBpCj4+IC0gYWRkIHN1cHBvcnQgZm9yIGxlYWYg cGFyYW1ldGVyCj4+IC0gZG8gbm90IHVzZSBhcm1fc21tdV90bGJfaW52X3JhbmdlX25vc3luYyBv ciBhcm1fc21tdV90bGJfaW52X2NvbnRleHQKPj4gwqDCoCBhbnltb3JlCj4+Cj4+IHYyIC0+IHYz Ogo+PiAtIHJlcGxhY2UgX19hcm1fc21tdV90bGJfc3luYyBieSBhcm1fc21tdV9jbWRxX2lzc3Vl X3N5bmMKPj4KPj4gdjEgLT4gdjI6Cj4+IC0gcHJvcGVybHkgcGFzcyB0aGUgYXNpZAo+PiAtLS0K Pj4gwqAgZHJpdmVycy9pb21tdS9hcm0tc21tdS12My5jIHwgNjAgKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKwo+PiDCoCAxIGZpbGUgY2hhbmdlZCwgNjAgaW5zZXJ0aW9ucygr KQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9pb21tdS9hcm0tc21tdS12My5jIGIvZHJpdmVy cy9pb21tdS9hcm0tc21tdS12My5jCj4+IGluZGV4IDE0ODZiYWY1MzQyNS4uNDM2NjkyMWQ4MzE4 IDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2lvbW11L2FybS1zbW11LXYzLmMKPj4gKysrIGIvZHJp dmVycy9pb21tdS9hcm0tc21tdS12My5jCj4+IEBAIC0yMzI2LDYgKzIzMjYsNjUgQEAgc3RhdGlj IHZvaWQgYXJtX3NtbXVfZGV0YWNoX3Bhc2lkX3RhYmxlKHN0cnVjdAo+PiBpb21tdV9kb21haW4g KmRvbWFpbikKPj4gwqDCoMKgwqDCoCBtdXRleF91bmxvY2soJnNtbXVfZG9tYWluLT5pbml0X211 dGV4KTsKPj4gwqAgfQo+PiDCoCArc3RhdGljIGludAo+PiArYXJtX3NtbXVfY2FjaGVfaW52YWxp ZGF0ZShzdHJ1Y3QgaW9tbXVfZG9tYWluICpkb21haW4sIHN0cnVjdCBkZXZpY2UKPj4gKmRldiwK Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHN0cnVjdCBpb21tdV9jYWNoZV9pbnZhbGlk YXRlX2luZm8gKmludl9pbmZvKQo+PiArewo+PiArwqDCoMKgIHN0cnVjdCBhcm1fc21tdV9kb21h aW4gKnNtbXVfZG9tYWluID0gdG9fc21tdV9kb21haW4oZG9tYWluKTsKPj4gK8KgwqDCoCBzdHJ1 Y3QgYXJtX3NtbXVfZGV2aWNlICpzbW11ID0gc21tdV9kb21haW4tPnNtbXU7Cj4+ICsKPj4gK8Kg wqDCoCBpZiAoc21tdV9kb21haW4tPnN0YWdlICE9IEFSTV9TTU1VX0RPTUFJTl9ORVNURUQpCj4+ ICvCoMKgwqDCoMKgwqDCoCByZXR1cm4gLUVJTlZBTDsKPj4gKwo+PiArwqDCoMKgIGlmICghc21t dSkKPj4gK8KgwqDCoMKgwqDCoMKgIHJldHVybiAtRUlOVkFMOwo+PiArCj4+ICvCoMKgwqAgaWYg KGludl9pbmZvLT52ZXJzaW9uICE9IElPTU1VX0NBQ0hFX0lOVkFMSURBVEVfSU5GT19WRVJTSU9O XzEpCj4+ICvCoMKgwqDCoMKgwqDCoCByZXR1cm4gLUVJTlZBTDsKPj4gKwo+PiArwqDCoMKgIGlm IChpbnZfaW5mby0+Y2FjaGUgJiBJT01NVV9DQUNIRV9JTlZfVFlQRV9JT1RMQikgewo+PiArwqDC oMKgwqDCoMKgwqAgaWYgKGludl9pbmZvLT5ncmFudWxhcml0eSA9PSBJT01NVV9JTlZfR1JBTlVf UEFTSUQpIHsKPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgc3RydWN0IGFybV9zbW11X2NtZHFf ZW50IGNtZCA9IHsKPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAub3Bjb2RlID0g Q01EUV9PUF9UTEJJX05IX0FTSUQsCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg LnRsYmkgPSB7Cj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAudm1p ZCA9IHNtbXVfZG9tYWluLT5zMl9jZmcudm1pZCwKPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgIC5hc2lkID0gaW52X2luZm8tPnBhc2lkLAo+PiArwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgIH0sCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIH07Cj4+ICsK Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgYXJtX3NtbXVfY21kcV9pc3N1ZV9jbWQoc21tdSwg JmNtZCk7Cj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGFybV9zbW11X2NtZHFfaXNzdWVfc3lu YyhzbW11KTsKPiAKPiBJJ2QgbXVjaCByYXRoZXIgbWFrZSBhcm1fc21tdV90bGJfaW52X2NvbnRl eHQoKSB1bmRlcnN0YW5kIG5lc3RlZAo+IGRvbWFpbnMgdGhhbiBvcGVuLWNvZGUgY29tbWFuZHMg YWxsIG92ZXIgdGhlIHBsYWNlLgoKCj4gCj4+ICsKPj4gK8KgwqDCoMKgwqDCoMKgIH0gZWxzZSBp ZiAoaW52X2luZm8tPmdyYW51bGFyaXR5ID09IElPTU1VX0lOVl9HUkFOVV9BRERSKSB7Cj4+ICvC oMKgwqDCoMKgwqDCoMKgwqDCoMKgIHN0cnVjdCBpb21tdV9pbnZfYWRkcl9pbmZvICppbmZvID0g Jmludl9pbmZvLT5hZGRyX2luZm87Cj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHNpemVfdCBz aXplID0gaW5mby0+bmJfZ3JhbnVsZXMgKiBpbmZvLT5ncmFudWxlX3NpemU7Cj4+ICvCoMKgwqDC oMKgwqDCoMKgwqDCoMKgIGJvb2wgbGVhZiA9IGluZm8tPmZsYWdzICYgSU9NTVVfSU5WX0FERFJf RkxBR1NfTEVBRjsKPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgc3RydWN0IGFybV9zbW11X2Nt ZHFfZW50IGNtZCA9IHsKPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAub3Bjb2Rl ID0gQ01EUV9PUF9UTEJJX05IX1ZBLAo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg IC50bGJpID0gewo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgLmFk ZHIgPSBpbmZvLT5hZGRyLAo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqAgLnZtaWQgPSBzbW11X2RvbWFpbi0+czJfY2ZnLnZtaWQsCj4+ICvCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAuYXNpZCA9IGluZm8tPnBhc2lkLAo+PiArwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgLmxlYWYgPSBsZWFmLAo+PiArwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgIH0sCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIH07Cj4+ ICsKPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZG8gewo+PiArwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgIGFybV9zbW11X2NtZHFfaXNzdWVfY21kKHNtbXUsICZjbWQpOwo+PiArwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGNtZC50bGJpLmFkZHIgKz0gaW5mby0+Z3JhbnVs ZV9zaXplOwo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB9IHdoaWxlIChzaXplIC09IGluZm8t PmdyYW51bGVfc2l6ZSk7Cj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGFybV9zbW11X2NtZHFf aXNzdWVfc3luYyhzbW11KTsKPiAKPiBBbiB0aGlzIGluIHBhcnRpY3VsYXIgSSB3b3VsZCByZWFs bHkgbGlrZSB0byBnbyBhbGwgdGhlIHdheSB0aHJvdWdoCj4gaW9fcGd0YWJsZV90bGJfYWRkX2Zs dXNoKCkvaW9fcGd0YWJsZV9zeW5jKCkgaWYgYXQgYWxsIHBvc3NpYmxlLiBIb29raW5nCj4gdXAg cmFuZ2UtYmFzZWQgaW52YWxpZGF0aW9ucyBpcyBnb2luZyB0byBiZSBhIG1hc3NpdmUgaGVhZGFj aGUgaWYgdGhlCj4gYWJzdHJhY3Rpb24gaXNuJ3Qgc29saWQuCgpUaGUgY29uY2VybiBpcyB0aGUg aG9zdCBkb2VzIG5vdCAib3duIiB0aGUgczEgY29uZmlnIGFzaWQKKHNtbXVfZG9tYWluLT5zMV9j ZmcuY2QuYXNpZCBpcyBub3Qgc2V0LCBwcmFjdGljYWxseSkuIEluIG91ciBjYXNlIHRoZQphc2lk IG9ubHkgaXMgcGFzc2VkIGJ5IHRoZSB1c2Vyc3BhY2Ugb24gQ0FDSEVfSU5WQUxJREFURSBpb2N0 bCBjYWxsLgoKYXJtX3NtbXVfdGxiX2ludl9jb250ZXh0IGFuZCBhcm1fc21tdV90bGJfaW52X3Jh bmdlX25vc3luYyB1c2UgdGhpcyBmaWVsZAoKSmVhbi1QaGlsaXBwZSBoaWdobGlnaHRlZCB0aGF0 IGZhY3QgaW4KaHR0cHM6Ly9sa21sLm9yZy9sa21sLzIwMTkvMS8xMS8xMDYyIGFuZCBzdWdnZXN0 ZWQgdG8gb3Blbi1jb2RlIGNvbW1hbmRzCmluc3RlYWQsIGhlbmNlIHRoZSBjdXJyZW50IGZvcm0u CgpUaGFua3MKCkVyaWMKPiAKPiBSb2Jpbi4KPiAKPj4gK8KgwqDCoMKgwqDCoMKgIH0gZWxzZSB7 Cj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiAtRUlOVkFMOwo+PiArwqDCoMKgwqDC oMKgwqAgfQo+PiArwqDCoMKgIH0KPj4gK8KgwqDCoCBpZiAoaW52X2luZm8tPmNhY2hlICYgSU9N TVVfQ0FDSEVfSU5WX1RZUEVfUEFTSUQgfHwKPj4gK8KgwqDCoMKgwqDCoMKgIGludl9pbmZvLT5j YWNoZSAmIElPTU1VX0NBQ0hFX0lOVl9UWVBFX0RFVl9JT1RMQikgewo+PiArwqDCoMKgwqDCoMKg wqAgcmV0dXJuIC1FTk9FTlQ7Cj4+ICvCoMKgwqAgfQo+PiArwqDCoMKgIHJldHVybiAwOwo+PiAr fQo+PiArCj4+IMKgIHN0YXRpYyBzdHJ1Y3QgaW9tbXVfb3BzIGFybV9zbW11X29wcyA9IHsKPj4g wqDCoMKgwqDCoCAuY2FwYWJsZcKgwqDCoMKgwqDCoMKgID0gYXJtX3NtbXVfY2FwYWJsZSwKPj4g wqDCoMKgwqDCoCAuZG9tYWluX2FsbG9jwqDCoMKgwqDCoMKgwqAgPSBhcm1fc21tdV9kb21haW5f YWxsb2MsCj4+IEBAIC0yMzQ2LDYgKzI0MDUsNyBAQCBzdGF0aWMgc3RydWN0IGlvbW11X29wcyBh cm1fc21tdV9vcHMgPSB7Cj4+IMKgwqDCoMKgwqAgLnB1dF9yZXN2X3JlZ2lvbnPCoMKgwqAgPSBh cm1fc21tdV9wdXRfcmVzdl9yZWdpb25zLAo+PiDCoMKgwqDCoMKgIC5hdHRhY2hfcGFzaWRfdGFi bGXCoMKgwqAgPSBhcm1fc21tdV9hdHRhY2hfcGFzaWRfdGFibGUsCj4+IMKgwqDCoMKgwqAgLmRl dGFjaF9wYXNpZF90YWJsZcKgwqDCoCA9IGFybV9zbW11X2RldGFjaF9wYXNpZF90YWJsZSwKPj4g K8KgwqDCoCAuY2FjaGVfaW52YWxpZGF0ZcKgwqDCoCA9IGFybV9zbW11X2NhY2hlX2ludmFsaWRh dGUsCj4+IMKgwqDCoMKgwqAgLnBnc2l6ZV9iaXRtYXDCoMKgwqDCoMKgwqDCoCA9IC0xVUwsIC8q IFJlc3RyaWN0ZWQgZHVyaW5nIGRldmljZSBhdHRhY2ggKi8KPj4gwqAgfTsKPj4gwqAKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KaW9tbXUgbWFpbGluZyBs aXN0CmlvbW11QGxpc3RzLmxpbnV4LWZvdW5kYXRpb24ub3JnCmh0dHBzOi8vbGlzdHMubGludXhm b3VuZGF0aW9uLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lvbW11 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0A85C04AA7 for ; Mon, 13 May 2019 12:16:16 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 7241D20879 for ; Mon, 13 May 2019 12:16:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7241D20879 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id ED3A84A4F2; Mon, 13 May 2019 08:16:15 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 494I1azf7FZj; Mon, 13 May 2019 08:16:14 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 7F90E4A4CA; Mon, 13 May 2019 08:16:14 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id DA6514A4AA for ; Mon, 13 May 2019 08:16:13 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NFIJpD5uSKzn for ; Mon, 13 May 2019 08:16:12 -0400 (EDT) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 52DA04A3A3 for ; Mon, 13 May 2019 08:16:12 -0400 (EDT) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2F26F87620; Mon, 13 May 2019 12:16:11 +0000 (UTC) Received: from [10.36.116.17] (ovpn-116-17.ams2.redhat.com [10.36.116.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BB24219C67; Mon, 13 May 2019 12:16:03 +0000 (UTC) Subject: Re: [PATCH v7 14/23] iommu/smmuv3: Implement cache_invalidate To: Robin Murphy , eric.auger.pro@gmail.com, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, joro@8bytes.org, alex.williamson@redhat.com, jacob.jun.pan@linux.intel.com, yi.l.liu@intel.com, jean-philippe.brucker@arm.com, will.deacon@arm.com References: <20190408121911.24103-1-eric.auger@redhat.com> <20190408121911.24103-15-eric.auger@redhat.com> From: Auger Eric Message-ID: Date: Mon, 13 May 2019 14:16:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 13 May 2019 12:16:11 +0000 (UTC) Cc: kevin.tian@intel.com, vincent.stehle@arm.com, ashok.raj@intel.com, marc.zyngier@arm.com X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu SGkgUm9iaW4sCk9uIDUvOC8xOSA1OjAxIFBNLCBSb2JpbiBNdXJwaHkgd3JvdGU6Cj4gT24gMDgv MDQvMjAxOSAxMzoxOSwgRXJpYyBBdWdlciB3cm90ZToKPj4gSW1wbGVtZW50IGRvbWFpbi1zZWxl Y3RpdmUgYW5kIHBhZ2Utc2VsZWN0aXZlIElPVExCIGludmFsaWRhdGlvbnMuCj4+Cj4+IFNpZ25l ZC1vZmYtYnk6IEVyaWMgQXVnZXIgPGVyaWMuYXVnZXJAcmVkaGF0LmNvbT4KPj4KPj4gLS0tCj4+ IHY2IC0+IHY3Cj4+IC0gY2hlY2sgdGhlIHVhcGkgdmVyc2lvbgo+Pgo+PiB2MyAtPiB2NDoKPj4g LSBhZGFwdCB0byBjaGFuZ2VzIGluIHRoZSB1YXBpCj4+IC0gYWRkIHN1cHBvcnQgZm9yIGxlYWYg cGFyYW1ldGVyCj4+IC0gZG8gbm90IHVzZSBhcm1fc21tdV90bGJfaW52X3JhbmdlX25vc3luYyBv ciBhcm1fc21tdV90bGJfaW52X2NvbnRleHQKPj4gwqDCoCBhbnltb3JlCj4+Cj4+IHYyIC0+IHYz Ogo+PiAtIHJlcGxhY2UgX19hcm1fc21tdV90bGJfc3luYyBieSBhcm1fc21tdV9jbWRxX2lzc3Vl X3N5bmMKPj4KPj4gdjEgLT4gdjI6Cj4+IC0gcHJvcGVybHkgcGFzcyB0aGUgYXNpZAo+PiAtLS0K Pj4gwqAgZHJpdmVycy9pb21tdS9hcm0tc21tdS12My5jIHwgNjAgKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKwo+PiDCoCAxIGZpbGUgY2hhbmdlZCwgNjAgaW5zZXJ0aW9ucygr KQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9pb21tdS9hcm0tc21tdS12My5jIGIvZHJpdmVy cy9pb21tdS9hcm0tc21tdS12My5jCj4+IGluZGV4IDE0ODZiYWY1MzQyNS4uNDM2NjkyMWQ4MzE4 IDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2lvbW11L2FybS1zbW11LXYzLmMKPj4gKysrIGIvZHJp dmVycy9pb21tdS9hcm0tc21tdS12My5jCj4+IEBAIC0yMzI2LDYgKzIzMjYsNjUgQEAgc3RhdGlj IHZvaWQgYXJtX3NtbXVfZGV0YWNoX3Bhc2lkX3RhYmxlKHN0cnVjdAo+PiBpb21tdV9kb21haW4g KmRvbWFpbikKPj4gwqDCoMKgwqDCoCBtdXRleF91bmxvY2soJnNtbXVfZG9tYWluLT5pbml0X211 dGV4KTsKPj4gwqAgfQo+PiDCoCArc3RhdGljIGludAo+PiArYXJtX3NtbXVfY2FjaGVfaW52YWxp ZGF0ZShzdHJ1Y3QgaW9tbXVfZG9tYWluICpkb21haW4sIHN0cnVjdCBkZXZpY2UKPj4gKmRldiwK Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHN0cnVjdCBpb21tdV9jYWNoZV9pbnZhbGlk YXRlX2luZm8gKmludl9pbmZvKQo+PiArewo+PiArwqDCoMKgIHN0cnVjdCBhcm1fc21tdV9kb21h aW4gKnNtbXVfZG9tYWluID0gdG9fc21tdV9kb21haW4oZG9tYWluKTsKPj4gK8KgwqDCoCBzdHJ1 Y3QgYXJtX3NtbXVfZGV2aWNlICpzbW11ID0gc21tdV9kb21haW4tPnNtbXU7Cj4+ICsKPj4gK8Kg wqDCoCBpZiAoc21tdV9kb21haW4tPnN0YWdlICE9IEFSTV9TTU1VX0RPTUFJTl9ORVNURUQpCj4+ ICvCoMKgwqDCoMKgwqDCoCByZXR1cm4gLUVJTlZBTDsKPj4gKwo+PiArwqDCoMKgIGlmICghc21t dSkKPj4gK8KgwqDCoMKgwqDCoMKgIHJldHVybiAtRUlOVkFMOwo+PiArCj4+ICvCoMKgwqAgaWYg KGludl9pbmZvLT52ZXJzaW9uICE9IElPTU1VX0NBQ0hFX0lOVkFMSURBVEVfSU5GT19WRVJTSU9O XzEpCj4+ICvCoMKgwqDCoMKgwqDCoCByZXR1cm4gLUVJTlZBTDsKPj4gKwo+PiArwqDCoMKgIGlm IChpbnZfaW5mby0+Y2FjaGUgJiBJT01NVV9DQUNIRV9JTlZfVFlQRV9JT1RMQikgewo+PiArwqDC oMKgwqDCoMKgwqAgaWYgKGludl9pbmZvLT5ncmFudWxhcml0eSA9PSBJT01NVV9JTlZfR1JBTlVf UEFTSUQpIHsKPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgc3RydWN0IGFybV9zbW11X2NtZHFf ZW50IGNtZCA9IHsKPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAub3Bjb2RlID0g Q01EUV9PUF9UTEJJX05IX0FTSUQsCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg LnRsYmkgPSB7Cj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAudm1p ZCA9IHNtbXVfZG9tYWluLT5zMl9jZmcudm1pZCwKPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgIC5hc2lkID0gaW52X2luZm8tPnBhc2lkLAo+PiArwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgIH0sCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIH07Cj4+ICsK Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgYXJtX3NtbXVfY21kcV9pc3N1ZV9jbWQoc21tdSwg JmNtZCk7Cj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGFybV9zbW11X2NtZHFfaXNzdWVfc3lu YyhzbW11KTsKPiAKPiBJJ2QgbXVjaCByYXRoZXIgbWFrZSBhcm1fc21tdV90bGJfaW52X2NvbnRl eHQoKSB1bmRlcnN0YW5kIG5lc3RlZAo+IGRvbWFpbnMgdGhhbiBvcGVuLWNvZGUgY29tbWFuZHMg YWxsIG92ZXIgdGhlIHBsYWNlLgoKCj4gCj4+ICsKPj4gK8KgwqDCoMKgwqDCoMKgIH0gZWxzZSBp ZiAoaW52X2luZm8tPmdyYW51bGFyaXR5ID09IElPTU1VX0lOVl9HUkFOVV9BRERSKSB7Cj4+ICvC oMKgwqDCoMKgwqDCoMKgwqDCoMKgIHN0cnVjdCBpb21tdV9pbnZfYWRkcl9pbmZvICppbmZvID0g Jmludl9pbmZvLT5hZGRyX2luZm87Cj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHNpemVfdCBz aXplID0gaW5mby0+bmJfZ3JhbnVsZXMgKiBpbmZvLT5ncmFudWxlX3NpemU7Cj4+ICvCoMKgwqDC oMKgwqDCoMKgwqDCoMKgIGJvb2wgbGVhZiA9IGluZm8tPmZsYWdzICYgSU9NTVVfSU5WX0FERFJf RkxBR1NfTEVBRjsKPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgc3RydWN0IGFybV9zbW11X2Nt ZHFfZW50IGNtZCA9IHsKPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAub3Bjb2Rl ID0gQ01EUV9PUF9UTEJJX05IX1ZBLAo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg IC50bGJpID0gewo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgLmFk ZHIgPSBpbmZvLT5hZGRyLAo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqAgLnZtaWQgPSBzbW11X2RvbWFpbi0+czJfY2ZnLnZtaWQsCj4+ICvCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAuYXNpZCA9IGluZm8tPnBhc2lkLAo+PiArwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgLmxlYWYgPSBsZWFmLAo+PiArwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgIH0sCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIH07Cj4+ ICsKPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZG8gewo+PiArwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgIGFybV9zbW11X2NtZHFfaXNzdWVfY21kKHNtbXUsICZjbWQpOwo+PiArwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGNtZC50bGJpLmFkZHIgKz0gaW5mby0+Z3JhbnVs ZV9zaXplOwo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB9IHdoaWxlIChzaXplIC09IGluZm8t PmdyYW51bGVfc2l6ZSk7Cj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGFybV9zbW11X2NtZHFf aXNzdWVfc3luYyhzbW11KTsKPiAKPiBBbiB0aGlzIGluIHBhcnRpY3VsYXIgSSB3b3VsZCByZWFs bHkgbGlrZSB0byBnbyBhbGwgdGhlIHdheSB0aHJvdWdoCj4gaW9fcGd0YWJsZV90bGJfYWRkX2Zs dXNoKCkvaW9fcGd0YWJsZV9zeW5jKCkgaWYgYXQgYWxsIHBvc3NpYmxlLiBIb29raW5nCj4gdXAg cmFuZ2UtYmFzZWQgaW52YWxpZGF0aW9ucyBpcyBnb2luZyB0byBiZSBhIG1hc3NpdmUgaGVhZGFj aGUgaWYgdGhlCj4gYWJzdHJhY3Rpb24gaXNuJ3Qgc29saWQuCgpUaGUgY29uY2VybiBpcyB0aGUg aG9zdCBkb2VzIG5vdCAib3duIiB0aGUgczEgY29uZmlnIGFzaWQKKHNtbXVfZG9tYWluLT5zMV9j ZmcuY2QuYXNpZCBpcyBub3Qgc2V0LCBwcmFjdGljYWxseSkuIEluIG91ciBjYXNlIHRoZQphc2lk IG9ubHkgaXMgcGFzc2VkIGJ5IHRoZSB1c2Vyc3BhY2Ugb24gQ0FDSEVfSU5WQUxJREFURSBpb2N0 bCBjYWxsLgoKYXJtX3NtbXVfdGxiX2ludl9jb250ZXh0IGFuZCBhcm1fc21tdV90bGJfaW52X3Jh bmdlX25vc3luYyB1c2UgdGhpcyBmaWVsZAoKSmVhbi1QaGlsaXBwZSBoaWdobGlnaHRlZCB0aGF0 IGZhY3QgaW4KaHR0cHM6Ly9sa21sLm9yZy9sa21sLzIwMTkvMS8xMS8xMDYyIGFuZCBzdWdnZXN0 ZWQgdG8gb3Blbi1jb2RlIGNvbW1hbmRzCmluc3RlYWQsIGhlbmNlIHRoZSBjdXJyZW50IGZvcm0u CgpUaGFua3MKCkVyaWMKPiAKPiBSb2Jpbi4KPiAKPj4gK8KgwqDCoMKgwqDCoMKgIH0gZWxzZSB7 Cj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiAtRUlOVkFMOwo+PiArwqDCoMKgwqDC oMKgwqAgfQo+PiArwqDCoMKgIH0KPj4gK8KgwqDCoCBpZiAoaW52X2luZm8tPmNhY2hlICYgSU9N TVVfQ0FDSEVfSU5WX1RZUEVfUEFTSUQgfHwKPj4gK8KgwqDCoMKgwqDCoMKgIGludl9pbmZvLT5j YWNoZSAmIElPTU1VX0NBQ0hFX0lOVl9UWVBFX0RFVl9JT1RMQikgewo+PiArwqDCoMKgwqDCoMKg wqAgcmV0dXJuIC1FTk9FTlQ7Cj4+ICvCoMKgwqAgfQo+PiArwqDCoMKgIHJldHVybiAwOwo+PiAr fQo+PiArCj4+IMKgIHN0YXRpYyBzdHJ1Y3QgaW9tbXVfb3BzIGFybV9zbW11X29wcyA9IHsKPj4g wqDCoMKgwqDCoCAuY2FwYWJsZcKgwqDCoMKgwqDCoMKgID0gYXJtX3NtbXVfY2FwYWJsZSwKPj4g wqDCoMKgwqDCoCAuZG9tYWluX2FsbG9jwqDCoMKgwqDCoMKgwqAgPSBhcm1fc21tdV9kb21haW5f YWxsb2MsCj4+IEBAIC0yMzQ2LDYgKzI0MDUsNyBAQCBzdGF0aWMgc3RydWN0IGlvbW11X29wcyBh cm1fc21tdV9vcHMgPSB7Cj4+IMKgwqDCoMKgwqAgLnB1dF9yZXN2X3JlZ2lvbnPCoMKgwqAgPSBh cm1fc21tdV9wdXRfcmVzdl9yZWdpb25zLAo+PiDCoMKgwqDCoMKgIC5hdHRhY2hfcGFzaWRfdGFi bGXCoMKgwqAgPSBhcm1fc21tdV9hdHRhY2hfcGFzaWRfdGFibGUsCj4+IMKgwqDCoMKgwqAgLmRl dGFjaF9wYXNpZF90YWJsZcKgwqDCoCA9IGFybV9zbW11X2RldGFjaF9wYXNpZF90YWJsZSwKPj4g K8KgwqDCoCAuY2FjaGVfaW52YWxpZGF0ZcKgwqDCoCA9IGFybV9zbW11X2NhY2hlX2ludmFsaWRh dGUsCj4+IMKgwqDCoMKgwqAgLnBnc2l6ZV9iaXRtYXDCoMKgwqDCoMKgwqDCoCA9IC0xVUwsIC8q IFJlc3RyaWN0ZWQgZHVyaW5nIGRldmljZSBhdHRhY2ggKi8KPj4gwqAgfTsKPj4gwqAKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Ka3ZtYXJtIG1haWxpbmcg bGlzdAprdm1hcm1AbGlzdHMuY3MuY29sdW1iaWEuZWR1Cmh0dHBzOi8vbGlzdHMuY3MuY29sdW1i aWEuZWR1L21haWxtYW4vbGlzdGluZm8va3ZtYXJtCg==