From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26ABAC4361B for ; Wed, 16 Dec 2020 12:06:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BDF5D2339F for ; Wed, 16 Dec 2020 12:06:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725802AbgLPMG0 (ORCPT ); Wed, 16 Dec 2020 07:06:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46246 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725550AbgLPMG0 (ORCPT ); Wed, 16 Dec 2020 07:06:26 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3DD0C061794 for ; Wed, 16 Dec 2020 04:05:45 -0800 (PST) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kpVYo-0003Zf-1I; Wed, 16 Dec 2020 13:05:38 +0100 Message-ID: Subject: Re: [PATCH v2 1/1] phy: fsl-imx8-mipi-dphy: Hook into runtime pm From: Lucas Stach To: Guido =?ISO-8859-1?Q?G=FCnther?= , Kishon Vijay Abraham I , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Robert Chiras , Sam Ravnborg , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Date: Wed, 16 Dec 2020 13:05:36 +0100 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.2 (3.38.2-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Guido, this time hopefully with less broken quoting. My mailer is driving me mad right now... Am Mittwoch, dem 16.12.2020 um 12:27 +0100 schrieb Guido Günther: > This allows us to shut down the mipi power domain on the imx8. The > alternative would be to drop the dphy from the mipi power domain in the > SOCs device tree and only have the DSI host controller visible there but > since the PD is mostly about the PHY that would defeat it's purpose. Adding RPM support is exactly the right course of action. > This allows to shut off the power domain hen blanking the LCD panel: > > pm_genpd_summary before: > > domain status slaves >     /device runtime status > ---------------------------------------------------------------------- > mipi on >     /devices/platform/soc@0/soc@0:bus@30800000/30a00300.dphy unsupported >     /devices/platform/soc@0/soc@0:bus@30800000/30a00000.mipi_dsi suspended > > after: > > mipi off-0 >     /devices/platform/soc@0/soc@0:bus@30800000/30a00300.dphy suspended >     /devices/platform/soc@0/soc@0:bus@30800000/30a00000.mipi_dsi suspended > > Signed-off-by: Guido Günther > --- >  .../phy/freescale/phy-fsl-imx8-mipi-dphy.c | 22 ++++++++++++++++++- >  1 file changed, 21 insertions(+), 1 deletion(-) > > diff --git a/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c b/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c > index a95572b397ca..34e2d801e520 100644 > --- a/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c > +++ b/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c > @@ -14,6 +14,7 @@ >  #include >  #include >  #include > +#include >  #include >   >  /* DPHY registers */ > @@ -93,6 +94,7 @@ struct mixel_dphy_cfg { >  }; >   >  struct mixel_dphy_priv { > + struct device *dev; >   struct mixel_dphy_cfg cfg; >   struct regmap *regmap; >   struct clk *phy_ref_clk; > @@ -382,6 +384,7 @@ static int mixel_dphy_power_on(struct phy *phy) >   ret = clk_prepare_enable(priv->phy_ref_clk); >   if (ret < 0) >   return ret; > + pm_runtime_get_sync(priv->dev); >   This call can fail and will leave you with an elevated rpm refcount. Better use the new pm_runtime_resume_and_get to avoid this issue? Nitpick: I would add a blank line before the call. Regards, Lucas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E9A6C4361B for ; Wed, 16 Dec 2020 12:07:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CAC4F2339F for ; Wed, 16 Dec 2020 12:07:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CAC4F2339F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe :List-Id:MIME-Version:References:In-Reply-To:Date:To:From:Subject:Message-ID: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=awu8Zo5dtfhGZbPnpHcmXwITmLzFhHiYrELlizp2GJg=; b=OQtDJnfr0qKvgfDtWErYm5tBB3 HkFcwlHVkV8PFRqGEcKmbDSBqrJ55F+BrxASqovhg+SeBzl9/Mi7g2yONAhNHzYEWcFGoUMKDE670 pOGhMtQbOjqCsOocNLLgOWRSSKpDlRS0Pb1e+wQH8LrXI6ZZKOUHd7cIKXlPZ0C8Moc2NWNvg2Zfp 9udbFuM6klGTU17J08bNLzZ5/jXIOxNXst1RNSp0n9609NcpR5UYJqIRa9Tw0k/nuE+63bAlcrzKt +erNaqV9lLOA51pBMJWEcJBxXuNUEgNcP9RNrrwsSLnvUxjach80IokwPUIAdTGk2OIdhkyjl5tsD Tv2eeNcA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kpVZ1-0000Od-Fj; Wed, 16 Dec 2020 12:05:51 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kpVYx-0000O7-EC for linux-arm-kernel@lists.infradead.org; Wed, 16 Dec 2020 12:05:49 +0000 Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kpVYo-0003Zf-1I; Wed, 16 Dec 2020 13:05:38 +0100 Message-ID: Subject: Re: [PATCH v2 1/1] phy: fsl-imx8-mipi-dphy: Hook into runtime pm From: Lucas Stach To: Guido =?ISO-8859-1?Q?G=FCnther?= , Kishon Vijay Abraham I , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Robert Chiras , Sam Ravnborg , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Date: Wed, 16 Dec 2020 13:05:36 +0100 In-Reply-To: References: User-Agent: Evolution 3.38.2 (3.38.2-1.fc33) MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201216_070547_499784_8D634A41 X-CRM114-Status: GOOD ( 19.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgR3VpZG8sCgp0aGlzIHRpbWUgaG9wZWZ1bGx5IHdpdGggbGVzcyBicm9rZW4gcXVvdGluZy4g TXkgbWFpbGVyIGlzIGRyaXZpbmcgbWUKbWFkIHJpZ2h0IG5vdy4uLgoKQW0gTWl0dHdvY2gsIGRl bSAxNi4xMi4yMDIwIHVtIDEyOjI3ICswMTAwIHNjaHJpZWIgR3VpZG8gR8O8bnRoZXI6Cj4gVGhp cyBhbGxvd3MgdXMgdG8gc2h1dCBkb3duIHRoZSBtaXBpIHBvd2VyIGRvbWFpbiBvbiB0aGUgaW14 OC4gVGhlCj4gYWx0ZXJuYXRpdmUgd291bGQgYmUgdG8gZHJvcCB0aGUgZHBoeSBmcm9tIHRoZSBt aXBpIHBvd2VyIGRvbWFpbiBpbiB0aGUKPiBTT0NzIGRldmljZSB0cmVlIGFuZCBvbmx5IGhhdmUg dGhlIERTSSBob3N0IGNvbnRyb2xsZXIgdmlzaWJsZSB0aGVyZSBidXQKPiBzaW5jZSB0aGUgUEQg aXMgbW9zdGx5IGFib3V0IHRoZSBQSFkgdGhhdCB3b3VsZCBkZWZlYXQgaXQncyBwdXJwb3NlLgoK QWRkaW5nIFJQTSBzdXBwb3J0IGlzIGV4YWN0bHkgdGhlIHJpZ2h0IGNvdXJzZSBvZiBhY3Rpb24u Cgo+IFRoaXMgYWxsb3dzIHRvIHNodXQgb2ZmIHRoZSBwb3dlciBkb21haW4gaGVuIGJsYW5raW5n IHRoZSBMQ0QgcGFuZWw6Cj4gCj4gcG1fZ2VucGRfc3VtbWFyeSBiZWZvcmU6Cj4gCj4gZG9tYWlu ICAgICAgICAgICAgICAgICAgICAgICAgICBzdGF0dXMgICAgICAgICAgc2xhdmVzCj4gwqDCoMKg wqAvZGV2aWNlICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcnVu dGltZSBzdGF0dXMKPiAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gbWlwaSAgICAgICAgICAgICAgICAgICAgICAg ICAgICBvbgo+IMKgwqDCoMKgL2RldmljZXMvcGxhdGZvcm0vc29jQDAvc29jQDA6YnVzQDMwODAw MDAwLzMwYTAwMzAwLmRwaHkgIHVuc3VwcG9ydGVkCj4gwqDCoMKgwqAvZGV2aWNlcy9wbGF0Zm9y bS9zb2NAMC9zb2NAMDpidXNAMzA4MDAwMDAvMzBhMDAwMDAubWlwaV9kc2kgIHN1c3BlbmRlZAo+ IAo+IGFmdGVyOgo+IAo+IG1pcGkgICAgICAgICAgICAgICAgICAgICAgICAgICAgb2ZmLTAKPiDC oMKgwqDCoC9kZXZpY2VzL3BsYXRmb3JtL3NvY0AwL3NvY0AwOmJ1c0AzMDgwMDAwMC8zMGEwMDMw MC5kcGh5ICBzdXNwZW5kZWQKPiDCoMKgwqDCoC9kZXZpY2VzL3BsYXRmb3JtL3NvY0AwL3NvY0Aw OmJ1c0AzMDgwMDAwMC8zMGEwMDAwMC5taXBpX2RzaSAgc3VzcGVuZGVkCj4gCj4gU2lnbmVkLW9m Zi1ieTogR3VpZG8gR8O8bnRoZXIgPGFneEBzaWd4Y3B1Lm9yZz4KPiAtLS0KPiDCoC4uLi9waHkv ZnJlZXNjYWxlL3BoeS1mc2wtaW14OC1taXBpLWRwaHkuYyAgICB8IDIyICsrKysrKysrKysrKysr KysrKy0KPiDCoDEgZmlsZSBjaGFuZ2VkLCAyMSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0p Cj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGh5L2ZyZWVzY2FsZS9waHktZnNsLWlteDgtbWlw aS1kcGh5LmMgYi9kcml2ZXJzL3BoeS9mcmVlc2NhbGUvcGh5LWZzbC1pbXg4LW1pcGktZHBoeS5j Cj4gaW5kZXggYTk1NTcyYjM5N2NhLi4zNGUyZDgwMWU1MjAgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy9waHkvZnJlZXNjYWxlL3BoeS1mc2wtaW14OC1taXBpLWRwaHkuYwo+ICsrKyBiL2RyaXZlcnMv cGh5L2ZyZWVzY2FsZS9waHktZnNsLWlteDgtbWlwaS1kcGh5LmMKPiBAQCAtMTQsNiArMTQsNyBA QAo+IMKgI2luY2x1ZGUgPGxpbnV4L29mX3BsYXRmb3JtLmg+Cj4gwqAjaW5jbHVkZSA8bGludXgv cGh5L3BoeS5oPgo+IMKgI2luY2x1ZGUgPGxpbnV4L3BsYXRmb3JtX2RldmljZS5oPgo+ICsjaW5j bHVkZSA8bGludXgvcG1fcnVudGltZS5oPgo+IMKgI2luY2x1ZGUgPGxpbnV4L3JlZ21hcC5oPgo+ IMKgCj4gwqAvKiBEUEhZIHJlZ2lzdGVycyAqLwo+IEBAIC05Myw2ICs5NCw3IEBAIHN0cnVjdCBt aXhlbF9kcGh5X2NmZyB7Cj4gwqB9Owo+IMKgCj4gwqBzdHJ1Y3QgbWl4ZWxfZHBoeV9wcml2IHsK PiArCXN0cnVjdCBkZXZpY2UgKmRldjsKPiDCoAlzdHJ1Y3QgbWl4ZWxfZHBoeV9jZmcgY2ZnOwo+ IMKgCXN0cnVjdCByZWdtYXAgKnJlZ21hcDsKPiDCoAlzdHJ1Y3QgY2xrICpwaHlfcmVmX2NsazsK PiBAQCAtMzgyLDYgKzM4NCw3IEBAIHN0YXRpYyBpbnQgbWl4ZWxfZHBoeV9wb3dlcl9vbihzdHJ1 Y3QgcGh5ICpwaHkpCj4gwqAJcmV0ID0gY2xrX3ByZXBhcmVfZW5hYmxlKHByaXYtPnBoeV9yZWZf Y2xrKTsKPiDCoAlpZiAocmV0IDwgMCkKPiDCoAkJcmV0dXJuIHJldDsKPiArCXBtX3J1bnRpbWVf Z2V0X3N5bmMocHJpdi0+ZGV2KTsKPiDCoAoKVGhpcyBjYWxsIGNhbiBmYWlsIGFuZCB3aWxsIGxl YXZlIHlvdSB3aXRoIGFuIGVsZXZhdGVkIHJwbSByZWZjb3VudC4KQmV0dGVyIHVzZSB0aGUgbmV3 IHBtX3J1bnRpbWVfcmVzdW1lX2FuZF9nZXQgdG8gYXZvaWQgdGhpcyBpc3N1ZT8gCgpOaXRwaWNr OiBJIHdvdWxkIGFkZCBhIGJsYW5rIGxpbmUgYmVmb3JlIHRoZSBjYWxsLgoKUmVnYXJkcywKTHVj YXMKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51 eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1h cm0ta2VybmVsCg==