From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33FA0C433B4 for ; Wed, 28 Apr 2021 11:32:55 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CA54D613D9 for ; Wed, 28 Apr 2021 11:32:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CA54D613D9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:References: Cc:To:From:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5bz6UU+O866u9znT/9yF2lNASPXMSRhvi7DM5Cisub4=; b=IgYEHeTHJN0495lCMF0jRJJAz LH1pgpXnaqAmwuPNfnoo2ko4tSylOmmEuf0xNaP/RWpItDsyh1sQoEKo3gOPOitVnVguut92+CLjD jtDi4UhbbW9w6KUqf0fMgsiBzqGBd8zuJt91BdWay6+sKBGBuEwIJVMwi926sDu/MY+q5g1Cdmj+M 1417k/eq4HjyKRLQxAJiwqk2mwKCRepYIqdQ6nFpT4mKOZaQpSWmi/dmD5kbF7NQoNI+r3wOvqdX7 SjpzWyJJADmk56A6JfIlBRTWIla/KqMVJVmqbVh69HbsG75CBcpyBmb6TaFJXqtTOqi6lLY2qBqC9 +XrW4/agQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lbiOq-003NQZ-5a; Wed, 28 Apr 2021 11:30:36 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbiOk-003NPy-Hv for linux-arm-kernel@desiato.infradead.org; Wed, 28 Apr 2021 11:30:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:References:Cc:To:From: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=GyfgRnzQvoxY1RiGpiMU5HPbVwMYw2ZcjXZWnfrqAAg=; b=AQSIgWiwBPnARM7Ol7epiSqL1Z 2lmRSktTR/qyfvuuR9tJshhTGlT6jCU8k7vsk/mIiWTyOHYOzdQ1pRTngHQb/RcWUWGrs1Wof+Yfc k0BQzraJ3J2dLukv/Zl9nRdIPL3VxaT7+QOvgPiKNhND1O8FEYXiDQCynWID54YlBOzCUXQz9vmb3 vIbHOOVRBwp+Cl6xRHfyuUWEoR7XEDcpvLZB44sQ2q11ew1p1cuF7C010PffEu1YmctfwaqeFCXk8 BPnOpaeZEMoPkjbTVtWId8cfudnbQMhLTwvsh1yaLBokdHDHF/vpOpf09lhqLprVLxnZRPKeYgdQA 6yfomENg==; Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lbiOh-00HO0u-K9 for linux-arm-kernel@lists.infradead.org; Wed, 28 Apr 2021 11:30:29 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 61EC5ED1; Wed, 28 Apr 2021 04:30:22 -0700 (PDT) Received: from [10.57.62.3] (unknown [10.57.62.3]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E5C1A3F70D; Wed, 28 Apr 2021 04:30:20 -0700 (PDT) Subject: Re: [PATCH 0/4] coresight: Add ETR-PERF polling. From: James Clark To: Daniel Kiss , mathieu.poirier@linaro.org, suzuki.poulose@arm.com, mike.leach@linaro.org, leo.yan@linaro.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org Cc: denik@google.com References: <20210421120413.3110775-1-daniel.kiss@arm.com> Message-ID: Date: Wed, 28 Apr 2021 14:30:18 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210428_043027_765935_4E5AD39F X-CRM114-Status: GOOD ( 22.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 27/04/2021 19:24, James Clark wrote: > > > On 21/04/2021 15:04, Daniel Kiss wrote: >> This series adds a feature to ETR-PERF that sync the ETR buffer to perf >> periodically. This is really handy when the system wide trace is used >> because in this case the perf won't sync during the trace. In a per-thread >> setup the traced program might not go to the kernel frequvently enought >> to collect trace. Polling helps in both usecases. Can be used with strobing. >> Tuning polling period is challanging, I'm working on an additional patch >> that adds some metrics to help tune the polling period. > > Hi Daniel, > > Is the expectation that leaving the polling period at 0 should have no affect > on the amount of data collected vs not using this patch? > > I've been running the octane 2 benchmark on Chrome on Juno and get these results: > > No patch: I consistently get 130MB of trace across dozens of runs. > Patch, polling = 0: Run 1 - 6.1MB > Run 2 - 4.7MB Sorry, these small files are because there is no AUXTRACE event at all, only built in events. It's not small because less trace was collected. > Patch, polling = 100: 1600MB > > > Thanks > James > >> >> Daniel Kiss (4): >> coresight: tmc-etr: Advance buffer pointer in sync buffer. >> coresight: tmc-etr: Track perf handler. >> coresight: etm-perf: Export etm_event_cpu_path. >> coresight: Add ETR-PERF polling. >> >> .../testing/sysfs-bus-coresight-devices-tmc | 8 + >> drivers/hwtracing/coresight/Makefile | 2 +- >> .../hwtracing/coresight/coresight-etm-perf.c | 10 +- >> .../hwtracing/coresight/coresight-etm-perf.h | 1 + >> .../coresight/coresight-etr-perf-polling.c | 316 ++++++++++++++++++ >> .../coresight/coresight-etr-perf-polling.h | 42 +++ >> .../hwtracing/coresight/coresight-tmc-core.c | 2 + >> .../hwtracing/coresight/coresight-tmc-etr.c | 22 +- >> drivers/hwtracing/coresight/coresight-tmc.h | 2 + >> 9 files changed, 401 insertions(+), 4 deletions(-) >> create mode 100644 drivers/hwtracing/coresight/coresight-etr-perf-polling.c >> create mode 100644 drivers/hwtracing/coresight/coresight-etr-perf-polling.h >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel