From: "luobin (L)" <luobin9@huawei.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <davem@davemloft.net>, <linux-kernel@vger.kernel.org>,
<netdev@vger.kernel.org>, <luoxianjun@huawei.com>,
<yin.yinshi@huawei.com>, <cloud.wangxiaoyun@huawei.com>
Subject: Re: [PATCH net-next v1 2/5] hinic: add support to set and get irq coalesce
Date: Tue, 23 Jun 2020 14:40:28 +0800 [thread overview]
Message-ID: <ee54d69c-2c94-7c40-4a92-761a73445e14@huawei.com> (raw)
In-Reply-To: <20200622150756.3624dab2@kicinski-fedora-PC1C0HJN>
On 2020/6/23 6:07, Jakub Kicinski wrote:
> On Sat, 20 Jun 2020 17:42:55 +0800 Luo bin wrote:
>> @@ -1144,8 +1190,16 @@ static int nic_dev_init(struct pci_dev *pdev)
>> goto err_reg_netdev;
>> }
>>
>> + err = hinic_init_intr_coalesce(nic_dev);
>> + if (err) {
>> + netif_err(nic_dev, drv, netdev, "Failed to init_intr_coalesce\n");
>> + goto err_init_intr;
>> + }
>> +
>> return 0;
>>
>> +err_init_intr:
>> + unregister_netdev(netdev);
>> err_reg_netdev:
>> err_set_features:
>> hinic_hwdev_cb_unregister(nic_dev->hwdev,
>
> A little suspicious - you should finish all init before device is
> registered, once registered the interface can be immediately brought
> up.
> .
>
Will fix. Thanks for your review.
next prev parent reply other threads:[~2020-06-23 6:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-20 9:42 [PATCH net-next v1 0/5] hinic: add some ethtool ops support Luo bin
2020-06-20 9:42 ` [PATCH net-next v1 1/5] hinic: add support to set and get pause params Luo bin
2020-06-20 9:42 ` [PATCH net-next v1 2/5] hinic: add support to set and get irq coalesce Luo bin
2020-06-22 22:07 ` Jakub Kicinski
2020-06-23 6:40 ` luobin (L) [this message]
2020-06-22 22:08 ` Jakub Kicinski
2020-06-23 6:41 ` luobin (L)
2020-06-20 9:42 ` [PATCH net-next v1 3/5] hinic: add self test support Luo bin
2020-06-20 9:42 ` [PATCH net-next v1 4/5] hinic: add support to identify physical device Luo bin
2020-06-20 9:42 ` [PATCH net-next v1 5/5] hinic: add support to get eeprom information Luo bin
2020-06-20 16:00 ` Andrew Lunn
2020-06-22 2:05 ` luobin (L)
2020-06-22 22:15 ` Jakub Kicinski
2020-06-23 6:48 ` luobin (L)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee54d69c-2c94-7c40-4a92-761a73445e14@huawei.com \
--to=luobin9@huawei.com \
--cc=cloud.wangxiaoyun@huawei.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luoxianjun@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=yin.yinshi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.