All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Marchevsky <davemarchevsky@fb.com>
To: Andrii Nakryiko <andrii@kernel.org>, <bpf@vger.kernel.org>,
	<ast@kernel.org>, <daniel@iogearbox.net>
Cc: <kernel-team@fb.com>, Hengqi Chen <hengqi.chen@gmail.com>
Subject: Re: [PATCH v2 bpf-next 01/12] libbpf: rename DECLARE_LIBBPF_OPTS into LIBBPF_OPTS
Date: Fri, 5 Nov 2021 02:37:14 -0400	[thread overview]
Message-ID: <ee56d236-a0b2-bdf2-ad5c-8aa77608c1d1@fb.com> (raw)
In-Reply-To: <20211103220845.2676888-2-andrii@kernel.org>

On 11/3/21 6:08 PM, Andrii Nakryiko wrote:   
> It's confusing that libbpf-provided helper macro doesn't start with
> LIBBPF. Also "declare" vs "define" is confusing terminology, I can never
> remember and always have to look up previous examples.
> 
> Bypass both issues by renaming DECLARE_LIBBPF_OPTS into a short and
> clean LIBBPF_OPTS. To avoid breaking existing code, provide:
> 
>   #define DECLARE_LIBBPF_OPTS LIBBPF_OPTS
> 
> in libbpf_legacy.h. We can decide later if we ever want to remove it or
> we'll keep it forever because it doesn't add any maintainability burden.
> 
> Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
> ---

Acked-by: Dave Marchevsky <davemarchevsky@fb.com>

>  tools/lib/bpf/bpf.h           | 1 +
>  tools/lib/bpf/libbpf_common.h | 2 +-
>  tools/lib/bpf/libbpf_legacy.h | 1 +
>  3 files changed, 3 insertions(+), 1 deletion(-)

[...]

  reply	other threads:[~2021-11-05  6:37 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-03 22:08 [PATCH v2 bpf-next 00/12] libbpf: add unified bpf_prog_load() low-level API Andrii Nakryiko
2021-11-03 22:08 ` [PATCH v2 bpf-next 01/12] libbpf: rename DECLARE_LIBBPF_OPTS into LIBBPF_OPTS Andrii Nakryiko
2021-11-05  6:37   ` Dave Marchevsky [this message]
2021-11-03 22:08 ` [PATCH v2 bpf-next 02/12] libbpf: pass number of prog load attempts explicitly Andrii Nakryiko
2021-11-05  6:42   ` Dave Marchevsky
2021-11-05 16:53     ` Andrii Nakryiko
2021-11-03 22:08 ` [PATCH v2 bpf-next 03/12] libbpf: unify low-level BPF_PROG_LOAD APIs into bpf_prog_load() Andrii Nakryiko
2021-11-03 22:08 ` [PATCH v2 bpf-next 04/12] libbpf: remove internal use of deprecated bpf_prog_load() variants Andrii Nakryiko
2021-11-03 22:08 ` [PATCH v2 bpf-next 05/12] libbpf: stop using to-be-deprecated APIs Andrii Nakryiko
2021-11-03 22:08 ` [PATCH v2 bpf-next 06/12] bpftool: stop using deprecated bpf_load_program() Andrii Nakryiko
2021-11-03 22:08 ` [PATCH v2 bpf-next 07/12] libbpf: remove deprecation attribute from struct bpf_prog_prep_result Andrii Nakryiko
2021-11-05  6:51   ` Dave Marchevsky
2021-11-03 22:08 ` [PATCH v2 bpf-next 08/12] selftests/bpf: fix non-strict SEC() program sections Andrii Nakryiko
2021-11-05  6:54   ` Dave Marchevsky
2021-11-03 22:08 ` [PATCH v2 bpf-next 09/12] selftests/bpf: convert legacy prog load APIs to bpf_prog_load() Andrii Nakryiko
2021-11-03 22:08 ` [PATCH v2 bpf-next 10/12] selftests/bpf: merge test_stub.c into testing_helpers.c Andrii Nakryiko
2021-11-05  7:51   ` Dave Marchevsky
2021-11-10  1:48   ` Alexei Starovoitov
2021-11-10  2:38     ` Andrii Nakryiko
2021-11-10  3:31       ` Alexei Starovoitov
2021-11-03 22:08 ` [PATCH v2 bpf-next 11/12] selftests/bpf: use explicit bpf_prog_test_load() calls everywhere Andrii Nakryiko
2021-11-05  7:36   ` Dave Marchevsky
2021-11-05 16:55     ` Andrii Nakryiko
2021-11-05 20:55   ` Dave Marchevsky
2021-11-03 22:08 ` [PATCH v2 bpf-next 12/12] selftests/bpf: use explicit bpf_test_load_program() helper calls Andrii Nakryiko
2021-11-05 20:56   ` Dave Marchevsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ee56d236-a0b2-bdf2-ad5c-8aa77608c1d1@fb.com \
    --to=davemarchevsky@fb.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=hengqi.chen@gmail.com \
    --cc=kernel-team@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.