From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20489C433F5 for ; Mon, 7 Mar 2022 11:25:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237941AbiCGL0i (ORCPT ); Mon, 7 Mar 2022 06:26:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240166AbiCGL0W (ORCPT ); Mon, 7 Mar 2022 06:26:22 -0500 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C050A7B576; Mon, 7 Mar 2022 02:59:26 -0800 (PST) Received: by mail-ej1-f48.google.com with SMTP id d10so30972440eje.10; Mon, 07 Mar 2022 02:59:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=r5VXslgP94xhLV5io8KJ01AqHztBTaI4x6W9LXcGA90=; b=adaCimCEapoeMYpC/ZE2NLgvStFiaW0VcbYV3GwhSoqjEeBraZzqFoRcIjXsjP4gqy cMssg5boVXUWj6spHFArGC0GdpcZ/uTNoHfPrIHUEnTGpFVreJf85nq+j0AknJNJJwE0 2gs5xOWbbSbzpTjB/4ekFu/5SrlKgTpiKJO0R+wR9RH23tYealJ46s4tJSSmxbkJhFwF BJDEDc/4o2KS8/BsgatU7cu9bHuO5QUK0ocp/oqp35xzfE0EioyB6y8YtjrMFT27/eij XRNVg76PUimdQXhWRO9YOhQM7Y4BRz7a6HBRZcStpXaEb/y51zDidyCYcW2qImMxOVCz yBVQ== X-Gm-Message-State: AOAM532/bynPl6pG+6uDVSMGysauFyf32yoDWhlSCFhBn5MOIwEJQ9Wk owAJjMLNBq3YFWElBxBGj8A= X-Google-Smtp-Source: ABdhPJzgorhzP42AxP+JSuvqOu+8dKd4gFe+NvN34jFpSiNFvrBV+ToNj4a4mEKPhuTh+iMqHgGtZA== X-Received: by 2002:a17:906:4796:b0:6d6:dd04:147b with SMTP id cw22-20020a170906479600b006d6dd04147bmr8736146ejc.80.1646650765283; Mon, 07 Mar 2022 02:59:25 -0800 (PST) Received: from [192.168.0.142] (xdsl-188-155-174-239.adslplus.ch. [188.155.174.239]) by smtp.googlemail.com with ESMTPSA id c5-20020a170906d18500b006ce371f09d4sm4656903ejz.57.2022.03.07.02.59.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Mar 2022 02:59:24 -0800 (PST) Message-ID: Date: Mon, 7 Mar 2022 11:59:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v1 4/4] usb: host: add xhci-exynos module Content-Language: en-US To: Jung Daehwan Cc: Mathias Nyman , Greg Kroah-Hartman , Randy Dunlap , "open list:USB XHCI DRIVER" , open list , Howard Yen , Jack Pham , Puma Hsu , "J . Avila" , "chihhao . chen" , sc.suh@samsung.com, cpgs@samsung.com, cpgsproxy5@samsung.com References: <1646375038-72082-1-git-send-email-dh10.jung@samsung.com> <1027007693.21646375582736.JavaMail.epsvc@epcpadp4> <32e72657-a43d-0ae1-1bf2-d15b7426765f@kernel.org> <1983025922.01646649181793.JavaMail.epsvc@epcpadp4> From: Krzysztof Kozlowski In-Reply-To: <1983025922.01646649181793.JavaMail.epsvc@epcpadp4> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/03/2022 11:26, Jung Daehwan wrote: > On Mon, Mar 07, 2022 at 11:07:04AM +0100, Krzysztof Kozlowski wrote: >> On 04/03/2022 07:23, Daehwan Jung wrote: >>> Signed-off-by: Daehwan Jung >> >> +Cc Randy, >> I guess here is the rest of the patches. >> >>> --- >>> drivers/usb/host/xhci-exynos.c | 2025 ++++++++++++++++++++++++++++++++ >>> drivers/usb/host/xhci-exynos.h | 150 +++ >>> 2 files changed, 2175 insertions(+) >>> create mode 100644 drivers/usb/host/xhci-exynos.c >>> create mode 100644 drivers/usb/host/xhci-exynos.h >>> >>> diff --git a/drivers/usb/host/xhci-exynos.c b/drivers/usb/host/xhci-exynos.c >>> new file mode 100644 >>> index 000000000000..3913c48d4b20 >>> --- /dev/null >>> +++ b/drivers/usb/host/xhci-exynos.c >>> @@ -0,0 +1,2025 @@ >>> +// SPDX-License-Identifier: GPL-2.0 >>> +/* >>> + * xhci-exynos.c - xHCI host controller driver platform Bus Glue for Exynos. >>> + * >>> + * Copyright (C) 2022 Samsung Electronics Incorporated - http://www.samsung.com >>> + * Author: Daehwan Jung >>> + * >>> + * A lot of code borrowed from the Linux xHCI driver. >> >>> + */ >>> + >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#ifdef CONFIG_SND_EXYNOS_USB_AUDIO >> >> This does not exist. >> >> Please do not add dead code to Linux kernel. >> >>> +#include "../../../sound/usb/exynos_usb_audio.h" >>> +#include >>> +#include "xhci-trace.h" >>> +#endif >>> + >>> +#include "../core/hub.h" >>> +#include "../core/phy.h" >>> +#include "xhci.h" >>> +#include "xhci-plat.h" >>> +#include "xhci-mvebu.h" >>> +#include "xhci-rcar.h" >>> +#include "../dwc3/dwc3-exynos.h" >>> +#include "../dwc3/exynos-otg.h" >> >> No, how XHCI is related to dwc3? What if different block provides XHCI, >> not DWC3? >> >>> +#include "xhci-exynos.h" >>> +#include >> >> This does not exist and does not even compile. >> >> Please do not send code which does not compile... Also, just in case - >> do not send code which compiles but does not work. :) >> > > Hi Krzysztof > > I'm sorry to confuse you. But, it's just for reference module to introduce > new feature. That's why I just submitted source code and header without > makefile. It's not going to compiled at all now. Thanks for explanation. Such of tree code must be clearly marked in commit title and subject (e.g. RFC). Additionally this out of tree module does not solve the problem of lack of users. For all your sound hooks you need in-tree user. Best regards, Krzysztof