From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA7D5C433FE for ; Mon, 21 Feb 2022 20:10:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233440AbiBUULE (ORCPT ); Mon, 21 Feb 2022 15:11:04 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:51116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231211AbiBUULD (ORCPT ); Mon, 21 Feb 2022 15:11:03 -0500 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 244DFBC2A; Mon, 21 Feb 2022 12:10:40 -0800 (PST) Received: by mail-lj1-x22c.google.com with SMTP id o9so16284650ljq.4; Mon, 21 Feb 2022 12:10:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=HGhrkRGOxLTFPp0IvWu9pw9Pr8JdXDbThJB0IGV8xLU=; b=q05VbA/LdGRm9JI5iCC7R/6MHFp+p8hZ7hUIYwm0rPqadyc6l2odkS+knjxOCpTps0 0sn6JFA9ssyLAbfwEVZ7ciYQOPIbSQ5yOe2TxD9CT6N5+syqrdhqYpD45OLJlzm2Aphn JWMIYoq2bZI7jWflq8ftt8dKRu1/j97aYVkHlpXv9D4YNke2C7SeuCm/eunLAQ7tRsFX sdu2IEu6ZBpIU7OOJF8SAqn4ekdM35Sj9w3AsMIJ1E8b90sR9SghHLRPb23kBgivNu5P ePh2N/IYToJOAe6+2X5tRaUkLZuxsHNHOHXQq/T8/dXPZRg2PsASzqtkod4GY6XwfNYk i1nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=HGhrkRGOxLTFPp0IvWu9pw9Pr8JdXDbThJB0IGV8xLU=; b=n9gKX7B+Eg91xqysULmY5qVsw9gWW+QVWbnH6vvY6BbAmjKUbxCWAPaY8+hD9WZWB8 kEXmq2jGno6nYz2Ml4CNHIALK2VLKlpzpwFwTkGWjHLc/J1OV55iPl9dMU2pD5MDN+52 UXSO4w6w+WgfO8pKeQipdzgcBxKjZBL/oSNlcTpQeBLgmW788yoQNV+X6f8meH5mxLBA xc+W7/JBIOsyoE6GSG+rwYOdxzSe1HkEoBPSaB1CoMxi2qqhcsk17si2v4OKWTanrgfV /DYB0Qng0BIWZtZvvddYibnspGv0UictHEr6yaseXnCkzVyfy4Fedy7Aj/micg5K5upa HUNg== X-Gm-Message-State: AOAM532gFiYjWK26AASJvNklx7s/jO+TvqK1/MpLnaoug9WENSgxduO/ CABz6wfiOkSy2mEqmUQdKnU= X-Google-Smtp-Source: ABdhPJyavA3z3RaF8eqkB6PeyyaK9TqvSWUKI3hfCkhd0iA6vw0WQYVeElevA+YsmAf57wtOSnmtSg== X-Received: by 2002:a2e:a4d6:0:b0:246:e66:90ed with SMTP id p22-20020a2ea4d6000000b002460e6690edmr15896034ljm.389.1645474238315; Mon, 21 Feb 2022 12:10:38 -0800 (PST) Received: from [192.168.2.145] (109-252-138-165.dynamic.spd-mgts.ru. [109.252.138.165]) by smtp.googlemail.com with ESMTPSA id d13sm813294lji.26.2022.02.21.12.10.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Feb 2022 12:10:37 -0800 (PST) Message-ID: Date: Mon, 21 Feb 2022 23:10:37 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v3 8/9] drm/tegra: vic: Implement get_streamid_offset Content-Language: en-US To: Mikko Perttunen , Mikko Perttunen , thierry.reding@gmail.com, jonathanh@nvidia.com, joro@8bytes.org, will@kernel.org, robh+dt@kernel.org, robin.murphy@arm.com Cc: linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20220218113952.3077606-1-mperttunen@nvidia.com> <20220218113952.3077606-9-mperttunen@nvidia.com> <7f4e4c47-59f1-1def-36bf-a2ded912f76d@gmail.com> <5d1b6e82-2c9d-8388-697f-0d7305a1206f@kapsi.fi> From: Dmitry Osipenko In-Reply-To: <5d1b6e82-2c9d-8388-697f-0d7305a1206f@kapsi.fi> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org 21.02.2022 14:44, Mikko Perttunen пишет: > On 2/19/22 20:54, Dmitry Osipenko wrote: >> 19.02.2022 21:49, Dmitry Osipenko пишет: >>> 18.02.2022 14:39, Mikko Perttunen пишет: >>>> +static int vic_get_streamid_offset(struct tegra_drm_client *client) >>>> +{ >>>> +    struct vic *vic = to_vic(client); >>>> +    int err; >>>> + >>>> +    err = vic_load_firmware(vic); >>> >>> You can't invoke vic_load_firmware() while RPM is suspended. Either >>> replace this with RPM get/put or do something else. > > Why not, I'm not seeing any HW accesses in vic_load_firmware? Although > it looks like it might race with the vic_load_firmware call in > vic_runtime_resume which probably needs to be fixed. It was not clear from the function's name that h/w is untouched, I read "load" as "upload" and then looked at vic_runtime_resume(). I'd rename vic_load_firmware() to vic_prepare_firmware_image(). And yes, technically lock is needed. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C29C6C433F5 for ; Mon, 21 Feb 2022 20:10:44 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 5683C408AF; Mon, 21 Feb 2022 20:10:44 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id N2uCz9kSqW1N; Mon, 21 Feb 2022 20:10:43 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp4.osuosl.org (Postfix) with ESMTPS id 2F73F4089B; Mon, 21 Feb 2022 20:10:43 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 16484C0021; Mon, 21 Feb 2022 20:10:43 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 7BF61C0011 for ; Mon, 21 Feb 2022 20:10:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 5C8E2408A1 for ; Mon, 21 Feb 2022 20:10:41 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sDiePGDrZGEt for ; Mon, 21 Feb 2022 20:10:40 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by smtp4.osuosl.org (Postfix) with ESMTPS id 93E7E4089B for ; Mon, 21 Feb 2022 20:10:40 +0000 (UTC) Received: by mail-lj1-x22e.google.com with SMTP id r20so16276928ljj.1 for ; Mon, 21 Feb 2022 12:10:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=HGhrkRGOxLTFPp0IvWu9pw9Pr8JdXDbThJB0IGV8xLU=; b=q05VbA/LdGRm9JI5iCC7R/6MHFp+p8hZ7hUIYwm0rPqadyc6l2odkS+knjxOCpTps0 0sn6JFA9ssyLAbfwEVZ7ciYQOPIbSQ5yOe2TxD9CT6N5+syqrdhqYpD45OLJlzm2Aphn JWMIYoq2bZI7jWflq8ftt8dKRu1/j97aYVkHlpXv9D4YNke2C7SeuCm/eunLAQ7tRsFX sdu2IEu6ZBpIU7OOJF8SAqn4ekdM35Sj9w3AsMIJ1E8b90sR9SghHLRPb23kBgivNu5P ePh2N/IYToJOAe6+2X5tRaUkLZuxsHNHOHXQq/T8/dXPZRg2PsASzqtkod4GY6XwfNYk i1nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=HGhrkRGOxLTFPp0IvWu9pw9Pr8JdXDbThJB0IGV8xLU=; b=Lr8kG6wTMbMiogamgNV0afYyp2fRgYN0Ho8qnUst3Q6XMOKJ21cFMTIBdUlI15NhDL ck+uczMe8Kld4+XgBpFl4nKD6V3XYELOaxMt8RCzx8hnbe9NsZT3uo/ccw7aDOtgvJmF klcLEPEimGxpYIh7MzIyYF9mHa8ua1PkNBYgHRh/HZIU8KkGeJweh5SaohUs703qlcey oB13E437uHqUlU+UIzALDGA8//1sEXE8uUX0IXmspc7PKnP6hjH6IQaZHkdqWASe9OAW IN1EysV4YQNUSpS1pa67jLfSyC8MTm96YKPMPj68i7waFo2dagqFdJ9abE4KDL1zGlX7 z7wA== X-Gm-Message-State: AOAM530IRt3tfAAujQ8sQfpKmjVlaf3NTAZGse65CtjF4iD4o76EeWfw JVNPSkfEvn8/MW6ahZp3hlo= X-Google-Smtp-Source: ABdhPJyavA3z3RaF8eqkB6PeyyaK9TqvSWUKI3hfCkhd0iA6vw0WQYVeElevA+YsmAf57wtOSnmtSg== X-Received: by 2002:a2e:a4d6:0:b0:246:e66:90ed with SMTP id p22-20020a2ea4d6000000b002460e6690edmr15896034ljm.389.1645474238315; Mon, 21 Feb 2022 12:10:38 -0800 (PST) Received: from [192.168.2.145] (109-252-138-165.dynamic.spd-mgts.ru. [109.252.138.165]) by smtp.googlemail.com with ESMTPSA id d13sm813294lji.26.2022.02.21.12.10.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Feb 2022 12:10:37 -0800 (PST) Message-ID: Date: Mon, 21 Feb 2022 23:10:37 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v3 8/9] drm/tegra: vic: Implement get_streamid_offset Content-Language: en-US To: Mikko Perttunen , Mikko Perttunen , thierry.reding@gmail.com, jonathanh@nvidia.com, joro@8bytes.org, will@kernel.org, robh+dt@kernel.org, robin.murphy@arm.com References: <20220218113952.3077606-1-mperttunen@nvidia.com> <20220218113952.3077606-9-mperttunen@nvidia.com> <7f4e4c47-59f1-1def-36bf-a2ded912f76d@gmail.com> <5d1b6e82-2c9d-8388-697f-0d7305a1206f@kapsi.fi> From: Dmitry Osipenko In-Reply-To: <5d1b6e82-2c9d-8388-697f-0d7305a1206f@kapsi.fi> Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, iommu@lists.linux-foundation.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" MjEuMDIuMjAyMiAxNDo0NCwgTWlra28gUGVydHR1bmVuINC/0LjRiNC10YI6Cj4gT24gMi8xOS8y MiAyMDo1NCwgRG1pdHJ5IE9zaXBlbmtvIHdyb3RlOgo+PiAxOS4wMi4yMDIyIDIxOjQ5LCBEbWl0 cnkgT3NpcGVua28g0L/QuNGI0LXRgjoKPj4+IDE4LjAyLjIwMjIgMTQ6MzksIE1pa2tvIFBlcnR0 dW5lbiDQv9C40YjQtdGCOgo+Pj4+ICtzdGF0aWMgaW50IHZpY19nZXRfc3RyZWFtaWRfb2Zmc2V0 KHN0cnVjdCB0ZWdyYV9kcm1fY2xpZW50ICpjbGllbnQpCj4+Pj4gK3sKPj4+PiArwqDCoMKgIHN0 cnVjdCB2aWMgKnZpYyA9IHRvX3ZpYyhjbGllbnQpOwo+Pj4+ICvCoMKgwqAgaW50IGVycjsKPj4+ PiArCj4+Pj4gK8KgwqDCoCBlcnIgPSB2aWNfbG9hZF9maXJtd2FyZSh2aWMpOwo+Pj4KPj4+IFlv dSBjYW4ndCBpbnZva2UgdmljX2xvYWRfZmlybXdhcmUoKSB3aGlsZSBSUE0gaXMgc3VzcGVuZGVk LiBFaXRoZXIKPj4+IHJlcGxhY2UgdGhpcyB3aXRoIFJQTSBnZXQvcHV0IG9yIGRvIHNvbWV0aGlu ZyBlbHNlLgo+IAo+IFdoeSBub3QsIEknbSBub3Qgc2VlaW5nIGFueSBIVyBhY2Nlc3NlcyBpbiB2 aWNfbG9hZF9maXJtd2FyZT8gQWx0aG91Z2gKPiBpdCBsb29rcyBsaWtlIGl0IG1pZ2h0IHJhY2Ug d2l0aCB0aGUgdmljX2xvYWRfZmlybXdhcmUgY2FsbCBpbgo+IHZpY19ydW50aW1lX3Jlc3VtZSB3 aGljaCBwcm9iYWJseSBuZWVkcyB0byBiZSBmaXhlZC4KCkl0IHdhcyBub3QgY2xlYXIgZnJvbSB0 aGUgZnVuY3Rpb24ncyBuYW1lIHRoYXQgaC93IGlzIHVudG91Y2hlZCwgSSByZWFkCiJsb2FkIiBh cyAidXBsb2FkIiBhbmQgdGhlbiBsb29rZWQgYXQgdmljX3J1bnRpbWVfcmVzdW1lKCkuIEknZCBy ZW5hbWUKdmljX2xvYWRfZmlybXdhcmUoKSB0byB2aWNfcHJlcGFyZV9maXJtd2FyZV9pbWFnZSgp LgoKQW5kIHllcywgdGVjaG5pY2FsbHkgbG9jayBpcyBuZWVkZWQuCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmlvbW11IG1haWxpbmcgbGlzdAppb21tdUBs aXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZwpodHRwczovL2xpc3RzLmxpbnV4Zm91bmRhdGlvbi5v cmcvbWFpbG1hbi9saXN0aW5mby9pb21tdQ== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16FBCC433EF for ; Mon, 21 Feb 2022 20:10:42 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1AD6310E220; Mon, 21 Feb 2022 20:10:41 +0000 (UTC) Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2D22410E220 for ; Mon, 21 Feb 2022 20:10:40 +0000 (UTC) Received: by mail-lj1-x232.google.com with SMTP id v22so14370852ljh.7 for ; Mon, 21 Feb 2022 12:10:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=HGhrkRGOxLTFPp0IvWu9pw9Pr8JdXDbThJB0IGV8xLU=; b=q05VbA/LdGRm9JI5iCC7R/6MHFp+p8hZ7hUIYwm0rPqadyc6l2odkS+knjxOCpTps0 0sn6JFA9ssyLAbfwEVZ7ciYQOPIbSQ5yOe2TxD9CT6N5+syqrdhqYpD45OLJlzm2Aphn JWMIYoq2bZI7jWflq8ftt8dKRu1/j97aYVkHlpXv9D4YNke2C7SeuCm/eunLAQ7tRsFX sdu2IEu6ZBpIU7OOJF8SAqn4ekdM35Sj9w3AsMIJ1E8b90sR9SghHLRPb23kBgivNu5P ePh2N/IYToJOAe6+2X5tRaUkLZuxsHNHOHXQq/T8/dXPZRg2PsASzqtkod4GY6XwfNYk i1nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=HGhrkRGOxLTFPp0IvWu9pw9Pr8JdXDbThJB0IGV8xLU=; b=rMnbt9nNcjf+T8OwLZGde/IC4DQVqSe2TBxyIXhFM67VXO+NpsQwVt98bFIt1ZtB7/ 3oxm7gDAZJfOtzp03UMRJVtea6g3SHjOFk2UnTjTU7MyrdfwMotOf+Bq8ytXH0AjoZnJ 5UIDOIOC7VDu0Ka/fUjznkps9eZ4H4eiXspvCQ6j+IktOHE29eNWpa7yHODcZ3mllwq5 ocjVr8tG2F/NQWmDoShpcy4Kl2f8L7AGgGdSY1fHPyQI0ZM18+CuR3D76R3PsjHsjLRW fyfHWeRezWy4yibKX+FRVFPtJidVnOcFiR79pC+xWDXjIoYfx2DuwQrxrnZcdV9BD8zE Y1XQ== X-Gm-Message-State: AOAM530Wv5YbW0z69DEeQRx3XDF5g5pfc4fZ6yuMJ+4aGHQA09TgLs40 Ss3VIBylDI/SSrnFPplnMqQ= X-Google-Smtp-Source: ABdhPJyavA3z3RaF8eqkB6PeyyaK9TqvSWUKI3hfCkhd0iA6vw0WQYVeElevA+YsmAf57wtOSnmtSg== X-Received: by 2002:a2e:a4d6:0:b0:246:e66:90ed with SMTP id p22-20020a2ea4d6000000b002460e6690edmr15896034ljm.389.1645474238315; Mon, 21 Feb 2022 12:10:38 -0800 (PST) Received: from [192.168.2.145] (109-252-138-165.dynamic.spd-mgts.ru. [109.252.138.165]) by smtp.googlemail.com with ESMTPSA id d13sm813294lji.26.2022.02.21.12.10.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Feb 2022 12:10:37 -0800 (PST) Message-ID: Date: Mon, 21 Feb 2022 23:10:37 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v3 8/9] drm/tegra: vic: Implement get_streamid_offset Content-Language: en-US To: Mikko Perttunen , Mikko Perttunen , thierry.reding@gmail.com, jonathanh@nvidia.com, joro@8bytes.org, will@kernel.org, robh+dt@kernel.org, robin.murphy@arm.com References: <20220218113952.3077606-1-mperttunen@nvidia.com> <20220218113952.3077606-9-mperttunen@nvidia.com> <7f4e4c47-59f1-1def-36bf-a2ded912f76d@gmail.com> <5d1b6e82-2c9d-8388-697f-0d7305a1206f@kapsi.fi> From: Dmitry Osipenko In-Reply-To: <5d1b6e82-2c9d-8388-697f-0d7305a1206f@kapsi.fi> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, iommu@lists.linux-foundation.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" 21.02.2022 14:44, Mikko Perttunen пишет: > On 2/19/22 20:54, Dmitry Osipenko wrote: >> 19.02.2022 21:49, Dmitry Osipenko пишет: >>> 18.02.2022 14:39, Mikko Perttunen пишет: >>>> +static int vic_get_streamid_offset(struct tegra_drm_client *client) >>>> +{ >>>> +    struct vic *vic = to_vic(client); >>>> +    int err; >>>> + >>>> +    err = vic_load_firmware(vic); >>> >>> You can't invoke vic_load_firmware() while RPM is suspended. Either >>> replace this with RPM get/put or do something else. > > Why not, I'm not seeing any HW accesses in vic_load_firmware? Although > it looks like it might race with the vic_load_firmware call in > vic_runtime_resume which probably needs to be fixed. It was not clear from the function's name that h/w is untouched, I read "load" as "upload" and then looked at vic_runtime_resume(). I'd rename vic_load_firmware() to vic_prepare_firmware_image(). And yes, technically lock is needed. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E63FC433F5 for ; Mon, 21 Feb 2022 20:11:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ewr8xImqmvqrP78jf/foxFaXPnJAOnmE6AxgSZw+sds=; b=lIaphowraE5yJx ZaVA4oUwjCdhH476uZR+GWi+tGJeswmoH/SUZQ+luS4e742OF1r+/FXCpvhG2UZ7QmM60UERK3M1G r7aj95dDbpJJImtSeaZZIEDSyE8vr5ZclHtsotHBswMvQrm1j2nNgAJjAVQLjvvs61SP+O1EwyvIM B/nuM0V5cwrvdReb+85wJKsCcBTu0SmExfln+D8c7wgyqIYBhaLhpqFW4Im7yeAebmFnz4MfcDr2s bSlAJG3f/pJDCW5VAmCqLvDIm2cAndn3X4xjpuKAK+S4Trp4gDQ2uUyBVZTskLSAXisvBGDl6X8Fm w7VwJmDMZnVQ7czJl3Gw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nMF19-0078EE-KS; Mon, 21 Feb 2022 20:10:43 +0000 Received: from mail-lj1-x230.google.com ([2a00:1450:4864:20::230]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nMF16-0078Dr-Ga for linux-arm-kernel@lists.infradead.org; Mon, 21 Feb 2022 20:10:41 +0000 Received: by mail-lj1-x230.google.com with SMTP id e2so12850553ljq.12 for ; Mon, 21 Feb 2022 12:10:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=HGhrkRGOxLTFPp0IvWu9pw9Pr8JdXDbThJB0IGV8xLU=; b=q05VbA/LdGRm9JI5iCC7R/6MHFp+p8hZ7hUIYwm0rPqadyc6l2odkS+knjxOCpTps0 0sn6JFA9ssyLAbfwEVZ7ciYQOPIbSQ5yOe2TxD9CT6N5+syqrdhqYpD45OLJlzm2Aphn JWMIYoq2bZI7jWflq8ftt8dKRu1/j97aYVkHlpXv9D4YNke2C7SeuCm/eunLAQ7tRsFX sdu2IEu6ZBpIU7OOJF8SAqn4ekdM35Sj9w3AsMIJ1E8b90sR9SghHLRPb23kBgivNu5P ePh2N/IYToJOAe6+2X5tRaUkLZuxsHNHOHXQq/T8/dXPZRg2PsASzqtkod4GY6XwfNYk i1nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=HGhrkRGOxLTFPp0IvWu9pw9Pr8JdXDbThJB0IGV8xLU=; b=3Rhq9RATw1HiNGwCrW+L9Sib/o9UVq15BQd7MORxcE1cKXNu77bpfA6MEyuhcxYRy9 hSEW6i+3t+oVT8+XfkX6qHm9he9tSO4Bfpho8ty74rHhyI054Rl1TzXnr0XMwoo40Fj/ /VGoeUDFdsTxK+soK0OkK+OnLG6a8yT9eBosEZZJCHO53wU2jaHVcIYY8UR/nClZwz9F mTXO3wPqvV6zldyzVG3pivtZ8//hSYcpf6F0qC9Ih9raC9Kg5SW0cTXYhFHuzdGrsDAr YRpV6IfWasyDttDyhhplnH0jbwgkhmbqBUDDwOPDIGgI+9V4DbZOxcuL6ttKe4E1+BYu 9UYw== X-Gm-Message-State: AOAM530e0f2e5dBbCd4866fE1DNsIKqlkPxYkSsYj1cMjdzaeaLtUbT5 KGrVFx9FOyga3BhfJWxy+3ww19FGnJo= X-Google-Smtp-Source: ABdhPJyavA3z3RaF8eqkB6PeyyaK9TqvSWUKI3hfCkhd0iA6vw0WQYVeElevA+YsmAf57wtOSnmtSg== X-Received: by 2002:a2e:a4d6:0:b0:246:e66:90ed with SMTP id p22-20020a2ea4d6000000b002460e6690edmr15896034ljm.389.1645474238315; Mon, 21 Feb 2022 12:10:38 -0800 (PST) Received: from [192.168.2.145] (109-252-138-165.dynamic.spd-mgts.ru. [109.252.138.165]) by smtp.googlemail.com with ESMTPSA id d13sm813294lji.26.2022.02.21.12.10.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Feb 2022 12:10:37 -0800 (PST) Message-ID: Date: Mon, 21 Feb 2022 23:10:37 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v3 8/9] drm/tegra: vic: Implement get_streamid_offset Content-Language: en-US To: Mikko Perttunen , Mikko Perttunen , thierry.reding@gmail.com, jonathanh@nvidia.com, joro@8bytes.org, will@kernel.org, robh+dt@kernel.org, robin.murphy@arm.com Cc: linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20220218113952.3077606-1-mperttunen@nvidia.com> <20220218113952.3077606-9-mperttunen@nvidia.com> <7f4e4c47-59f1-1def-36bf-a2ded912f76d@gmail.com> <5d1b6e82-2c9d-8388-697f-0d7305a1206f@kapsi.fi> From: Dmitry Osipenko In-Reply-To: <5d1b6e82-2c9d-8388-697f-0d7305a1206f@kapsi.fi> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220221_121040_597961_3E7379DE X-CRM114-Status: GOOD ( 10.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org MjEuMDIuMjAyMiAxNDo0NCwgTWlra28gUGVydHR1bmVuINC/0LjRiNC10YI6Cj4gT24gMi8xOS8y MiAyMDo1NCwgRG1pdHJ5IE9zaXBlbmtvIHdyb3RlOgo+PiAxOS4wMi4yMDIyIDIxOjQ5LCBEbWl0 cnkgT3NpcGVua28g0L/QuNGI0LXRgjoKPj4+IDE4LjAyLjIwMjIgMTQ6MzksIE1pa2tvIFBlcnR0 dW5lbiDQv9C40YjQtdGCOgo+Pj4+ICtzdGF0aWMgaW50IHZpY19nZXRfc3RyZWFtaWRfb2Zmc2V0 KHN0cnVjdCB0ZWdyYV9kcm1fY2xpZW50ICpjbGllbnQpCj4+Pj4gK3sKPj4+PiArwqDCoMKgIHN0 cnVjdCB2aWMgKnZpYyA9IHRvX3ZpYyhjbGllbnQpOwo+Pj4+ICvCoMKgwqAgaW50IGVycjsKPj4+ PiArCj4+Pj4gK8KgwqDCoCBlcnIgPSB2aWNfbG9hZF9maXJtd2FyZSh2aWMpOwo+Pj4KPj4+IFlv dSBjYW4ndCBpbnZva2UgdmljX2xvYWRfZmlybXdhcmUoKSB3aGlsZSBSUE0gaXMgc3VzcGVuZGVk LiBFaXRoZXIKPj4+IHJlcGxhY2UgdGhpcyB3aXRoIFJQTSBnZXQvcHV0IG9yIGRvIHNvbWV0aGlu ZyBlbHNlLgo+IAo+IFdoeSBub3QsIEknbSBub3Qgc2VlaW5nIGFueSBIVyBhY2Nlc3NlcyBpbiB2 aWNfbG9hZF9maXJtd2FyZT8gQWx0aG91Z2gKPiBpdCBsb29rcyBsaWtlIGl0IG1pZ2h0IHJhY2Ug d2l0aCB0aGUgdmljX2xvYWRfZmlybXdhcmUgY2FsbCBpbgo+IHZpY19ydW50aW1lX3Jlc3VtZSB3 aGljaCBwcm9iYWJseSBuZWVkcyB0byBiZSBmaXhlZC4KCkl0IHdhcyBub3QgY2xlYXIgZnJvbSB0 aGUgZnVuY3Rpb24ncyBuYW1lIHRoYXQgaC93IGlzIHVudG91Y2hlZCwgSSByZWFkCiJsb2FkIiBh cyAidXBsb2FkIiBhbmQgdGhlbiBsb29rZWQgYXQgdmljX3J1bnRpbWVfcmVzdW1lKCkuIEknZCBy ZW5hbWUKdmljX2xvYWRfZmlybXdhcmUoKSB0byB2aWNfcHJlcGFyZV9maXJtd2FyZV9pbWFnZSgp LgoKQW5kIHllcywgdGVjaG5pY2FsbHkgbG9jayBpcyBuZWVkZWQuCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcg bGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==