From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FA50C43331 for ; Wed, 13 Nov 2019 03:38:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2CEAB222C9 for ; Wed, 13 Nov 2019 03:38:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="NRtfCdPd"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="E8PM8j6A" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727352AbfKMDh7 (ORCPT ); Tue, 12 Nov 2019 22:37:59 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:55336 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726994AbfKMDh7 (ORCPT ); Tue, 12 Nov 2019 22:37:59 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 6DFD160591; Wed, 13 Nov 2019 03:37:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1573616278; bh=GEBgaE4DdNY7qFa24EInCgdSI0JAGHtKkaCNGSQWEpo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NRtfCdPdoaUfDngdFCmj2RtA5t6p/IyYO/860f6GKn0H4VYasYcGLyBnlX9NrtYhX f00+dwv4A0N5jfw9/8JU2uCcRrq1ZhnYSg+/5/zQ2F27hESX681yG1Ch3YyC+I1kTa p3fb3Z+3bnNvA2BCMgMFqmGDfC2gLz1lWA+BFBMY= Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id BCA8C601E7; Wed, 13 Nov 2019 03:37:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1573616277; bh=GEBgaE4DdNY7qFa24EInCgdSI0JAGHtKkaCNGSQWEpo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=E8PM8j6AtSy5jbglHF8pcJqGCJ9WhpxRqFw9ZnhJth3HeXGTWPjibTFXg4K1AN6K/ cpSTv50vWcg2JTU7RAQhCyN/7VBz5KKGSTECycbILk5aUyRTEqojDC6YK5WZwPk9Zp qeJ+Bd3+VFET4NdbTgq6jrq5WcRNRjE6URZo28G0= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Wed, 13 Nov 2019 11:37:57 +0800 From: Wen Gong To: Kalle Valo Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH v6 3/3] ath10k: add workqueue for RX path of sdio In-Reply-To: <87r22ewqi6.fsf@codeaurora.org> References: <1569402639-31720-1-git-send-email-wgong@codeaurora.org> <1569402639-31720-4-git-send-email-wgong@codeaurora.org> <8736f92sfx.fsf@kamboji.qca.qualcomm.com> <3f3641ad49a2664d346558760e38b404@codeaurora.org> <70f8f208f631a2a2c7337f45b873a16e@codeaurora.org> <87r22ewqi6.fsf@codeaurora.org> Message-ID: X-Sender: wgong@codeaurora.org User-Agent: Roundcube Webmail/1.2.5 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2019-11-11 20:23, Kalle Valo wrote: > Wen Gong writes: > >> On 2019-11-01 15:42, Wen Gong wrote: >>> On 2019-10-31 17:08, Kalle Valo wrote: >>> 、> I just realised that this is RX path so we should use >>> ATH10K_SKB_RXCB() >>>> instead. I made the change below to this commit in pending branch: >>>> >>> I will test with the new patch together with other performance >>> patches. >> Hi Kalle, I have tested with the patches of pending branch, it is >> success. >> result is same with the public review which I tested before. >> >> the patches I tested on pending branch: >> >> ath10k: enable alt data of TX path for sdio >> ath10k: add htt TX bundle for sdio >> ath10k: disable TX complete indication of htt for sdio >> ath10k: enable napi on RX path for sdio >> ath10k: sdio: remove struct ath10k_sdio_rx_data::status >> ath10k: sdio: cosmetic cleanup >> ath10k: add workqueue for RX path of sdio >> ath10k: change max RX bundle size from 8 to 32 for sdio >> ath10k: enable RX bundle receive for sdio > > Very good, thanks for testing. Hi Kalle, this patch will trigger connect fail for PSK mode AP: ath10k: add workqueue for RX path of sdio I have sent patch to fix it: ath10k: clear ieee80211_rx_status for sdio From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUjTl-0002qE-4H for ath10k@lists.infradead.org; Wed, 13 Nov 2019 03:38:02 +0000 MIME-Version: 1.0 Date: Wed, 13 Nov 2019 11:37:57 +0800 From: Wen Gong Subject: Re: [PATCH v6 3/3] ath10k: add workqueue for RX path of sdio In-Reply-To: <87r22ewqi6.fsf@codeaurora.org> References: <1569402639-31720-1-git-send-email-wgong@codeaurora.org> <1569402639-31720-4-git-send-email-wgong@codeaurora.org> <8736f92sfx.fsf@kamboji.qca.qualcomm.com> <3f3641ad49a2664d346558760e38b404@codeaurora.org> <70f8f208f631a2a2c7337f45b873a16e@codeaurora.org> <87r22ewqi6.fsf@codeaurora.org> Message-ID: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Kalle Valo Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org T24gMjAxOS0xMS0xMSAyMDoyMywgS2FsbGUgVmFsbyB3cm90ZToKPiBXZW4gR29uZyA8d2dvbmdA Y29kZWF1cm9yYS5vcmc+IHdyaXRlczoKPiAKPj4gT24gMjAxOS0xMS0wMSAxNTo0MiwgV2VuIEdv bmcgd3JvdGU6Cj4+PiBPbiAyMDE5LTEwLTMxIDE3OjA4LCBLYWxsZSBWYWxvIHdyb3RlOgo+Pj4g 44CBPiBJIGp1c3QgcmVhbGlzZWQgdGhhdCB0aGlzIGlzIFJYIHBhdGggc28gd2Ugc2hvdWxkIHVz ZQo+Pj4gQVRIMTBLX1NLQl9SWENCKCkKPj4+PiBpbnN0ZWFkLiBJIG1hZGUgdGhlIGNoYW5nZSBi ZWxvdyB0byB0aGlzIGNvbW1pdCBpbiBwZW5kaW5nIGJyYW5jaDoKPj4+PiAKPj4+IEkgd2lsbCB0 ZXN0IHdpdGggdGhlIG5ldyBwYXRjaCB0b2dldGhlciB3aXRoIG90aGVyIHBlcmZvcm1hbmNlIAo+ Pj4gcGF0Y2hlcy4KPj4gSGkgS2FsbGUsIEkgaGF2ZSB0ZXN0ZWQgd2l0aCB0aGUgcGF0Y2hlcyBv ZiBwZW5kaW5nIGJyYW5jaCwgaXQgaXMKPj4gc3VjY2Vzcy4KPj4gcmVzdWx0IGlzIHNhbWUgd2l0 aCB0aGUgcHVibGljIHJldmlldyB3aGljaCBJIHRlc3RlZCBiZWZvcmUuCj4+IAo+PiB0aGUgcGF0 Y2hlcyBJIHRlc3RlZCBvbiBwZW5kaW5nIGJyYW5jaDoKPj4gCj4+IGF0aDEwazogZW5hYmxlIGFs dCBkYXRhIG9mIFRYIHBhdGggZm9yIHNkaW8KPj4gYXRoMTBrOiBhZGQgaHR0IFRYIGJ1bmRsZSBm b3Igc2Rpbwo+PiBhdGgxMGs6IGRpc2FibGUgVFggY29tcGxldGUgaW5kaWNhdGlvbiBvZiBodHQg Zm9yIHNkaW8KPj4gYXRoMTBrOiBlbmFibGUgbmFwaSBvbiBSWCBwYXRoIGZvciBzZGlvCj4+IGF0 aDEwazogc2RpbzogcmVtb3ZlIHN0cnVjdCBhdGgxMGtfc2Rpb19yeF9kYXRhOjpzdGF0dXMKPj4g YXRoMTBrOiBzZGlvOiBjb3NtZXRpYyBjbGVhbnVwCj4+IGF0aDEwazogYWRkIHdvcmtxdWV1ZSBm b3IgUlggcGF0aCBvZiBzZGlvCj4+IGF0aDEwazogY2hhbmdlIG1heCBSWCBidW5kbGUgc2l6ZSBm cm9tIDggdG8gMzIgZm9yIHNkaW8KPj4gYXRoMTBrOiBlbmFibGUgUlggYnVuZGxlIHJlY2VpdmUg Zm9yIHNkaW8KPiAKPiBWZXJ5IGdvb2QsIHRoYW5rcyBmb3IgdGVzdGluZy4KSGkgS2FsbGUsCgp0 aGlzIHBhdGNoIHdpbGwgdHJpZ2dlciBjb25uZWN0IGZhaWwgZm9yIFBTSyBtb2RlIEFQOgphdGgx MGs6IGFkZCB3b3JrcXVldWUgZm9yIFJYIHBhdGggb2Ygc2RpbwoKSSBoYXZlIHNlbnQgcGF0Y2gg dG8gZml4IGl0OgphdGgxMGs6IGNsZWFyIGllZWU4MDIxMV9yeF9zdGF0dXMgZm9yIHNkaW8KCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmF0aDEwayBtYWls aW5nIGxpc3QKYXRoMTBrQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVh ZC5vcmcvbWFpbG1hbi9saXN0aW5mby9hdGgxMGsK