All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: Mark Brown <broonie@kernel.org>
Cc: Will Deacon <will@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Shuah Khan <shuah@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kselftest@vger.kernel.org, misono.tomohiro@fujitsu.com,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v2 0/4] selftests: arm64: vec-syscfg updates
Date: Wed, 29 Sep 2021 12:23:12 -0600	[thread overview]
Message-ID: <ee671ef8-2fb6-ae8e-cd15-ee1b98390b3a@linuxfoundation.org> (raw)
In-Reply-To: <20210929163721.GT4199@sirena.org.uk>

On 9/29/21 10:37 AM, Mark Brown wrote:
> On Wed, Sep 29, 2021 at 10:26:49AM -0600, Shuah Khan wrote:
>> On 9/29/21 9:35 AM, Will Deacon wrote:
>>> On Wed, Sep 29, 2021 at 03:43:23PM +0100, Mark Brown wrote:
> 
>>>> I'm not sure it's a particularly good idea to run kselftest as a
>>>> non-root user TBH, it's going to cause you to skip a lot of tests.
> 
>> We don't want Kselftest default run to be as root. Users can choose to
>> run as root which would be an explicit choice so they expect and plan
>> for the impact. Example panic test.
> 
> OTOH if you're trying to verify that the tests aren't broken it's not
> that great since it'll mean that you'll not be exercising a bunch of the
> code.
> 

Correct. Running Kselftest as root is the best approach for full coverage.

thanks,
-- Shuah

WARNING: multiple messages have this Message-ID
From: Shuah Khan <skhan@linuxfoundation.org>
To: Mark Brown <broonie@kernel.org>
Cc: Will Deacon <will@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	 Shuah Khan <shuah@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kselftest@vger.kernel.org, misono.tomohiro@fujitsu.com,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v2 0/4] selftests: arm64: vec-syscfg updates
Date: Wed, 29 Sep 2021 12:23:12 -0600	[thread overview]
Message-ID: <ee671ef8-2fb6-ae8e-cd15-ee1b98390b3a@linuxfoundation.org> (raw)
In-Reply-To: <20210929163721.GT4199@sirena.org.uk>

On 9/29/21 10:37 AM, Mark Brown wrote:
> On Wed, Sep 29, 2021 at 10:26:49AM -0600, Shuah Khan wrote:
>> On 9/29/21 9:35 AM, Will Deacon wrote:
>>> On Wed, Sep 29, 2021 at 03:43:23PM +0100, Mark Brown wrote:
> 
>>>> I'm not sure it's a particularly good idea to run kselftest as a
>>>> non-root user TBH, it's going to cause you to skip a lot of tests.
> 
>> We don't want Kselftest default run to be as root. Users can choose to
>> run as root which would be an explicit choice so they expect and plan
>> for the impact. Example panic test.
> 
> OTOH if you're trying to verify that the tests aren't broken it's not
> that great since it'll mean that you'll not be exercising a bunch of the
> code.
> 

Correct. Running Kselftest as root is the best approach for full coverage.

thanks,
-- Shuah

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-09-29 18:23 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-17 12:08 Mark Brown
2021-09-17 12:08 ` Mark Brown
2021-09-17 12:08 ` [PATCH v2 1/4] selftests: arm64: Fix printf() format mismatch in vec-syscfg Mark Brown
2021-09-17 12:08   ` Mark Brown
2021-09-17 12:08 ` [PATCH v2 2/4] selftests: arm64: Remove bogus error check on writing to files Mark Brown
2021-09-17 12:08   ` Mark Brown
2021-09-17 12:08 ` [PATCH v2 3/4] selftests: arm64: Fix and enable test for setting current VL in vec-syscfg Mark Brown
2021-09-17 12:08   ` Mark Brown
2021-09-17 12:08 ` [PATCH v2 4/4] selftests: arm64: Verify that all possible vector lengths are handled Mark Brown
2021-09-17 12:08   ` Mark Brown
2021-09-17 12:26   ` misono.tomohiro
2021-09-17 12:26     ` misono.tomohiro
2021-09-29 14:31 ` [PATCH v2 0/4] selftests: arm64: vec-syscfg updates Will Deacon
2021-09-29 14:31   ` Will Deacon
2021-09-29 14:43   ` Mark Brown
2021-09-29 14:43     ` Mark Brown
2021-09-29 15:35     ` Will Deacon
2021-09-29 15:35       ` Will Deacon
2021-09-29 15:38       ` Mark Brown
2021-09-29 15:38         ` Mark Brown
2021-09-29 16:26       ` Shuah Khan
2021-09-29 16:26         ` Shuah Khan
2021-09-29 16:37         ` Mark Brown
2021-09-29 16:37           ` Mark Brown
2021-09-29 18:23           ` Shuah Khan [this message]
2021-09-29 18:23             ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ee671ef8-2fb6-ae8e-cd15-ee1b98390b3a@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=misono.tomohiro@fujitsu.com \
    --cc=shuah@kernel.org \
    --cc=will@kernel.org \
    --subject='Re: [PATCH v2 0/4] selftests: arm64: vec-syscfg updates' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.