From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:51980) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gjfuI-0008Fu-UY for qemu-devel@nongnu.org; Wed, 16 Jan 2019 02:46:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gjfuH-0003Mn-RA for qemu-devel@nongnu.org; Wed, 16 Jan 2019 02:46:38 -0500 From: Vladimir Sementsov-Ogievskiy Date: Wed, 16 Jan 2019 07:46:19 +0000 Message-ID: References: <20190112175812.27068-1-eblake@redhat.com> <20190112175812.27068-4-eblake@redhat.com> In-Reply-To: <20190112175812.27068-4-eblake@redhat.com> Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-ID: <851B203108CC7C4EBA622BB8E4A39966@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v3 03/19] qemu-nbd: Sanity check partition bounds List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , "qemu-devel@nongnu.org" Cc: "nsoffer@redhat.com" , "rjones@redhat.com" , "jsnow@redhat.com" , "qemu-block@nongnu.org" MTIuMDEuMjAxOSAyMDo1NywgRXJpYyBCbGFrZSB3cm90ZToNCj4gV2hlbiB0aGUgdXNlciByZXF1 ZXN0cyBhIHBhcnRpdGlvbiwgd2Ugd2VyZSB1c2luZyBkYXRhIHJlYWQNCj4gZnJvbSB0aGUgZGlz ayBhcyBkaXNrIG9mZnNldHMgd2l0aG91dCBhIGJvdW5kcyBjaGVjay4gV2UgZ290DQo+IGx1Y2t5 IHRoYXQgZXZlbiB3aGVuIGNvbXB1dGVkIG9mZnNldHMgYXJlIG91dC1vZi1ib3VuZHMsDQo+IGJs a19wcmVhZCgpIHdpbGwgZ3JhY2VmdWxseSBjYXRjaCB0aGUgZXJyb3IgbGF0ZXIgKHNvIEkgZG9u J3QNCj4gdGhpbmsgYSBtYWxpY2lvdXMgaW1hZ2UgY2FuIGNyYXNoIG9yIGV4cGxvaXQgcWVtdS1u YmQsIGFuZCBhbQ0KPiBub3QgdHJlYXRpbmcgdGhpcyBhcyBhIHNlY3VyaXR5IGZsYXcpLCBidXQg aXQncyBiZXR0ZXIgdG8NCj4gZmxhZyB0aGUgcHJvYmxlbSB1cCBmcm9udCB0aGFuIHRvIHJpc2sg cGVybWFuZW50IEVJTyBkZWF0aCBvZg0KPiB0aGUgYmxvY2sgZGV2aWNlIGRvd24gdGhlIHJvYWQu ICBBbHNvLCBub3RlIHRoYXQgdGhlDQo+IHBhcnRpdGlvbiBjb2RlIGJsaW5kbHkgb3ZlcndyaXRl cyBhbnkgb2Zmc2V0IHBhc3NlZCBpbiBieSB0aGUNCj4gdXNlcjsgc28gbWFrZSB0aGUgLW8vLVAg Y29tYm8gYW4gZXJyb3IgZm9yIGxlc3MgY29uZnVzaW9uLg0KPiANCj4gVGhpcyBjYW4gYmUgdGVz dGVkIHdpdGggbmJka2l0Og0KPiAkIGVjaG8gaGkgPiBmaWxlDQo+ICQgbmJka2l0IC1mdiAtLWZp bHRlcj10cnVuY2F0ZSBwYXJ0aXRpb25pbmcgZmlsZSB0cnVuY2F0ZT02NGsNCj4gDQo+IFByZS1w YXRjaDoNCj4gJCBxZW11LW5iZCAtcCAxMDgxMCAtUCAxIC1mIHJhdyBuYmQ6Ly9sb2NhbGhvc3Q6 MTA4MDkgJg0KPiAkIHFlbXUtaW8gLWYgcmF3IG5iZDovL2xvY2FsaG9zdDoxMDgxMA0KPiBxZW11 LWlvPiByIC12IDAgMQ0KPiBEaXNjb25uZWN0IGNsaWVudCwgZHVlIHRvOiBGYWlsZWQgdG8gc2Vu ZCByZXBseTogcmVhZGluZyBmcm9tIGZpbGUgZmFpbGVkOiBJbnB1dC9vdXRwdXQgZXJyb3INCj4g Q29ubmVjdGlvbiBjbG9zZWQNCj4gcmVhZCBmYWlsZWQ6IElucHV0L291dHB1dCBlcnJvcg0KPiBx ZW11LWlvPiBxDQo+IFsxXSsgIERvbmUgICAgICAgICAgICAgICAgICAgIHFlbXUtbmJkIC1wIDEw ODEwIC1QIDEgLWYgcmF3IG5iZDovL2xvY2FsaG9zdDoxMDgwOQ0KPiANCj4gUG9zdC1wYXRjaDoN Cj4gJCBxZW11LW5iZCAtcCAxMDgxMCAtUCAxIC1mIHJhdyBuYmQ6Ly9sb2NhbGhvc3Q6MTA4MDkN Cj4gcWVtdS1uYmQ6IERpc2NvdmVyZWQgcGFydGl0aW9uIDEgYXQgb2Zmc2V0IDEwNDg1NzYgc2l6 ZSA1MTIsIGJ1dCBzaXplIGV4Y2VlZHMgZmlsZSBsZW5ndGggNjU1MzYNCj4gDQo+IFNpZ25lZC1v ZmYtYnk6IEVyaWMgQmxha2UgPGVibGFrZUByZWRoYXQuY29tPg0KPiAtLS0NCj4gdjM6IG5ldyBw YXRjaA0KPiAtLS0NCj4gICBxZW11LW5iZC5jIHwgMTggKysrKysrKysrKysrKysrKystDQo+ICAg MSBmaWxlIGNoYW5nZWQsIDE3IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkNCj4gDQo+IGRp ZmYgLS1naXQgYS9xZW11LW5iZC5jIGIvcWVtdS1uYmQuYw0KPiBpbmRleCA1MWI1NWYyZTA2Ni4u ZmY0YWRiOWIzZWIgMTAwNjQ0DQo+IC0tLSBhL3FlbXUtbmJkLmMNCj4gKysrIGIvcWVtdS1uYmQu Yw0KPiBAQCAtMTAxMywxMiArMTAxMywyOCBAQCBpbnQgbWFpbihpbnQgYXJnYywgY2hhciAqKmFy Z3YpDQo+ICAgICAgIGZkX3NpemUgLT0gZGV2X29mZnNldDsNCg0KVGhpcyByZXVzZSBvZiBmaWxl LXNpemUgdmFyaWFibGUgYXMgZXhwb3J0LXNpemUgaXMgYSBzb3VyY2Ugb2YgZXJyb3JzLCBsaWtl IHlvdXINCmFzc2VydCBpbiB0aGUgZm9sbG93aW5nIHBhcnQuDQoNCj4gDQo+ICAgICAgIGlmIChw YXJ0aXRpb24gIT0gLTEpIHsNCj4gLSAgICAgICAgcmV0ID0gZmluZF9wYXJ0aXRpb24oYmxrLCBw YXJ0aXRpb24sICZkZXZfb2Zmc2V0LCAmZmRfc2l6ZSk7DQo+ICsgICAgICAgIG9mZl90IGxpbWl0 Ow0KPiArDQo+ICsgICAgICAgIGlmIChkZXZfb2Zmc2V0KSB7DQo+ICsgICAgICAgICAgICBlcnJv cl9yZXBvcnQoIkNhbm5vdCByZXF1ZXN0IHBhcnRpdGlvbiBhbmQgb2Zmc2V0IHRvZ2V0aGVyIik7 DQo+ICsgICAgICAgICAgICBleGl0KEVYSVRfRkFJTFVSRSk7DQo+ICsgICAgICAgIH0NCj4gKyAg ICAgICAgcmV0ID0gZmluZF9wYXJ0aXRpb24oYmxrLCBwYXJ0aXRpb24sICZkZXZfb2Zmc2V0LCAm bGltaXQpOw0KPiAgICAgICAgICAgaWYgKHJldCA8IDApIHsNCj4gICAgICAgICAgICAgICBlcnJv cl9yZXBvcnQoIkNvdWxkIG5vdCBmaW5kIHBhcnRpdGlvbiAlZDogJXMiLCBwYXJ0aXRpb24sDQo+ ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0cmVycm9yKC1yZXQpKTsNCj4gICAgICAgICAg ICAgICBleGl0KEVYSVRfRkFJTFVSRSk7DQo+ICAgICAgICAgICB9DQo+ICsgICAgICAgIC8qIHBh cnRpdGlvbiBsaW1pdHMgYXJlICgzMi1iaXQgPDwgOSk7IGNhbid0IG92ZXJmbG93IDY0IGJpdHMg Ki8NCj4gKyAgICAgICAgYXNzZXJ0KGRldl9vZmZzZXQgPj0gMCAmJiBkZXZfb2Zmc2V0ICsgbGlt aXQgPj0gZGV2X29mZnNldCk7DQo+ICsgICAgICAgIGlmIChkZXZfb2Zmc2V0ICsgbGltaXQgPiBm ZF9zaXplKSB7DQo+ICsgICAgICAgICAgICBlcnJvcl9yZXBvcnQoIkRpc2NvdmVyZWQgcGFydGl0 aW9uICVkIGF0IG9mZnNldCAlbGxkIHNpemUgJWxsZCwgIg0KPiArICAgICAgICAgICAgICAgICAg ICAgICAgICJidXQgc2l6ZSBleGNlZWRzIGZpbGUgbGVuZ3RoICVsbGQiLCBwYXJ0aXRpb24sDQo+ ICsgICAgICAgICAgICAgICAgICAgICAgICAgKGxvbmcgbG9uZyBpbnQpIGRldl9vZmZzZXQsIChs b25nIGxvbmcgaW50KSBsaW1pdCwNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAobG9uZyBs b25nIGludCkgZmRfc2l6ZSk7DQo+ICsgICAgICAgICAgICBleGl0KEVYSVRfRkFJTFVSRSk7DQo+ ICsgICAgICAgIH0NCj4gKyAgICAgICAgZmRfc2l6ZSA9IGxpbWl0Ow0KPiAgICAgICB9DQo+IA0K PiAgICAgICBleHBvcnQgPSBuYmRfZXhwb3J0X25ldyhicywgZGV2X29mZnNldCwgZmRfc2l6ZSwg ZXhwb3J0X25hbWUsDQo+IA0KDQpPaywgYW55d2F5LCBmaW5hbGx5IEkgdW5kZXJzdGFuZCB0aGUg cG9pbnQsIHRoYW5rIHlvdSBmb3IgZGV0YWlsZWQgZXhwbGFuYXRpb246DQoNClJldmlld2VkLWJ5 OiBWbGFkaW1pciBTZW1lbnRzb3YtT2dpZXZza2l5IDx2c2VtZW50c292QHZpcnR1b3p6by5jb20+ DQoNCi0tIA0KQmVzdCByZWdhcmRzLA0KVmxhZGltaXINCg==