From: Michal Simek <michal.simek@xilinx.com>
To: u-boot@lists.denx.de
Subject: [PATCH v2 3/3] net: phy: Add DP8382x phy registration to TI PHY init
Date: Thu, 30 Apr 2020 14:14:52 +0200 [thread overview]
Message-ID: <ee97db36-a71e-aa28-30dc-b616c6f359af@xilinx.com> (raw)
In-Reply-To: <8ccddf2e-dd14-97bd-7e8b-71a9f2dc299f@ti.com>
On 30. 04. 20 13:47, Dan Murphy wrote:
> Michal
>
> On 4/30/20 3:04 AM, Michal Simek wrote:
>> On 28. 04. 20 21:26, Dan Murphy wrote:
>>> Add the DP8382X generic PHY registration to the TI PHY init file.
>>>
>>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>>> ---
>>> ? drivers/net/phy/ti_phy_init.c | 91 +++++++++++++++++++++++++++++++++++
>>> ? 1 file changed, 91 insertions(+)
>>>
>>> diff --git a/drivers/net/phy/ti_phy_init.c
>>> b/drivers/net/phy/ti_phy_init.c
>>> index 277b29a26342..47f32a528361 100644
>>> --- a/drivers/net/phy/ti_phy_init.c
>>> +++ b/drivers/net/phy/ti_phy_init.c
>>> @@ -7,12 +7,103 @@
>>> ?? * Copyright (C) 2019-20 Texas Instruments Inc.
>>> ?? */
>>> ? +
>> Useless change.
> Ack
>>> +#include <phy.h>
>>> ? #include "ti_phy_init.h"
>>> ? +#define DP83822_PHY_ID??????????? 0x2000a240
>>> +#define DP83825S_PHY_ID??????? 0x2000a140
>>> +#define DP83825I_PHY_ID??????? 0x2000a150
>>> +#define DP83825CM_PHY_ID??? 0x2000a160
>>> +#define DP83825CS_PHY_ID??? 0x2000a170
>>> +#define DP83826C_PHY_ID??????? 0x2000a130
>>> +#define DP83826NC_PHY_ID??? 0x2000a110
>> nit: Can't see value to have these macros here.
>
> Are you saying to just add the PHY IDs directly below?
others are doing that that's why I can't see the reason to do it
differently. Also normally when you look for phy id you likely want to
know what functions are called.
M
prev parent reply other threads:[~2020-04-30 12:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 19:26 [PATCH v2 0/3] TI Ethernet PHY changes Dan Murphy
2020-04-28 19:26 ` [PATCH v2 1/3] net: phy: Add helper routines to set and clear bits Dan Murphy
2020-04-30 8:00 ` Michal Simek
2020-04-30 11:43 ` Dan Murphy
2020-04-28 19:26 ` [PATCH v2 2/3] net: phy: Add support for TI PHY init Dan Murphy
2020-04-30 8:01 ` Michal Simek
2020-04-28 19:26 ` [PATCH v2 3/3] net: phy: Add DP8382x phy registration to " Dan Murphy
2020-04-30 8:04 ` Michal Simek
2020-04-30 11:47 ` Dan Murphy
2020-04-30 12:14 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee97db36-a71e-aa28-30dc-b616c6f359af@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.