All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Zhang, Rui" <rui.zhang@intel.com>
To: "Deak, Imre" <imre.deak@intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx]  ✗ Fi.CI.BAT: failure for x86/topology: fix erroneous smp_num_siblings on Intel Hybrid platform
Date: Tue, 28 Mar 2023 01:57:14 +0000	[thread overview]
Message-ID: <eea61093bde251a34038fad4ffcf91f616ff9976.camel@intel.com> (raw)
In-Reply-To: <9f995e8adb40255e5c9668d48cf04be180871092.camel@intel.com>

On Tue, 2023-03-28 at 09:14 +0800, Zhang Rui wrote:
> Hi, Imre,
> 
> Thanks for raising this.
> 
> On Tue, 2023-03-28 at 00:26 +0300, Imre Deak wrote:
> > Hi Rui,
> > 
> > after applying your
> > "x86/topology: fix erroneous smp_num_siblings on Intel Hybrid
> > platform"
> > 
> > fix on the drm-tip tree (see the patchwork URL below) the CI tests
> > show
> > some regression on a HSW and a KBL machine (see [2] and [4] below)
> > in
> > the i915 driver. However I think they can't be related to your
> > changes,
> > since on these machines all cores will report the same number of
> > CPU
> > siblings.
> 
> Right.
> 
> >  Could you confirm this and that in general the reported
> > siblings can only vary on platforms with both E and P cores (ADL-P
> > being
> > the first such platform)?
> 
> Right.
> 
> I don't think the patch could bring any change related.
> It only affects hybrid platforms.

Is this topology fix patch the only patch applied?
or together with some other patches?

I can hardly imagine that the fix patch can trigger such issues, so I
suspect they are intermittent issues. say
is the regression 100% reproducible?
does the warning/failure ever show without the patch?

BTW, I just happened to see this thread
https://lore.kernel.org/all/DM8PR11MB565580BCF44661B6A392F0CEE08B9@DM8PR11MB5655.namprd11.prod.outlook.com/
If the problem on hand has been verified to be not related with the
topology fix, can we update in this thread as well?
https://lore.kernel.org/all/20230323015640.27906-1-rui.zhang@intel.com/
This is another issue that the patch fixes. And it's better to have a
Buglink/Tested-by tag in the commit.

thanks,
rui

> 
> Thanks,
> rui
> > Thanks,
> > Imre
> > 
> > On Mon, Mar 27, 2023 at 07:02:25PM +0000, Patchwork wrote:
> > > == Series Details ==
> > > 
> > > Series: x86/topology: fix erroneous smp_num_siblings on Intel
> > > Hybrid platform
> > > URL   : https://patchwork.freedesktop.org/series/115661/
> > > State : failure
> > > 
> > > == Summary ==
> > > 
> > > CI Bug Log - changes from CI_DRM_12921 -> Patchwork_115661v1
> > > ====================================================
> > > 
> > > Summary
> > > -------
> > > 
> > >   **FAILURE**
> > > 
> > >   Serious unknown changes coming with Patchwork_115661v1
> > > absolutely
> > > need to be
> > >   verified manually.
> > >   
> > >   If you think the reported changes have nothing to do with the
> > > changes
> > >   introduced in Patchwork_115661v1, please notify your bug team
> > > to
> > > allow them
> > >   to document this new failure mode, which will reduce false
> > > positives in CI.
> > > 
> > >   External URL: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115661v1/index.html
> > > 
> > > Participating hosts (37 -> 37)
> > > ------------------------------
> > > 
> > >   No changes in participating hosts
> > > 
> > > Possible new issues
> > > -------------------
> > > 
> > >   Here are the unknown changes that may have been introduced in
> > > Patchwork_115661v1:
> > > 
> > > ### IGT changes ###
> > > 
> > > #### Possible regressions ####
> > > 
> > >   * igt@i915_selftest@live@hangcheck:
> > >     - fi-hsw-4770:        [PASS][1] -> [DMESG-WARN][2]
> > >    [1]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12921/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
> > >    [2]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115661v1/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
> > > 
> > >   
> > > #### Suppressed ####
> > > 
> > >   The following results come from untrusted machines, tests, or
> > > statuses.
> > >   They do not affect the overall result.
> > > 
> > >   * igt@fbdev@info:
> > >     - {bat-kbl-2}:        [SKIP][3] ([fdo#109271]) -> [ABORT][4]
> > >    [3]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12921/bat-kbl-2/igt@fbdev@info.html
> > >    [4]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115661v1/bat-kbl-2/igt@fbdev@info.html
> > > 
> > >   
> > > Known issues
> > > ------------
> > > 
> > >   Here are the changes found in Patchwork_115661v1 that come from
> > > known issues:
> > > 
> > > ### IGT changes ###
> > > 
> > > #### Issues hit ####
> > > 
> > >   * igt@gem_exec_suspend@basic-s3@lmem0:
> > >     - bat-dg2-11:         [PASS][5] -> [INCOMPLETE][6]
> > > ([i915#6311])
> > >    [5]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12921/bat-dg2-11/igt@gem_exec_suspend@basic-s3@lmem0.html
> > >    [6]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115661v1/bat-dg2-11/igt@gem_exec_suspend@basic-s3@lmem0.html
> > > 
> > >   * igt@i915_selftest@live@reset:
> > >     - bat-rpls-1:         [PASS][7] -> [ABORT][8] ([i915#4983])
> > >    [7]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12921/bat-rpls-1/igt@i915_selftest@live@reset.html
> > >    [8]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115661v1/bat-rpls-1/igt@i915_selftest@live@reset.html
> > > 
> > >   * igt@i915_selftest@live@slpc:
> > >     - bat-rpls-2:         NOTRUN -> [DMESG-FAIL][9] ([i915#6367]
> > > /
> > > [i915#7913] / [i915#7996])
> > >    [9]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115661v1/bat-rpls-2/igt@i915_selftest@live@slpc.html
> > > 
> > >   * igt@i915_suspend@basic-s3-without-i915:
> > >     - bat-rpls-2:         NOTRUN -> [ABORT][10] ([i915#6687] /
> > > [i915#7978])
> > >    [10]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115661v1/bat-rpls-2/igt@i915_suspend@basic-s3-without-i915.html
> > > 
> > >   * igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-d-
> > > dp-1:
> > >     - bat-dg2-8:          [PASS][11] -> [FAIL][12] ([i915#7932])
> > >    [11]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12921/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-d-dp-1.html
> > >    [12]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115661v1/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-d-dp-1.html
> > > 
> > >   
> > > #### Possible fixes ####
> > > 
> > >   * igt@i915_selftest@live@gt_heartbeat:
> > >     - fi-kbl-soraka:      [DMESG-FAIL][13] ([i915#5334] /
> > > [i915#7872]) -> [PASS][14]
> > >    [13]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12921/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
> > >    [14]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115661v1/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
> > > 
> > >   * igt@i915_selftest@live@reset:
> > >     - bat-rpls-2:         [ABORT][15] ([i915#4983] / [i915#7913])
> > > -> [PASS][16]
> > >    [15]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12921/bat-rpls-2/igt@i915_selftest@live@reset.html
> > >    [16]: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115661v1/bat-rpls-2/igt@i915_selftest@live@reset.html
> > > 
> > >   
> > >   {name}: This element is suppressed. This means it is ignored
> > > when
> > > computing
> > >           the status of the difference (SUCCESS, WARNING, or
> > > FAILURE).
> > > 
> > >   [fdo#109271]: 
> > > https://bugs.freedesktop.org/show_bug.cgi?id=109271
> > >   [i915#4983]: 
> > > https://gitlab.freedesktop.org/drm/intel/issues/4983
> > >   [i915#5334]: 
> > > https://gitlab.freedesktop.org/drm/intel/issues/5334
> > >   [i915#6311]: 
> > > https://gitlab.freedesktop.org/drm/intel/issues/6311
> > >   [i915#6367]: 
> > > https://gitlab.freedesktop.org/drm/intel/issues/6367
> > >   [i915#6687]: 
> > > https://gitlab.freedesktop.org/drm/intel/issues/6687
> > >   [i915#7872]: 
> > > https://gitlab.freedesktop.org/drm/intel/issues/7872
> > >   [i915#7913]: 
> > > https://gitlab.freedesktop.org/drm/intel/issues/7913
> > >   [i915#7932]: 
> > > https://gitlab.freedesktop.org/drm/intel/issues/7932
> > >   [i915#7978]: 
> > > https://gitlab.freedesktop.org/drm/intel/issues/7978
> > >   [i915#7996]: 
> > > https://gitlab.freedesktop.org/drm/intel/issues/7996
> > > 
> > > 
> > > Build changes
> > > -------------
> > > 
> > >   * Linux: CI_DRM_12921 -> Patchwork_115661v1
> > > 
> > >   CI-20190529: 20190529
> > >   CI_DRM_12921: 3de6040ce9900a94ec626662d5c6a227b37eeb1c @
> > > git://anongit.freedesktop.org/gfx-ci/linux
> > >   IGT_7221: 4b77c6d85024d22ca521d510f8eee574128fe04f @ 
> > > https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
> > >   Patchwork_115661v1: 3de6040ce9900a94ec626662d5c6a227b37eeb1c @
> > > git://anongit.freedesktop.org/gfx-ci/linux
> > > 
> > > 
> > > ### Linux commits
> > > 
> > > 83d9e76610d5 x86/topology: fix erroneous smp_num_siblings on
> > > Intel
> > > Hybrid platform
> > > 
> > > == Logs ==
> > > 
> > > For more details see: 
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115661v1/index.html

  reply	other threads:[~2023-03-28  1:57 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-27 12:11 [Intel-gfx] [core-for-CI] x86/topology: fix erroneous smp_num_siblings on Intel Hybrid platform Imre Deak
2023-03-27 12:46 ` Saarinen, Jani
2023-03-27 18:45 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2023-03-27 19:02 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-03-27 21:26   ` Imre Deak
2023-03-28  1:14     ` Zhang, Rui
2023-03-28  1:57       ` Zhang, Rui [this message]
2023-03-28  6:34         ` Saarinen, Jani
2023-03-28  6:47           ` Saarinen, Jani
2023-03-28  7:23         ` Imre Deak
2023-03-28  8:00 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for x86/topology: fix erroneous smp_num_siblings on Intel Hybrid platform (rev2) Patchwork
2023-03-28  8:13 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-03-28 15:32 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-03-28 15:59 ` [Intel-gfx] [core-for-CI] x86/topology: fix erroneous smp_num_siblings on Intel Hybrid platform Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eea61093bde251a34038fad4ffcf91f616ff9976.camel@intel.com \
    --to=rui.zhang@intel.com \
    --cc=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.