From: Paolo Bonzini <pbonzini@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: qemu-devel <qemu-devel@nongnu.org>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: QOM address space handling
Date: Tue, 10 Nov 2020 16:08:16 +0100 [thread overview]
Message-ID: <eec01576-51b4-e52b-f511-b127c6182da3@redhat.com> (raw)
In-Reply-To: <20201110150333.GE5733@habkost.net>
On 10/11/20 16:03, Eduardo Habkost wrote:
>> Does anyone have any arguments for which solution is preferred?
> I'd say (2) is preferred, as we don't expect object_new(T) to
> have any side effects outside the object instance state.
Since there are no listeners, the side effects of address_space_init()
are relatively limited. So doing it in instance_init is not a big deal.
> Most
> address_space_init() calls in the code today seem to be in
> realize functions.
>
> However, I wonder if we could make this simpler (and mistakes
> less fatal) if we make AddressSpace a QOM child of the device.
> Paolo, would it be too much overhead to make AddressSpace a QOM
> object?
No, it wouldn't. AddressSpace is already quite heavyweight.
Paolo
next prev parent reply other threads:[~2020-11-10 15:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 11:14 QOM address space handling Mark Cave-Ayland
2020-11-10 11:40 ` Paolo Bonzini
2020-12-18 7:49 ` Mark Cave-Ayland
2020-12-18 22:32 ` Eduardo Habkost
2020-12-20 9:25 ` Paolo Bonzini
2020-12-21 18:54 ` Eduardo Habkost
2020-12-21 19:16 ` Paolo Bonzini
2020-12-21 19:28 ` Eduardo Habkost
2020-11-10 15:03 ` Eduardo Habkost
2020-11-10 15:08 ` Paolo Bonzini [this message]
2020-11-10 17:46 ` Eduardo Habkost
2020-11-10 18:36 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eec01576-51b4-e52b-f511-b127c6182da3@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.