All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heinrich Schuchardt <xypron.glpk@gmx.de>
To: Michael Lawnick <ml.lawnick@gmx.de>
Cc: sjg@chromium.org, u-boot@lists.denx.de
Subject: Re: RFC: exclude partitions from efi_selftest
Date: Tue, 14 Sep 2021 17:57:17 +0200	[thread overview]
Message-ID: <eed29349-9b19-12cc-3030-c7d3c02fb622@gmx.de> (raw)
In-Reply-To: <26bcd1d1-7d39-91a4-a0d4-942efd0826a9@gmx.de>

On 9/14/21 4:56 PM, Michael Lawnick wrote:
> Hi,
>
> in our environment we get error on efi_selftest if one of several SSD
> partitions isn't properly initialized (due to some other error, but
> that's a different topic). I tried to track down to where the partitions
> get registered for test but got a bit lost so I request advice from you.

When the UEFI sub-system is intialized we call efi_disk_register(). If
it fails, we don't enter the UEFI sub-system.

Are you able to identify where efi_disk_register() fails?

>
> Shouldn't be the registering of partitions for self test been made
> dependent on successful basic init? I wouldn't qualify a non-initialized
> partition as reason to let self test fail. If at all a warning should be
> sufficient.
> As far as I understand efi self test is intended more as a functional
> regression test, not a H/W system test, isn't it?
> What about the idea to allow to exclude partitions by environment variable?

We use efi_selftest in our continuous integration. Patches that make it
fail will not be accepted upstream. It is nothing that you need on a
deployed production system.

Best regards

Heinrich

>
> KR
> Michael


  reply	other threads:[~2021-09-14 15:57 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-14 14:56 RFC: exclude partitions from efi_selftest Michael Lawnick
2021-09-14 15:57 ` Heinrich Schuchardt [this message]
2021-09-15  9:56   ` Michael Lawnick
2021-09-15 10:42     ` Heinrich Schuchardt
2021-09-15 10:54       ` Michael Lawnick
2021-09-15 11:22         ` Heinrich Schuchardt
2021-09-15 11:36           ` Michael Lawnick
2021-09-15 15:06             ` Michael Lawnick
2021-09-16  7:12               ` AKASHI Takahiro
2021-09-16  7:15                 ` Michael Lawnick
2021-09-16  7:48                   ` Michael Lawnick
2021-09-16  8:02                     ` AKASHI Takahiro
2021-09-16  9:14                       ` Michael Lawnick
2021-09-16  9:37                         ` AKASHI Takahiro
2021-09-16 11:19                           ` Michael Lawnick
2021-09-15 12:00       ` Mark Kettenis
2021-09-16  6:59         ` AKASHI Takahiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eed29349-9b19-12cc-3030-c7d3c02fb622@gmx.de \
    --to=xypron.glpk@gmx.de \
    --cc=ml.lawnick@gmx.de \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.