From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1E6CC4332F for ; Thu, 7 Apr 2022 19:06:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347091AbiDGTI0 (ORCPT ); Thu, 7 Apr 2022 15:08:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234086AbiDGTIZ (ORCPT ); Thu, 7 Apr 2022 15:08:25 -0400 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E972D1B9327 for ; Thu, 7 Apr 2022 12:06:23 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id f18so7547805edc.5 for ; Thu, 07 Apr 2022 12:06:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=gOv/51dHbvSvAxLzxG0YE6pJrgjLizkZFj88kA5U1Ts=; b=O9N5piyZ8ghdKuId5L9aiMvkNuf62owbuCE+bZDTC6+xdnskK2aUwjkRUGOHdchCvA /J+QuQpbFJM/EfFm8RsWGeBGnPnBdya6DSH3nBGlfOGxOQfphaxLgDC+zzgMMt+VmjXu OSMZhW68bPY1HCTsk1/kZgPdo6KTzbrFSetJ89hvIb1T7A9C/NsRlGJk36F6rGcSxWLF js+BATsURtMBOD9XP5WBgZ8B9ahlWlXnGEpQSISIIdLvqgDDKE4wkVtb80Yln+Nyneo5 sOOhyqrnY0o9IB8O7pFrrQJI/FsA2bBNe7fN2rsX34K5jkhc7gGS5VTCFiWFKPd1F1JU lubQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=gOv/51dHbvSvAxLzxG0YE6pJrgjLizkZFj88kA5U1Ts=; b=0iVPqlqx+RE1bt7292bFYACJxyY1DHf0uMZYpEXHrWGpp+5X1LyTcL7UKiGlNbeKel v8bNs8IEMT6Lnx4FF9v5/cSoIo2guvZnEmH/hTFsXgIE+sU+fsj4hRYsLZnyUGcnPeOS KZ9pEqnqOS0Ai0OJEcumz2u9A1396DxPQefOq8/oWe3e96J3Z7WiOoHpbxPl9Jl697v8 73mWyYmhHMLPxz8q4EdQ9LgmQp1jou+zqhEl4QXl1aIhA7ufAN3HbKjL06T/FsjEy45G /npyc+wfKKp9diiheV9pQQx2zuoWyuAeooy8o8rUpQCQxLNOgdm8b9wk5IZoOnDvXeSC ErgA== X-Gm-Message-State: AOAM530a0h2qN5c3Nyv1nNaT4c04l5cA2KbBgY6RatKjfC5Ev206CzoL zPvlfNfIXZaPT2RqC8ZYULR+/Q== X-Google-Smtp-Source: ABdhPJyhh/Yt+dDqYCjKan4H/N0nxJOJereGCAdjBh0lD6wnLfFa+OHp2IVxiD8+UeuiyRjWGDtvFA== X-Received: by 2002:a50:e79b:0:b0:41c:dd2c:3e19 with SMTP id b27-20020a50e79b000000b0041cdd2c3e19mr15774315edn.291.1649358382461; Thu, 07 Apr 2022 12:06:22 -0700 (PDT) Received: from [192.168.0.187] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id q15-20020a1709060e4f00b006cdf4535cf2sm7890988eji.67.2022.04.07.12.06.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Apr 2022 12:06:21 -0700 (PDT) Message-ID: Date: Thu, 7 Apr 2022 21:06:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 11/11] arm64: dts: Add Pensando Elba SoC support Content-Language: en-US To: Brad Larson , linux-arm-kernel@lists.infradead.org Cc: arnd@arndb.de, linus.walleij@linaro.org, bgolaszewski@baylibre.com, broonie@kernel.org, fancer.lancer@gmail.com, adrian.hunter@intel.com, ulf.hansson@linaro.org, olof@lixom.net, dac2@pensando.io, linux-gpio@vger.kernel.org, linux-spi@vger.kernel.org, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220406233648.21644-1-brad@pensando.io> <20220406233648.21644-12-brad@pensando.io> From: Krzysztof Kozlowski In-Reply-To: <20220406233648.21644-12-brad@pensando.io> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 07/04/2022 01:36, Brad Larson wrote: > Add Pensando common and Elba SoC specific device nodes > > Signed-off-by: Brad Larson > --- > Change from V3: > - Changed to dual copyright (GPL-2.0+ OR MIT) > - Minor changes from review input Thank you for your patch. There is something to discuss/improve. (...) > +&i2c0 { > + clock-frequency = <100000>; > + status = "okay"; > + rtc@51 { > + compatible = "nxp,pcf85263"; > + reg = <0x51>; > + }; > +}; > + > +&spi0 { > + num-cs = <4>; > + cs-gpios = <0>, <0>, <&porta 1 GPIO_ACTIVE_LOW>, > + <&porta 7 GPIO_ACTIVE_LOW>; > + status = "okay"; > + spi0_cs0@0 { Generic node name needed matching the class of a devicxe. > + compatible = "semtech,sx1301"; /* Enable spidev */ This comment is a bit odd... did you just use random compatible from spidev instead of defining proper compatible? > + #address-cells = <1>; > + #size-cells = <1>; Why address/size cells? > + spi-max-frequency = <12000000>; > + reg = <0>; Please put reg just after compatible. It's the most common pattern. > + }; > + > + spi0_cs1@1 { > + compatible = "semtech,sx1301"; > + #address-cells = <1>; > + #size-cells = <1>; > + spi-max-frequency = <12000000>; > + reg = <1>; > + }; > + (...) > + > + emmc: mmc@30440000 { > + compatible = "pensando,elba-sd4hc", "cdns,sd4hc"; > + clocks = <&emmc_clk>; > + interrupts = ; > + reg = <0x0 0x30440000 0x0 0x10000>, > + <0x0 0x30480044 0x0 0x4>; /* byte-lane ctrl */ > + cdns,phy-input-delay-sd-highspeed = <0x4>; > + cdns,phy-input-delay-legacy = <0x4>; > + cdns,phy-input-delay-sd-uhs-sdr50 = <0x6>; > + cdns,phy-input-delay-sd-uhs-ddr50 = <0x16>; > + mmc-ddr-1_8v; > + status = "disabled"; > + }; > + > + mssoc: mssoc@307c0000 { Generic node name. > + compatible = "syscon", "simple-mfd"; This does not look correct. Syscon is okay, but why do you need simple-mfd (there are no children here)? > + reg = <0x0 0x307c0000 0x0 0x3000>; > + }; > + }; > +}; Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EA468C433FE for ; Thu, 7 Apr 2022 19:07:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8iQgMCy7yB8XZ4BfRSPw0Dym9pxapG/CdL5d17IJHkg=; b=xNBT4Ww8QSEdpq LwLW6nkEy0JYMtpot/MK2BhtFLsOZRJVaMh5z/IihfuNi+rJOBQkZtsf4l/fnerm5Koz/lZCcTcdH r83pEnQVotNvGoSoTPiS7pez9W0iPIqMgGlSoA/1JCp92k3uiHzlwsOIs98QAC1N2FV16NtY5MIvn rfgVeIfbH2BfNU3LH0BSABLKI1qIBwJPzUGMcH4Jjn1DzI7Zd7jgWL2xeqxzGzFEzgwgB1Wo1y1Lq jDphU+xxrBQDqfRejY3jYG4+bGalUCL2DnM7MIdP379Zvt7Ar62Kbl8tPKYkil8r1qzeIE1YUOHv3 R22zCa/xe9sGZ0+0zbHw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncXSc-00DfLN-Ov; Thu, 07 Apr 2022 19:06:26 +0000 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncXSa-00DfKW-2U for linux-arm-kernel@lists.infradead.org; Thu, 07 Apr 2022 19:06:25 +0000 Received: by mail-ed1-x531.google.com with SMTP id w18so7487982edi.13 for ; Thu, 07 Apr 2022 12:06:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=gOv/51dHbvSvAxLzxG0YE6pJrgjLizkZFj88kA5U1Ts=; b=O9N5piyZ8ghdKuId5L9aiMvkNuf62owbuCE+bZDTC6+xdnskK2aUwjkRUGOHdchCvA /J+QuQpbFJM/EfFm8RsWGeBGnPnBdya6DSH3nBGlfOGxOQfphaxLgDC+zzgMMt+VmjXu OSMZhW68bPY1HCTsk1/kZgPdo6KTzbrFSetJ89hvIb1T7A9C/NsRlGJk36F6rGcSxWLF js+BATsURtMBOD9XP5WBgZ8B9ahlWlXnGEpQSISIIdLvqgDDKE4wkVtb80Yln+Nyneo5 sOOhyqrnY0o9IB8O7pFrrQJI/FsA2bBNe7fN2rsX34K5jkhc7gGS5VTCFiWFKPd1F1JU lubQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=gOv/51dHbvSvAxLzxG0YE6pJrgjLizkZFj88kA5U1Ts=; b=VWKrl3SbXjTvsg3NhyPv1LnoIKVD5YJIKpN2MZDI07U2ic55Vp7IHDVznN15b9GQJn S5Iv31+ywsbtohFNGy03+FJLG+GsgM7uRC80igr2kpxw0tyzlwO69OhdTxCM62cOulSK e79jR+lmqKqR85GpHSg4K1wvuJmgVj48QomR7b+3Qn+01pa4CUQbgPTi+aY0tiuxQfV1 Mxwjbc+eKwcCV+g825lgyqWBkZgqgKvVE7938bPGuOdQBlqFGXEmaakT0CnHtjrZvEKS ntxRfMN8C3rx+KITLIO5tUbI5CSv6tK3IzPCPH5e+KplpD05QHwp27RdpKN2tLEeNlL/ eVdg== X-Gm-Message-State: AOAM533EnitYeEolTKLe3Z+RRpgvo3YZ7jLDbJUFHoUaCpgXhzXsXpIG hp56f7ZYUbg3I0xTj0crxfQ6rA== X-Google-Smtp-Source: ABdhPJyhh/Yt+dDqYCjKan4H/N0nxJOJereGCAdjBh0lD6wnLfFa+OHp2IVxiD8+UeuiyRjWGDtvFA== X-Received: by 2002:a50:e79b:0:b0:41c:dd2c:3e19 with SMTP id b27-20020a50e79b000000b0041cdd2c3e19mr15774315edn.291.1649358382461; Thu, 07 Apr 2022 12:06:22 -0700 (PDT) Received: from [192.168.0.187] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id q15-20020a1709060e4f00b006cdf4535cf2sm7890988eji.67.2022.04.07.12.06.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Apr 2022 12:06:21 -0700 (PDT) Message-ID: Date: Thu, 7 Apr 2022 21:06:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 11/11] arm64: dts: Add Pensando Elba SoC support Content-Language: en-US To: Brad Larson , linux-arm-kernel@lists.infradead.org Cc: arnd@arndb.de, linus.walleij@linaro.org, bgolaszewski@baylibre.com, broonie@kernel.org, fancer.lancer@gmail.com, adrian.hunter@intel.com, ulf.hansson@linaro.org, olof@lixom.net, dac2@pensando.io, linux-gpio@vger.kernel.org, linux-spi@vger.kernel.org, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220406233648.21644-1-brad@pensando.io> <20220406233648.21644-12-brad@pensando.io> From: Krzysztof Kozlowski In-Reply-To: <20220406233648.21644-12-brad@pensando.io> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220407_120624_176520_7634D676 X-CRM114-Status: GOOD ( 14.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 07/04/2022 01:36, Brad Larson wrote: > Add Pensando common and Elba SoC specific device nodes > > Signed-off-by: Brad Larson > --- > Change from V3: > - Changed to dual copyright (GPL-2.0+ OR MIT) > - Minor changes from review input Thank you for your patch. There is something to discuss/improve. (...) > +&i2c0 { > + clock-frequency = <100000>; > + status = "okay"; > + rtc@51 { > + compatible = "nxp,pcf85263"; > + reg = <0x51>; > + }; > +}; > + > +&spi0 { > + num-cs = <4>; > + cs-gpios = <0>, <0>, <&porta 1 GPIO_ACTIVE_LOW>, > + <&porta 7 GPIO_ACTIVE_LOW>; > + status = "okay"; > + spi0_cs0@0 { Generic node name needed matching the class of a devicxe. > + compatible = "semtech,sx1301"; /* Enable spidev */ This comment is a bit odd... did you just use random compatible from spidev instead of defining proper compatible? > + #address-cells = <1>; > + #size-cells = <1>; Why address/size cells? > + spi-max-frequency = <12000000>; > + reg = <0>; Please put reg just after compatible. It's the most common pattern. > + }; > + > + spi0_cs1@1 { > + compatible = "semtech,sx1301"; > + #address-cells = <1>; > + #size-cells = <1>; > + spi-max-frequency = <12000000>; > + reg = <1>; > + }; > + (...) > + > + emmc: mmc@30440000 { > + compatible = "pensando,elba-sd4hc", "cdns,sd4hc"; > + clocks = <&emmc_clk>; > + interrupts = ; > + reg = <0x0 0x30440000 0x0 0x10000>, > + <0x0 0x30480044 0x0 0x4>; /* byte-lane ctrl */ > + cdns,phy-input-delay-sd-highspeed = <0x4>; > + cdns,phy-input-delay-legacy = <0x4>; > + cdns,phy-input-delay-sd-uhs-sdr50 = <0x6>; > + cdns,phy-input-delay-sd-uhs-ddr50 = <0x16>; > + mmc-ddr-1_8v; > + status = "disabled"; > + }; > + > + mssoc: mssoc@307c0000 { Generic node name. > + compatible = "syscon", "simple-mfd"; This does not look correct. Syscon is okay, but why do you need simple-mfd (there are no children here)? > + reg = <0x0 0x307c0000 0x0 0x3000>; > + }; > + }; > +}; Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel